Config

Complexity

Total Complexity

13

Size/Duplication

Total Lines	94
Duplicated Lines	21.28 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	10	15	4
A	loadJsConfig()	10	13	3
A	getJsConfig()	0	13	4
A	addJsConfig()	0	6	2

<?php

/**
 * Config class.
 * Gets a configuration value
 *
 * @license    http://opensource.org/licenses/MIT The MIT License (MIT)
 * @author     Omar El Gabry <omar.elgabry.93@gmail.com>
 */

class Config{

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * Array of configurations
     *
     * @var array
     */
    public static $config = null;

    /**
     * Array of javascript configurations
     *
     * @var array
     */
    public static $jsConfig = null;

    /**
     * Gets a configuration value
     *
     * @param $key string
     * @return string|null
     * @throws Exception if configuration file doesn't exist
     */
    public static function get($key){

        if (!self::$config) {

The expression self::$config of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This code seems to be duplicated across your project.

	        $config_file = APP . 'config/config.php';

			if (!file_exists($config_file)) {
				throw new Exception("Configuration file doesn't exist");
			}

	        self::$config = require $config_file . "";
        }

        return isset(self::$config[$key])? self::$config[$key]: null;
    }

    /**
     * Loads javascript configurations
     *
     * @param $key string
     * @return string|null
     * @throws Exception if configuration file doesn't exist
     */
    private static function loadJsConfig(){

        if (!self::$jsConfig) {

The expression self::$jsConfig of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This code seems to be duplicated across your project.

            $config_file = APP . 'config/javascript.php';

            if (!file_exists($config_file)) {
                throw new Exception("JavaScript Configuration file doesn't exist");
            }

            self::$jsConfig = require $config_file . "";
        }
    }

    /**
     * Gets javascript configuration value(s)
     *
     * @param $key string
     * @return string|array|null
     * @throws Exception if configuration file doesn't exist
     */
    public static function getJsConfig($key = ""){
        
        if (!self::$jsConfig) {

The expression self::$jsConfig of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            self::loadJsConfig();
        }

        if(empty($key)){
            return self::$jsConfig;
        }else if(isset(self::$jsConfig[$key])){
            return self::$jsConfig[$key];
        }
        return null;
    }

    /**
     * Adds a new variable to javascript configurations
     *
     * @param string $key
     * @param mixed  $value
     */
    public static function addJsConfig($key, $value){
        if (!self::$jsConfig) {

The expression self::$jsConfig of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            self::loadJsConfig();
        }
        self::$jsConfig[$key] = $value;
    }
}