Issues in AuthServiceProvider.php (master) - Issues in master - OmarElGabry/lumen-api-oauth - Measure and Improve Code Quality continuously with Scrutinizer

Issues (30)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Providers/AuthServiceProvider.php (5 issues)

Labels

Severity

Minor 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Providers;

use App\User;
use Illuminate\Support\Facades\Gate;
use Illuminate\Support\ServiceProvider;

class AuthServiceProvider extends ServiceProvider
{
    /**
     * Register any application services.
     *
     * @return void
     */
    public function register()
    {
        //
    }

    /**
     * Boot the authentication services for the application.
     *
     * @return void
     * @see    https://lumen.laravel.com/docs/authorization
     */
    public function boot()
    {
        // Here you may define how you wish users to be authenticated for your Lumen
        // application. The callback which receives the incoming request instance
        // should return either a User instance or null. You're free to obtain
        // the User instance via an API token or any other method necessary.

        // $this->app['auth']->viaRequest('api', function ($request) {

        //     if ($request->input('api_token')) {

        //         return User::where('api_token', $request->input('api_token'))->first();

        //     }
        // });

        // Group & Define simillar Abilities
        $this->isOwner([
            'posts' => ['destroy', 'update'],
            'comments' => ['destroy', 'update']
        ]);

        $this->isAdmin([
            'users' => ['store', 'destroy', 'update']
        ]);
    }

    /**
     * Define abilities that checks if the current user is the owner of the requested resource.
     * In case of admin user, it will return true.
     *
     * @param  array  $arguments
     * @return boolean
     */
    private function isOwner($arguments = []){

        foreach ($arguments as $resource => $actions) {
            foreach ($actions as $action) {

                // Gate::before(function ($user, $ability) {

                //     if($user->is_admin){

                //      return true;
                //     }
                // });

                Gate::define($this->ability($action, $resource), function ($user, $arg) {
                   
                    if(is_null($arg))  { return false; }

                    return $arg->user_id === $user->id || $user->is_admin;
                });            
            }
        }
    }

    /**
     * Define abilities that checks if the current user is admin.
     *
     * @param  array  $arguments
     * @return boolean
     */
    private function isAdmin($arguments){

        foreach ($arguments as $resource => $actions) {
            foreach ($actions as $action) {
                Gate::define($this->ability($action, $resource), function ($user) {
                    return $user->is_admin;
                });
            }
        }
    }

    /**
     * Define ability string.
     * 
     * @param  string  $action
     * @param  string  $resource
     * @return string
     */
    private function ability($action, $resource){
        return "{$action}-{$resource}";
    }
    
}


1			<?php
2
3			namespace App\Providers;
4
5			use App\User;
6			use Illuminate\Support\Facades\Gate;
7			use Illuminate\Support\ServiceProvider;
8
9			class AuthServiceProvider extends ServiceProvider
10			{
11			/**
12			* Register any application services.
13			*
14			* @return void
15			*/
16			public function register()
17			{
18			//
19			}
20
21			/**
22			* Boot the authentication services for the application.
23			*
24			* @return void
25			* @see https://lumen.laravel.com/docs/authorization
26			*/
27			public function boot()
28			{
29			// Here you may define how you wish users to be authenticated for your Lumen
30			// application. The callback which receives the incoming request instance
31			// should return either a User instance or null. You're free to obtain
32			// the User instance via an API token or any other method necessary.
33
34			// $this->app['auth']->viaRequest('api', function ($request) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-07-02 14:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35			// if ($request->input('api_token')) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36			// return User::where('api_token', $request->input('api_token'))->first();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
37			// }
38			// });
39
40			// Group & Define simillar Abilities
41			$this->isOwner([
42			'posts' => ['destroy', 'update'],
43			'comments' => ['destroy', 'update']
44			]);
45
46			$this->isAdmin([
47			'users' => ['store', 'destroy', 'update']
48			]);
49			}
50
51			/**
52			* Define abilities that checks if the current user is the owner of the requested resource.
53			* In case of admin user, it will return true.
54			*
55			* @param array $arguments
56			* @return boolean
57			*/
58			private function isOwner($arguments = []){
59
60			foreach ($arguments as $resource => $actions) {
61			foreach ($actions as $action) {
62
63			// Gate::before(function ($user, $ability) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
64			// if($user->is_admin){
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
65			// return true;
66			// }
67			// });
68
69			Gate::define($this->ability($action, $resource), function ($user, $arg) {
70
71			if(is_null($arg)) { return false; }
72
73			return $arg->user_id === $user->id \|\| $user->is_admin;
74			});
75			}
76			}
77			}
78
79			/**
80			* Define abilities that checks if the current user is admin.
81			*
82			* @param array $arguments
83			* @return boolean
84			*/
85			private function isAdmin($arguments){
86
87			foreach ($arguments as $resource => $actions) {
88			foreach ($actions as $action) {
89			Gate::define($this->ability($action, $resource), function ($user) {
90			return $user->is_admin;
91			});
92			}
93			}
94			}
95
96			/**
97			* Define ability string.
98			*
99			* @param string $action
100			* @param string $resource
101			* @return string
102			*/
103			private function ability($action, $resource){
104			return "{$action}-{$resource}";
105			}
106
107			}
108

OmarElGabry / lumen-api-oauth

Issues (30)

Security Analysis no request data

app/Providers/AuthServiceProvider.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like