Issues in Controller.php (master) - Issues in master - OmarElGabry/lumen-api-oauth - Measure and Improve Code Quality continuously with Scrutinizer

Issues (30)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/Controllers/Controller.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php 

namespace App\Http\Controllers;

use Laravel\Lumen\Routing\Controller as BaseController;
use Illuminate\Http\Request;
use App\User;
use Gate;

class Controller extends BaseController{

    /**
     * Return a JSON response for success.
     *
     * @param  array  $data
     * @param  string $code
     * @return \Illuminate\Http\JsonResponse
     */
	public function success($data, $code){
		return response()->json(['data' => $data], $code);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
	}

    /**
     * Return a JSON response for error.
     *
     * @param  array  $message
     * @param  string $code
     * @return \Illuminate\Http\JsonResponse
     */
	public function error($message, $code){
		return response()->json(['message' => $message], $code);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
	}

    /**
     * Check if the user is authorized to perform a given action on a resource.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  array $resource
     * @param  mixed|array $arguments
     * @return boolean
     * @see    https://lumen.laravel.com/docs/authorization 
     */
    protected function authorizeUser(Request $request, $resource, $arguments = []){
    	
    	$user 	 = User::find($this->getUserId());
    	$action	 = $this->getAction($request); 

        // The ability string must match the string defined in App\Providers\AuthServiceProvider\ability()
        $ability = "{$action}-{$resource}";

    	// return $this->authorizeForUser($user, "{$action}-{$resource}", $data);

    	return Gate::forUser($user)->allows($ability, $arguments);
    }

    /**
     * Check if user is authorized.
     *
     * This method will be called by "Authorize" Middleware for every controller.
     * Controller that needs to be authorized must override this method.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return bool
     */
    public function isAuthorized(Request $request){
        return false;
    }

    /**
     * Get current authorized user id.
     * This method should be called only after validating the access token using OAuthMiddleware Middleware.
     *
     * @return boolean
     */
    protected function getUserId(){
    	return \LucaDegasperi\OAuth2Server\Facades\Authorizer::getResourceOwnerId();
    }

    /**
     * Get the requested action method.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return string
     */
    protected function getAction(Request $request){
        return explode('@', $request->route()[1]["uses"], 2)[1];
    }

    /**
     * Get the parameters in route.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return array
     */
    protected function getArgs(Request $request){
        return $request->route()[2];
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Laravel\Lumen\Routing\Controller as BaseController;
6			use Illuminate\Http\Request;
7			use App\User;
8			use Gate;
9
10			class Controller extends BaseController{
11
12			/**
13			* Return a JSON response for success.
14			*
15			* @param array $data
16			* @param string $code
17			* @return \Illuminate\Http\JsonResponse
18			*/
19			public function success($data, $code){
20			return response()->json(['data' => $data], $code);
			0 ignored issues – show Bug introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21			}
22
23			/**
24			* Return a JSON response for error.
25			*
26			* @param array $message
27			* @param string $code
28			* @return \Illuminate\Http\JsonResponse
29			*/
30			public function error($message, $code){
31			return response()->json(['message' => $message], $code);
			0 ignored issues – show Bug introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
32			}
33
34			/**
35			* Check if the user is authorized to perform a given action on a resource.
36			*
37			* @param \Illuminate\Http\Request $request
38			* @param array $resource
39			* @param mixed\|array $arguments
40			* @return boolean
41			* @see https://lumen.laravel.com/docs/authorization
42			*/
43			protected function authorizeUser(Request $request, $resource, $arguments = []){
44
45			$user = User::find($this->getUserId());
46			$action = $this->getAction($request);
47
48			// The ability string must match the string defined in App\Providers\AuthServiceProvider\ability()
49			$ability = "{$action}-{$resource}";
50
51			// return $this->authorizeForUser($user, "{$action}-{$resource}", $data);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			return Gate::forUser($user)->allows($ability, $arguments);
53			}
54
55			/**
56			* Check if user is authorized.
57			*
58			* This method will be called by "Authorize" Middleware for every controller.
59			* Controller that needs to be authorized must override this method.
60			*
61			* @param \Illuminate\Http\Request $request
62			* @return bool
63			*/
64			public function isAuthorized(Request $request){
65			return false;
66			}
67
68			/**
69			* Get current authorized user id.
70			* This method should be called only after validating the access token using OAuthMiddleware Middleware.
71			*
72			* @return boolean
73			*/
74			protected function getUserId(){
75			return \LucaDegasperi\OAuth2Server\Facades\Authorizer::getResourceOwnerId();
76			}
77
78			/**
79			* Get the requested action method.
80			*
81			* @param \Illuminate\Http\Request $request
82			* @return string
83			*/
84			protected function getAction(Request $request){
85			return explode('@', $request->route()[1]["uses"], 2)[1];
86			}
87
88			/**
89			* Get the parameters in route.
90			*
91			* @param \Illuminate\Http\Request $request
92			* @return array
93			*/
94			protected function getArgs(Request $request){
95			return $request->route()[2];
96			}
97			}
98

OmarElGabry / lumen-api-oauth

Issues (30)

Security Analysis no request data

app/Http/Controllers/Controller.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like