OmarElGabry / lumen-api-oauth

app/Exceptions/Handler.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 use Laravel\Lumen\Exceptions\Handler as ExceptionHandler;
-
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException;
 

Spacing +3 added lines, -3 removed lines

@@ -48,15 +48,15 @@
      */
     public function render($request, Exception $e)
     {
-        if(env('APP_DEBUG')){
+        if (env('APP_DEBUG')) {
             return parent::render($request, $e);
         }
 
-        if($e instanceof NotFoundHttpException){
+        if ($e instanceof NotFoundHttpException) {
             return response()->json(['message' => 'Bad Request', 'code' => 400], 400);
         }
 
-        if($e instanceof MethodNotAllowedHttpException){
+        if ($e instanceof MethodNotAllowedHttpException) {
             return response()->json(['message' => 'Not Found', 'code' => 404], 404);
         }
 

app/Http/Controllers/PostCommentController.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use App\Post;
 use App\Comment;
-
 use Illuminate\Http\Request;
 
 class PostCommentController extends Controller{

Spacing +17 added lines, -17 removed lines

@@ -5,19 +5,19 @@ 
 
 use Illuminate\Http\Request;
 
-class PostCommentController extends Controller{
+class PostCommentController extends Controller {
 
-	public function __construct(){
+	public function __construct() {
 		
 		$this->middleware('oauth', ['except' => ['index', 'show']]);
 		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show', 'store']]);
 	}
 
-	public function index($post_id){
+	public function index($post_id) {
 
 		$post = Post::find($post_id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$post_id} doesn't exist", 404);
 		}
 
@@ -25,11 +25,11 @@ 
 		return $this->success($comments, 200);
 	}
 
-	public function store(Request $request, $post_id){
+	public function store(Request $request, $post_id) {
 		
 		$post = Post::find($post_id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$post_id} doesn't exist", 404);
 		}
 
@@ -44,12 +44,12 @@ 
 		return $this->success("The comment with id {$comment->id} has been created and assigned to the post with id {$post_id}", 201);
 	}
 
-	public function update(Request $request, $post_id, $comment_id){
+	public function update(Request $request, $post_id, $comment_id) {
 
-		$comment 	= Comment::find($comment_id);
-		$post 		= Post::find($post_id);
+		$comment = Comment::find($comment_id);
+		$post = Post::find($post_id);
 
-		if(!$comment || !$post){
+		if (!$comment || !$post) {
 			return $this->error("The comment with {$comment_id} or the post with id {$post_id} doesn't exist", 404);
 		}
 
@@ -64,16 +64,16 @@ 
 		return $this->success("The comment with with id {$comment->id} has been updated", 200);
 	}
 
-	public function destroy($post_id, $comment_id){
+	public function destroy($post_id, $comment_id) {
 		
-		$comment 	= Comment::find($comment_id);
-		$post 		= Post::find($post_id);
+		$comment = Comment::find($comment_id);
+		$post = Post::find($post_id);
 
-		if(!$comment || !$post){
+		if (!$comment || !$post) {
 			return $this->error("The comment with {$comment_id} or the post with id {$post_id} doesn't exist", 404);
 		}
 
-		if(!$post->comments()->find($comment_id)){
+		if (!$post->comments()->find($comment_id)) {
 			return $this->error("The comment with id {$comment_id} isn't assigned to the post with id {$post_id}", 409);
 		}
 
@@ -82,7 +82,7 @@ 
 		return $this->success("The comment with id {$comment_id} has been removed of the post {$post_id}", 200);
 	}
 
-	public function validateRequest(Request $request){
+	public function validateRequest(Request $request) {
 
 		$rules = [
 			'content' => 'required'
@@ -91,7 +91,7 @@ 
 		$this->validate($request, $rules);
 	}
 
-	public function isAuthorized(Request $request){
+	public function isAuthorized(Request $request) {
 
 		$resource  = "comments";
 		$comment   = Comment::find($this->getArgs($request)["comment_id"]);

app/Http/Controllers/PostController.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace App\Http\Controllers;
 
 use App\Post;
-
 use Illuminate\Http\Request;
 
 class PostController extends Controller{

Spacing +13 added lines, -13 removed lines

@@ -4,21 +4,21 @@ 
 
 use Illuminate\Http\Request;
 
-class PostController extends Controller{
+class PostController extends Controller {
 
-	public function __construct(){
+	public function __construct() {
 
 		$this->middleware('oauth', ['except' => ['index', 'show']]);
 		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show', 'store']]);
 	}
 
-	public function index(){
+	public function index() {
 
 		$posts = Post::all();
 		return $this->success($posts, 200);
 	}
 
-	public function store(Request $request){
+	public function store(Request $request) {
 
 		$this->validateRequest($request);
 
@@ -31,28 +31,28 @@ 
 		return $this->success("The post with with id {$post->id} has been created", 201);
 	}
 
-	public function show($id){
+	public function show($id) {
 
 		$post = Post::find($id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$id} doesn't exist", 404);
 		}
 
 		return $this->success($post, 200);
 	}
 
-	public function update(Request $request, $id){
+	public function update(Request $request, $id) {
 
 		$post = Post::find($id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$id} doesn't exist", 404);
 		}
 
 		$this->validateRequest($request);
 
-		$post->title 		= $request->get('title');
+		$post->title = $request->get('title');
 		$post->content 		= $request->get('content');
 		$post->user_id 		= $this->getUserId();
 
@@ -61,11 +61,11 @@ 
 		return $this->success("The post with with id {$post->id} has been updated", 200);
 	}
 
-	public function destroy($id){
+	public function destroy($id) {
 
 		$post = Post::find($id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$id} doesn't exist", 404);
 		}
 
@@ -77,7 +77,7 @@ 
 		return $this->success("The post with with id {$id} has been deleted along with it's comments", 200);
 	}
 
-	public function validateRequest(Request $request){
+	public function validateRequest(Request $request) {
 
 		$rules = [
 			'title' => 'required', 
@@ -87,7 +87,7 @@ 
 		$this->validate($request, $rules);
 	}
 
-	public function isAuthorized(Request $request){
+	public function isAuthorized(Request $request) {
 
 		$resource = "posts";
 		$post     = Post::find($this->getArgs($request)["post_id"]);

app/Http/Controllers/UserController.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace App\Http\Controllers;
 
 use App\User;
-
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Hash;
 

Spacing +14 added lines, -14 removed lines

@@ -5,21 +5,21 @@ 
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Hash;
 
-class UserController extends Controller{
+class UserController extends Controller {
 
-	public function __construct(){
+	public function __construct() {
 
 		$this->middleware('oauth', ['except' => ['index', 'show']]);
 		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show']]);
 	}
 
-	public function index(){
+	public function index() {
 
 		$users = User::all();
 		return $this->success($users, 200);
 	}
 
-	public function store(Request $request){
+	public function store(Request $request) {
 
 		$this->validateRequest($request);
 
@@ -31,40 +31,40 @@ 
 		return $this->success("The user with with id {$user->id} has been created", 201);
 	}
 
-	public function show($id){
+	public function show($id) {
 
 		$user = User::find($id);
 
-		if(!$user){
+		if (!$user) {
 			return $this->error("The user with {$id} doesn't exist", 404);
 		}
 
 		return $this->success($user, 200);
 	}
 
-	public function update(Request $request, $id){
+	public function update(Request $request, $id) {
 
 		$user = User::find($id);
 
-		if(!$user){
+		if (!$user) {
 			return $this->error("The user with {$id} doesn't exist", 404);
 		}
 
 		$this->validateRequest($request);
 
-		$user->email 		= $request->get('email');
-		$user->password 	= Hash::make($request->get('password'));
+		$user->email = $request->get('email');
+		$user->password = Hash::make($request->get('password'));
 
 		$user->save();
 
 		return $this->success("The user with with id {$user->id} has been updated", 200);
 	}
 
-	public function destroy($id){
+	public function destroy($id) {
 
 		$user = User::find($id);
 
-		if(!$user){
+		if (!$user) {
 			return $this->error("The user with {$id} doesn't exist", 404);
 		}
 
@@ -73,7 +73,7 @@ 
 		return $this->success("The user with with id {$id} has been deleted", 200);
 	}
 
-	public function validateRequest(Request $request){
+	public function validateRequest(Request $request) {
 
 		$rules = [
 			'email' => 'required|email|unique:users', 
@@ -83,7 +83,7 @@ 
 		$this->validate($request, $rules);
 	}
 
-	public function isAuthorized(Request $request){
+	public function isAuthorized(Request $request) {
 
 		$resource = "users";
 		// $user     = User::find($this->getArgs($request)["user_id"]);

app/Listeners/ExampleListener.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace App\Listeners;
 
 use App\Events\ExampleEvent;
-use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
 class ExampleListener
 {

app/User.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Contracts\Auth\Authenticatable as AuthenticatableContract;
 use Illuminate\Contracts\Auth\Access\Authorizable as AuthorizableContract;
-
 use Illuminate\Support\Facades\Hash;
 
 class User extends Model implements AuthenticatableContract, AuthorizableContract{

Spacing +2 added lines, -2 removed lines

@@ -40,11 +40,11 @@
      * @return int|boolean
      * @see    https://github.com/lucadegasperi/oauth2-server-laravel/blob/master/docs/authorization-server/password.md
      */
-    public function verify($email, $password){
+    public function verify($email, $password) {
 
         $user = User::where('email', $email)->first();
 
-        if($user && Hash::check($password, $user->password)){
+        if ($user && Hash::check($password, $user->password)) {
             return $user->id;
         }
 

app/Comment.php

Spacing +3 added lines, -3 removed lines

@@ -2,7 +2,7 @@ 
 
 use Illuminate\Database\Eloquent\Model;
 
-class Comment extends Model{
+class Comment extends Model {
 
     /**
      * The attributes that are mass assignable.
@@ -16,14 +16,14 @@ 
      *
      * @var array
      */
-	protected $hidden   = ['created_at', 'updated_at'];
+	protected $hidden = ['created_at', 'updated_at'];
 
     /**
      * Define an inverse one-to-many relationship with App\Post.
      *
      * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
      */
-	public function post(){
+	public function post() {
 		return $this->belongsTo('App\Post');
 	}
 

app/Post.php

Spacing +3 added lines, -3 removed lines

@@ -2,7 +2,7 @@ 
 
 use Illuminate\Database\Eloquent\Model;
 
-class Post extends Model{
+class Post extends Model {
 
     /**
      * The attributes that are mass assignable.
@@ -16,14 +16,14 @@ 
      *
      * @var array
      */
-	protected $hidden   = ['created_at', 'updated_at'];
+	protected $hidden = ['created_at', 'updated_at'];
 
     /**
      * Define a one-to-many relationship with App\Comment
      *
      * @return \Illuminate\Database\Eloquent\Relations\HasMany
      */
-	public function comments(){
+	public function comments() {
 		return $this->hasMany('App\Comment');
 	}
 

app/Providers/AuthServiceProvider.php

Spacing +6 added lines, -6 removed lines

@@ -56,7 +56,7 @@ 
      * @param  array  $arguments
      * @return boolean
      */
-    private function isOwner($arguments = []){
+    private function isOwner($arguments = []) {
 
         foreach ($arguments as $resource => $actions) {
             foreach ($actions as $action) {
@@ -67,9 +67,9 @@ 
                 //     }
                 // });
 
-                Gate::define($this->ability($action, $resource), function ($user, $arg) {
+                Gate::define($this->ability($action, $resource), function($user, $arg) {
                    
-                    if(is_null($arg))  { return false; }
+                    if (is_null($arg)) { return false; }
 
                     return $arg->user_id === $user->id || $user->is_admin;
                 });            
@@ -83,11 +83,11 @@ 
      * @param  array  $arguments
      * @return boolean
      */
-    private function isAdmin($arguments){
+    private function isAdmin($arguments) {
 
         foreach ($arguments as $resource => $actions) {
             foreach ($actions as $action) {
-                Gate::define($this->ability($action, $resource), function ($user) {
+                Gate::define($this->ability($action, $resource), function($user) {
                     return $user->is_admin;
                 });
             }
@@ -101,7 +101,7 @@ 
      * @param  string  $resource
      * @return string
      */
-    private function ability($action, $resource){
+    private function ability($action, $resource) {
         return "{$action}-{$resource}";
     }