App\Http\Controllers\PostController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	91
Duplicated Lines	27.47 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	5	1
A	store()	0	12	1
A	show()	10	10	2
A	update()	0	18	2
A	destroy()	15	15	2

<?php 

namespace App\Http\Controllers;

use App\Post;

use Illuminate\Http\Request;

class PostController extends Controller{

	public function __construct(){

		$this->middleware('oauth', ['except' => ['index', 'show']]);
		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show', 'store']]);
	}

	public function index(){

		$posts = Post::all();
		return $this->success($posts, 200);

It seems like $posts defined by \App\Post::all() on line 19 can also be of type object<Illuminate\Database\Eloquent\Collection>; however, App\Http\Controllers\Controller::success() does only seem to accept array, maybe add an additional type check?

	}

	public function store(Request $request){

		$this->validateRequest($request);

		$post = Post::create([

The method create() does not exist on App\Post. Did you maybe mean created()?

					'title' => $request->get('title'),
					'content'=> $request->get('content'),
					'user_id' => $this->getUserId()
				]);

		return $this->success("The post with with id {$post->id} has been created", 201);
	}

	public function show($id){

This method seems to be duplicated in your project.

		$post = Post::find($id);

		if(!$post){
			return $this->error("The post with {$id} doesn't exist", 404);
		}

		return $this->success($post, 200);
	}

	public function update(Request $request, $id){

		$post = Post::find($id);

		if(!$post){
			return $this->error("The post with {$id} doesn't exist", 404);
		}

		$this->validateRequest($request);

		$post->title 		= $request->get('title');
		$post->content 		= $request->get('content');
		$post->user_id 		= $this->getUserId();

		$post->save();

		return $this->success("The post with with id {$post->id} has been updated", 200);
	}

	public function destroy($id){

This method seems to be duplicated in your project.

		$post = Post::find($id);

		if(!$post){
			return $this->error("The post with {$id} doesn't exist", 404);
		}

		// no need to delete the comments for the current post,
		// since we used on delete cascase on update cascase.
		// $post->comments()->delete();

73% of this comment could be valid code. Did you maybe forget this after debugging?

		$post->delete();

		return $this->success("The post with with id {$id} has been deleted along with it's comments", 200);
	}

	public function validateRequest(Request $request){

		$rules = [
			'title' => 'required', 
			'content' => 'required'
		];

		$this->validate($request, $rules);
	}

	public function isAuthorized(Request $request){

		$resource = "posts";
		$post     = Post::find($this->getArgs($request)["post_id"]);

		return $this->authorizeUser($request, $resource, $post);

$resource is of type string, but the function expects a array.

	}
}