user.js ➔ findOrCreate - Code Metrics - Inspection of "Update socket.io-redis version" - OmarElGabry/chat.io - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7a9315...c29a35 )

by Omar El

created 2016-12-28 22:15 UTC

user.js ➔ findOrCreate A

↳ Parent: app/models/user.js

Complexity

Conditions	1
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	2
nop	2
dl	0
loc	16
rs	9.4285

1 Function

Rating	Name	Duplication	Size	Complexity
A	user.js ➔ ... ➔ findOne	0	14	3

'use strict';

var userModel = require('../database').models.user;

var create = function (data, callback){
	var newUser = new userModel(data);

	newUser.save(callback);
};

var findOne = function (data, callback){
	userModel.findOne(data, callback);
}

var findById = function (id, callback){
	userModel.findById(id, callback);
}


/**
 * Find a user, and create one if doesn't exist already.
 * This method is used ONLY to find user accounts registered via Social Authentication.
 *
 */
var findOrCreate = function(data, callback){
	findOne({'socialId': data.id}, function(err, user){
		if(err) { return callback(err); }
		if(user){
			return callback(err, user);
		}else{
			create({
				username: data.displayName,
				socialId: data.id,
				picture: data.photos[0].value || null
			}, function(err, newUser){
				callback(err, newUser);
			});

		}
	});
}

/**
 * A middleware allows user to get access to pages ONLY if the user is already logged in.
 *
 */
var isAuthenticated = function (req, res, next) {
	if(req.isAuthenticated()){
		next();
	}else{
		res.redirect('/');
	}
}

module.exports = { 
	create, 
	findOne, 
	findById, 
	findOrCreate, 
	isAuthenticated 
};

1			'use strict';
2
3			var userModel = require('../database').models.user;
4
5			var create = function (data, callback){
6			var newUser = new userModel(data);
			0 ignored issues – show Coding Style Best Practice introduced 2016-09-13 00:47 UTC by Report Bug Copy Issue Report By convention, constructors like `userModel` should be capitalized. Loading history...
7			newUser.save(callback);
8			};
9
10			var findOne = function (data, callback){
11			userModel.findOne(data, callback);
12			}
13
14			var findById = function (id, callback){
15			userModel.findById(id, callback);
16			}
17
18
19			/**
20			* Find a user, and create one if doesn't exist already.
21			* This method is used ONLY to find user accounts registered via Social Authentication.
22			*
23			*/
24			var findOrCreate = function(data, callback){
25			findOne({'socialId': data.id}, function(err, user){
26			if(err) { return callback(err); }
27			if(user){
28			return callback(err, user);
29			}else{
30			create({
31			username: data.displayName,
32			socialId: data.id,
33			picture: data.photos[0].value \|\| null
34			}, function(err, newUser){
35			callback(err, newUser);
36			});
			0 ignored issues – show Best Practice introduced 2016-09-13 00:47 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
37			}
38			});
39			}
40
41			/**
42			* A middleware allows user to get access to pages ONLY if the user is already logged in.
43			*
44			*/
45			var isAuthenticated = function (req, res, next) {
46			if(req.isAuthenticated()){
47			next();
48			}else{
49			res.redirect('/');
50			}
51			}
52
53			module.exports = {
54			create,
55			findOne,
56			findById,
57			findOrCreate,
58			isAuthenticated
59			};

OmarElGabry / chat.io

Push — master ( 7a9315...c29a35 )

user.js ➔ findOrCreate A

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like