Weather::fetchWeather() - Code Metrics - OllieJohnsson/weather - Measure and Improve Code Quality continuously with Scrutinizer

Weather::fetchWeather() A
last analyzed 2018-12-06 09:02 UTC

↳ Parent: Weather

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	2
dl	0
loc	10
ccs	7
cts	7
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php
namespace Oliver\Weather;

use Oliver\Weather\WeatherServiceInterface;
use Oliver\Weather\Exception\BadFormatException;

/**
 *
 */
class Weather
{
    private $service;

    public function __construct(WeatherServiceInterface $service)
    {
        $this->service = $service;
    }

    public function parseCoordinates($coordinateString) : array
    {
        $values = explode(",", $coordinateString);

        if (count($values) != 2) {
            throw new BadFormatException("Värdet var fel formaterat!");
        }

        $lat = $values[0];
        $long = $values[1];

        if (!floatval($lat)) {
            throw new BadFormatException("Latituden <b>$lat</b> har fel format.");
        }
        if (!floatval($long)) {
            throw new BadFormatException("Longituden <b>$long</b> har fel format.");
        }

        $coordinates = ["lat" => $lat, "long" => $long];
        return $coordinates;
    }

    public function fetchWeather(string $coordinateString, string $option) : array
    {
        $coordinates = $this->parseCoordinates($coordinateString);

        if ($option == "history") {
            $weatherJSON = $this->service->history($coordinates, 30);
            return $weatherJSON;
        } else {
            $weatherJSON = $this->service->forecast($coordinates);
            return $weatherJSON[0];
        }
    }
}


1		<?php
2		namespace Oliver\Weather;
3
4		use Oliver\Weather\WeatherServiceInterface;
5		use Oliver\Weather\Exception\BadFormatException;
6
7		/**
8		*
9		*/
10		class Weather
11		{
12		private $service;
13
14	11	public function __construct(WeatherServiceInterface $service)
15		{
16	11	$this->service = $service;
17	11	}
18
19	11	public function parseCoordinates($coordinateString) : array
20		{
21	11	$values = explode(",", $coordinateString);
22
23	11	if (count($values) != 2) {
24	4	throw new BadFormatException("Värdet var fel formaterat!");
25		}
26
27	7	$lat = $values[0];
28	7	$long = $values[1];
29
30	7	if (!floatval($lat)) {
31	1	throw new BadFormatException("Latituden <b>$lat</b> har fel format.");
32		}
33	6	if (!floatval($long)) {
34	1	throw new BadFormatException("Longituden <b>$long</b> har fel format.");
35		}
36
37	5	$coordinates = ["lat" => $lat, "long" => $long];
38	5	return $coordinates;
39		}
40
41	11	public function fetchWeather(string $coordinateString, string $option) : array
42		{
43	11	$coordinates = $this->parseCoordinates($coordinateString);
44
45	5	if ($option == "history") {
46	2	$weatherJSON = $this->service->history($coordinates, 30);
47	2	return $weatherJSON;
48		} else {
49	3	$weatherJSON = $this->service->forecast($coordinates);
50	3	return $weatherJSON[0];
51		}
52		}
53		}
54

OllieJohnsson / weather

Weather::fetchWeather() A last analyzed 2018-12-06 09:02 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Weather::fetchWeather() A
last analyzed 2018-12-06 09:02 UTC