Oliver\Curl\Curl

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	fetchData()	0	21	4

<?php
namespace Oliver\Curl;

use Oliver\Curl\CurlInterface;

/**
 *
 */
class Curl implements CurlInterface
{

    public function fetchData(array $urls) : array
    {
        $curlHandles = [];
        $multiHandle = curl_multi_init();

        for ($i=0; $i < count($urls); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $curlHandles[$i] = curl_init($urls[$i]);
            curl_setopt($curlHandles[$i], CURLOPT_RETURNTRANSFER, true);
            curl_multi_add_handle($multiHandle, $curlHandles[$i]);
        }

        $running = null;
        do {
            curl_multi_exec($multiHandle, $running);
        } while ($running);

        $results = [];
        for ($i=0; $i < count($curlHandles); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $results[] = (json_decode(curl_multi_getcontent($curlHandles[$i]), true));
        }
        return $results;
    }
}