MapAPI - Code Metrics - Inspection of "Merge branch 'duskohu-master'" - Olicek/GoogleMapAPI - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 875358...93eba8 )

by Petr

created 2016-01-18 16:57 UTC

MapAPI B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	366
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	13
Bugs	2	Features	6

Metric	Value
wmc	40
c	13
b	2
f	6
lcom	1
cbo	5
dl	0
loc	366
rs	8.2608

24 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	setup()	5	1
A	setCoordinates()	12	2
A	setProportions()	6	1
A	setKey()	5	1
A	setZoom()	15	4
B	setType()	10	5
A	setWaypoint()	12	2
A	setDirection()	9	2
A	getProportions()	4	1
A	getCoordinates()	4	1
A	getZoom()	4	1
A	getType()	4	1
A	getKey()	4	1
A	isStaticMap()	10	2
A	getIsStaticMap()	4	1
A	isClickable()	15	3
A	getIsClicable()	4	1
A	isScrollable()	10	2
A	getIsScrollable()	4	1
A	addMarkers()	8	1
A	invalidateMarkers()	4	1
B	render()	31	3
A	handleMarkers()	4	1

How to fix Complexity

<?php
/**
 * Copyright (c) 2015 Petr Olišar (http://olisar.eu)
 *
 * For the full copyright and license information, please view
 * the file LICENSE.md that was distributed with this source code.
 */

namespace Oli\GoogleAPI;

use Nette\Application\UI\Control;
use Nette\Application\Responses\JsonResponse;


/**
 * Description of GoogleAPI
 *
 * @author Petr Olišar <[email protected]>
 */
class MapAPI extends Control
{

	const ROADMAP = 'ROADMAP', SATELLITE = 'SATELLITE', HYBRID = 'HYBRID', TERRAIN = 'TERRAIN',
		BICYCLING = 'BICYCLING', DRIVING = 'DRIVING', TRANSIT = 'TRANSIT', WALKING = 'WALKING';
	
	/** @var double|string */
	private $width;

	/** @var double|string */
	private $height;

	/** @var array */
	private $coordinates;

	/** @var Integer */
	private $zoom;

	/** @var String */
	private $type;

	/** @var Boolean */
	private $staticMap = FALSE;

	/** @var Boolean */
	private $clickable = FALSE;

	/** @var String  */
	private $key;

	/** @var array */
	private $markers = array();

	/** @var boolean */
	private $bound;

	/** @var boolean */
	private $markerClusterer;

	/** @var array */
	private $clusterOptions;

	/** @var boolean */
	private $scrollable = FALSE;

	/**
	 *
	 * @var array
	 */
	private $waypoints;

	/**
	 *
	 * @var array
	 */
	private $direction = ['travelmode' => 'DRIVING'];


	public function __construct()
	{
		parent::__construct();
	}

	/**
	 * @internal
	 * @param array $config
	 */
	public function setup(array $config)
	{
		$this->width = $config['width'];
		$this->height = $config['height'];
	}

	
	/**
	 *
	 * @param array $coordinates (latitude, longitude) - center of the map
	 * @return \Oli\GoogleAPI\MapAPI
	 */
	public function setCoordinates(array $coordinates)
	{
		if(!count($coordinates))
		{
			$this->coordinates = array(NULL, NULL);
		} else
		{
			$this->coordinates = array_values($coordinates);
		}
		
		return $this;
	}
	
	
	/**
	 * @param double|string $width
	 * @param double|string $height
	 * @return MapAPI
	 */
	public function setProportions($width, $height)
	{
		$this->width = $width;
		$this->height = $height;
		return $this;
	}
	
	
	/**
	 *
	 * @param string $key
	 * @return \Oli\GoogleAPI\MapAPI
	 */
	public function setKey($key)
	{
		$this->key = $key;
		return $this;
	}
	
	
	/**
	 *
	 * @param int $zoom <0, 19>
	 * @return \Oli\GoogleAPI\MapAPI
	 * @throws \InvalidArgumentException
	 * @throws \LogicException
	 */
	public function setZoom($zoom)
	{
		if (!is_int($zoom))
		{
			throw new \InvalidArgumentException("type must be integer, $zoom (".gettype($zoom).") was given");
		}
		
		if ($zoom < 0 || $zoom > 19)
		{
			throw new \LogicException('Zoom must be betwen <0, 19>.');
		}
		
		$this->zoom = (int) $zoom;
		return $this;
	}
	
	
	/**
	 *
	 * @param String $type
	 * @return \Oli\GoogleAPI\MapAPI
	 */
	public function setType($type)
	{
		if($type !== self::HYBRID && $type !== self::ROADMAP && $type !== self::SATELLITE &&
				$type !== self::TERRAIN)
		{
			throw new \InvalidArgumentException;
		}
		$this->type = $type;
		return $this;
	}
	
	
	public function setWaypoint($key, $waypoint)
	{
		if($key === 'waypoints')
		{
			$this->waypoints['waypoints'][] = $waypoint;
			
		} else
		{
			$this->waypoints[$key] = $waypoint;
		}
		return $this;
	}
	
	
	public function setDirection(array $direction)
	{
		$this->direction = $direction;
		if(!array_key_exists('travelmode', $this->direction))
		{
			$this->direction['travelmode'] = 'DRIVING';
		}
		return $this;
	}
	
	
	/**
	 * @return array Width and Height of the map.
	 */
	public function getProportions()
	{
		return array('width' => $this->width, 'height' => $this->height);
	}
	
	
	/**
	 * @return array Center of the map
	 */
	public function getCoordinates()
	{
		return $this->coordinates;
	}
	
	
	/**
	 * @return integer Zoom
	 */
	public function getZoom()
	{
		return $this->zoom;
	}
	
	
	/**
	 * @return String Which map type will be show
	 */
	public function getType()
	{
		return $this->type;
	}


	public function getKey()
	{
		return $this->key;
	}
	
	
	/**
	 *
	 * @param Boolean $staticMap
	 * @return \Oli\GoogleAPI\MapAPI
	 * @throws \InvalidArgumentException
	 */
	public function isStaticMap($staticMap = TRUE)
	{
		if (!is_bool($staticMap))
		{
			throw new \InvalidArgumentException("staticMap must be boolean, $staticMap (".gettype($staticMap).") was given");
		}
		
		$this->staticMap = $staticMap;
		return $this;
	}


	public function getIsStaticMap()
	{
		return $this->staticMap;
	}


	/**
	 *
	 * @param Boolean $clickable
	 * @return \Oli\GoogleAPI\MapAPI
	 * @throws \InvalidArgumentException
	 */
	public function isClickable($clickable = TRUE)
	{
		if (!$this->staticMap)
		{
			throw new \InvalidArgumentException("the 'clickable' option only applies to static maps");
		}

		if (!is_bool($clickable))
		{
			throw new \InvalidArgumentException("clickable must be boolean, $clickable (".gettype($clickable).") was given");
		}

		$this->clickable = $clickable;
		return $this;
	}


	public function getIsClicable()
	{
		return $this->clickable;
	}

	
	public function isScrollable($scrollable = TRUE)
	{
		if (!is_bool($scrollable))
		{
			throw new \InvalidArgumentException("staticMap must be boolean, $scrollable (".gettype($scrollable).") was given");
		}
		
		$this->scrollable = $scrollable;
		return $this;
	}


	public function getIsScrollable()
	{
		return $this->scrollable;
	}


	/**
	 *
	 * @param \Oli\GoogleAPI\Markers $markers
	 * @return \Oli\GoogleAPI\MapAPI
	 */
	public function addMarkers(Markers $markers)
	{
		$this->markers = $markers->getMarkers();
		$this->bound = $markers->getBound();
		$this->markerClusterer = $markers->getMarkerClusterer();
		$this->clusterOptions = $markers->getClusterOptions();
		return $this;
	}
	
	
	/**
	 * Alias to handleMarkers()
	 */
	public function invalidateMarkers()
	{
		$this->handleMarkers();
	}
	
	
	/**
	* @see Nette\Application\Control#render()
	*/
	public function render()
	{
		if ($this->staticMap)
		{
			$this->template->height = $this->height;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->template->width = $this->width;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->template->zoom = $this->zoom;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->template->position = $this->coordinates;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->template->markers = $this->markers;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->template->clickable = $this->clickable;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->template->setFile(dirname(__FILE__) . '/static.latte');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		} else
		{
			$map = array(
			    'position' => $this->coordinates,
			    'height' => $this->height,
			    'width' => $this->width,
			    'zoom' => $this->zoom,
			    'type' => $this->type,
			    'scrollable' => $this->scrollable,
			    'key' => $this->key,
			    'bound' => $this->bound,
			    'cluster' => $this->markerClusterer,
			    'clusterOptions' => $this->clusterOptions,
			    'waypoint' => !is_null($this->waypoints) ? array_merge($this->waypoints, $this->direction) : NULL
			);
			$this->template->map = \Nette\Utils\Json::encode($map);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->template->setFile(dirname(__FILE__) . '/template.latte');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		}
		$this->template->render();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}
	
	
	/**
	 * Send markers to template as JSON
	 * @internal
	 */
	public function handleMarkers()
	{
		$this->getPresenter()->sendResponse(new JsonResponse($this->markers));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}
}


GitHub Access Token became invalid

Push — master ( 875358...93eba8 )

MapAPI B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Complexity

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Copyright (c) 2015 Petr Olišar (http://olisar.eu)
4			*
5			* For the full copyright and license information, please view
6			* the file LICENSE.md that was distributed with this source code.
7			*/
8
9			namespace Oli\GoogleAPI;
10
11			use Nette\Application\UI\Control;
12			use Nette\Application\Responses\JsonResponse;
13
14
15			/**
16			* Description of GoogleAPI
17			*
18			* @author Petr Olišar <[email protected]>
19			*/
20			class MapAPI extends Control
21			{
22
23			const ROADMAP = 'ROADMAP', SATELLITE = 'SATELLITE', HYBRID = 'HYBRID', TERRAIN = 'TERRAIN',
24			BICYCLING = 'BICYCLING', DRIVING = 'DRIVING', TRANSIT = 'TRANSIT', WALKING = 'WALKING';
25
26			/** @var double\|string */
27			private $width;
28
29			/** @var double\|string */
30			private $height;
31
32			/** @var array */
33			private $coordinates;
34
35			/** @var Integer */
36			private $zoom;
37
38			/** @var String */
39			private $type;
40

Olicek / GoogleMapAPI

GitHub Access Token became invalid

Push — master ( 875358...93eba8 )

MapAPI B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Complexity

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like