MapAPI - Code Metrics - Inspection of "http change to https" - Olicek/GoogleMapAPI - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 65884f...516ada )

by Petr

created 2017-05-04 10:59 UTC

MapAPI B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	461
Duplicated Lines	5.64 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

65.89%

Importance

Changes

Metric	Value
wmc	49
c	0
b	0
f	0
lcom	1
cbo	8
dl	26
loc	461
ccs	85
cts	129
cp	0.6589
rs	8.5454

26 Methods

Rating	Name	Duplication	Size	Complexity
A	addMarkers()	0	8	1
A	invalidateMarkers()	0	4	1
B	render()	0	41	5
A	handleMarkers()	0	4	1
A	__construct()	0	4	1
A	setup()	0	5	1
A	setCoordinates()	0	12	2
A	setProportions()	0	6	1
A	setKey()	0	5	1
A	setZoom()	0	15	4
B	setType()	0	10	5
A	setWaypoint()	0	17	3
A	setDirection()	0	14	3
A	getProportions()	0	4	1
A	getCoordinates()	0	4	1
A	getZoom()	0	4	1
A	getType()	0	4	1
A	getWaypoints()	0	4	1
A	getDirection()	0	4	1
A	getKey()	0	4	1
A	isStaticMap()	10	10	2
A	getIsStaticMap()	0	4	1
B	isClickable()	6	25	6
A	getIsClicable()	0	4	1
A	isScrollable()	10	10	2
A	getIsScrollable()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like MapAPI often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use MapAPI, and based on these observations, apply Extract Interface, too.

<?php
/**
 * Copyright (c) 2015 Petr Olišar (http://olisar.eu)
 *
 * For the full copyright and license information, please view
 * the file LICENSE.md that was distributed with this source code.
 */

namespace Oli\GoogleAPI;

use Nette\Application\UI\Control;
use Nette\Application\Responses\JsonResponse;
use Nette\Application\UI\ITemplate;
use Nette\Utils\Html;
use Nette\Utils\Json;


/**
 * Description of GoogleAPI
 *
 * @author Petr Olišar <[email protected]>
 * @property-read ITemplate $template
 */
class MapAPI extends Control
{

	const ROADMAP = 'ROADMAP', SATELLITE = 'SATELLITE', HYBRID = 'HYBRID', TERRAIN = 'TERRAIN',
		BICYCLING = 'BICYCLING', DRIVING = 'DRIVING', TRANSIT = 'TRANSIT', WALKING = 'WALKING';

	/**
	 * @var double|string
	 */
	private $width;

	/**
	 * @var double|string
	 */
	private $height;

	/**
	 * @var array
	 */
	private $coordinates;

	/**
	 * @var int
	 */
	private $zoom;

	/**
	 * @var string
	 */
	private $type;

	/**
	 * @var bool
	 */
	private $staticMap = FALSE;

	/**
	 * @var bool|string|callable
	 */
	private $clickable = FALSE;

	/**
	 * @var string
	 */
	private $key;

	/**
	 * @var array
	 */
	private $markers = array();

	/**
	 * @var bool
	 */
	private $bound;

	/**
	 * @var bool
	 */
	private $markerClusterer;

	/**
	 * @var array
	 */
	private $clusterOptions;

	/**
	 * @var bool
	 */
	private $scrollable = FALSE;

	/**
	 * @var array
	 */
	private $waypoints;

	/**
	 * @var array
	 */
	private $direction = ['travelmode' => 'DRIVING'];


	public function __construct()
	{

	}


	/**
	 * @param array $config
	 * @internal
	 */
	public function setup(array $config)
	{
		$this->width = $config['width'];
		$this->height = $config['height'];
	}


	/**
	 * @param array $coordinates	(latitude, longitude) - center of the map
	 * @return $this
	 */
	public function setCoordinates(array $coordinates)
	{
		if(!count($coordinates))
		{
			$this->coordinates = array(NULL, NULL);
		} else
		{
			$this->coordinates = array_values($coordinates);
		}
		
		return $this;
	}


	/**
	 * @param double|string $width
	 * @param double|string $height
	 * @return $this
	 */
	public function setProportions($width, $height)
	{
		$this->width = $width;
		$this->height = $height;
		return $this;
	}


	/**
	 * @param string $key
	 * @return $this
	 */
	public function setKey($key)
	{
		$this->key = $key;
		return $this;
	}


	/**
	 * @param int $zoom		<0, 19>
	 * @return $this
	 * @throws InvalidArgumentException
	 * @throws LogicException
	 */
	public function setZoom($zoom)
	{
		if (!is_int($zoom))
		{
			throw new InvalidArgumentException("type must be integer, $zoom (".gettype($zoom).") was given");
		}

		if ($zoom < 0 || $zoom > 19)
		{
			throw new LogicException('Zoom must be betwen <0, 19>.');
		}

		$this->zoom = (int) $zoom;
		return $this;
	}


	/**
	 * @param string $type
	 * @return $this
	 * @throws InvalidArgumentException
	 */
	public function setType($type)
	{
		if($type !== self::HYBRID && $type !== self::ROADMAP && $type !== self::SATELLITE &&
				$type !== self::TERRAIN)
		{
			throw new InvalidArgumentException;
		}
		$this->type = $type;
		return $this;
	}


	/**
	 * @param string $key
	 * @param array $waypoint
	 * @return $this
	 * @throws InvalidArgumentException
	 */
	public function setWaypoint($key, array $waypoint)
	{
		if (!in_array($key, ['start', 'end', 'waypoint']))
		{
			throw new InvalidArgumentException('First argument must be "start|end|waypoint", ' . $key . ' was given');
		}

		if($key === 'waypoint')
		{
			$this->waypoints['waypoints'][] = $waypoint;

		} else
		{
			$this->waypoints[$key] = $waypoint;
		}
		return $this;
	}


	/**
	 * @param array $direction
	 * @return $this
	 * @throws InvalidArgumentException
	 */
	public function setDirection(array $direction)
	{
		$this->direction = $direction;
		if(!array_key_exists('travelmode', $this->direction))
		{
			$this->direction['travelmode'] = 'DRIVING';
		} else if (!in_array($direction['travelmode'], [
			self::BICYCLING, self::DRIVING, self::WALKING, self::TRANSIT
		]))
		{
			throw new InvalidArgumentException;
		}
		return $this;
	}


	/**
	 * @return array	Width and Height of the map.
	 */
	public function getProportions()
	{
		return array('width' => $this->width, 'height' => $this->height);
	}


	/**
	 * @return array	Center of the map
	 */
	public function getCoordinates()
	{
		return $this->coordinates;
	}


	/**
	 * @return int
	 */
	public function getZoom()
	{
		return $this->zoom;
	}


	/**
	 * @return string	Which map type will be show
	 */
	public function getType()
	{
		return $this->type;
	}


	/**
	 * @return array
	 */
	public function getWaypoints()
	{
		return $this->waypoints;
	}


	/**
	 * @return array
	 */
	public function getDirection()
	{
	    return $this->direction;
	}


	/**
	 * @return string
	 */
	public function getKey()
	{
		return $this->key;
	}


	/**
	 * @param bool $staticMap
	 * @return $this
	 * @throws InvalidArgumentException
	 */
	public function isStaticMap($staticMap = TRUE)

	{
		if (!is_bool($staticMap))
		{
			throw new InvalidArgumentException("staticMap must be boolean, $staticMap (".gettype($staticMap).") was given");
		}

		$this->staticMap = $staticMap;
		return $this;
	}


	/**
	 * @return bool
	 */
	public function getIsStaticMap()
	{
		return $this->staticMap;
	}


	/**
	 * @param bool|callable $clickable
	 * @return $this
	 * @throws InvalidArgumentException
	 */
	public function isClickable($clickable = TRUE)
	{
		if (!$this->staticMap)
		{
			throw new InvalidArgumentException("the 'clickable' option only applies to static map");
		}

		if (!is_bool($clickable) && !is_callable($clickable))

		{
			throw new InvalidArgumentException(
				"clickable must be boolean or callable, $clickable (".gettype($clickable).") was given"
			);
		}

		if (is_callable($clickable)) {
			$this->clickable = $clickable;

		} else if ($clickable !== FALSE)
		{
			$this->clickable = '<a href="https://maps.google.com/maps/place/' .
				$this->coordinates[0] . ',' . $this->coordinates[1] . '/">';
		}

		return $this;
	}


	/**
	 * @return bool
	 */
	public function getIsClicable()
	{
		return $this->clickable;
	}


	/**
	 * @param bool $scrollable
	 * @return $this
	 * @throws InvalidArgumentException
	 */
	public function isScrollable($scrollable = TRUE)

	{
		if (!is_bool($scrollable))
		{
			throw new InvalidArgumentException("staticMap must be boolean, $scrollable (".gettype($scrollable).") was given");
		}
		
		$this->scrollable = $scrollable;
		return $this;
	}


	/**
	 * @return bool
	 */
	public function getIsScrollable()
	{
		return $this->scrollable;
	}


	/**
	 * @param Markers $markers
	 * @return $this
	 */
	public function addMarkers(Markers $markers)
	{
		$this->markers = $markers->getMarkers();
		$this->bound = $markers->getBound();
		$this->markerClusterer = $markers->getMarkerClusterer();
		$this->clusterOptions = $markers->getClusterOptions();
		return $this;
	}


	/**
	 * Alias to handleMarkers()
	 */
	public function invalidateMarkers()
	{
		$this->handleMarkers();
	}


	/**
	 * @throws \Nette\Utils\JsonException
	 */
	public function render()
	{
		if ($this->staticMap)
		{
			if (is_callable($this->clickable))
			{
				$this->clickable = call_user_func_array($this->clickable, [
					'https://maps.google.com/maps/place/' . $this->coordinates[0] . ',' .
					$this->coordinates[1] . '/',
					$this->getCoordinates()
				]);
			}

			$this->template->height = $this->height;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			$this->template->width = $this->width;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			$this->template->zoom = $this->zoom;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			$this->template->position = $this->coordinates;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			$this->template->markers = $this->markers;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			$this->template->clickable = $this->clickable instanceof Html ? $this->clickable->startTag() :
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
				$this->clickable;
			$this->template->setFile(dirname(__FILE__) . '/static.latte');
		} else
		{
			$map = array(
			    'position' => $this->coordinates,
			    'height' => $this->height,
			    'width' => $this->width,
			    'zoom' => $this->zoom,
			    'type' => $this->type,
			    'scrollable' => $this->scrollable,
			    'key' => $this->key,
			    'bound' => $this->bound,
			    'cluster' => $this->markerClusterer,
			    'clusterOptions' => $this->clusterOptions,
			    'waypoint' => !is_null($this->waypoints) ? array_merge($this->waypoints, $this->direction) : NULL
			);
			$this->template->map = Json::encode($map);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			$this->template->setFile(dirname(__FILE__) . '/template.latte');
		}
		$this->template->render();
	}


	/**
	 * Send markers to template as JSON
	 * @internal
	 */
	public function handleMarkers()
	{
		$this->getPresenter()->sendResponse(new JsonResponse($this->markers));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}
}


GitHub Access Token became invalid

Push — master ( 65884f...516ada )

MapAPI B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

26 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Copyright (c) 2015 Petr Olišar (http://olisar.eu)
4			*
5			* For the full copyright and license information, please view
6			* the file LICENSE.md that was distributed with this source code.
7			*/
8
9			namespace Oli\GoogleAPI;
10
11			use Nette\Application\UI\Control;
12			use Nette\Application\Responses\JsonResponse;
13			use Nette\Application\UI\ITemplate;
14			use Nette\Utils\Html;
15			use Nette\Utils\Json;
16
17
18			/**
19			* Description of GoogleAPI
20			*
21			* @author Petr Olišar <[email protected]>
22			* @property-read ITemplate $template
23			*/
24			class MapAPI extends Control
25	1		{
26
27			const ROADMAP = 'ROADMAP', SATELLITE = 'SATELLITE', HYBRID = 'HYBRID', TERRAIN = 'TERRAIN',
28			BICYCLING = 'BICYCLING', DRIVING = 'DRIVING', TRANSIT = 'TRANSIT', WALKING = 'WALKING';
29
30			/**
31			* @var double\|string
32			*/
33			private $width;
34
35			/**
36			* @var double\|string
37			*/
38			private $height;
39
40			/**
41			* @var array
42			*/
43			private $coordinates;
44
45			/**
46			* @var int
47			*/
48			private $zoom;
49
50			/**
51			* @var string
52			*/
53			private $type;
54
55			/**
56			* @var bool
57			*/
58			private $staticMap = FALSE;
59
60			/**
61			* @var bool\|string\|callable
62			*/
63			private $clickable = FALSE;
64
65			/**
66			* @var string
67			*/
68			private $key;
69
70			/**
71			* @var array
72			*/
73			private $markers = array();
74
75			/**
76			* @var bool
77			*/
78			private $bound;
79
80			/**
81			* @var bool
82			*/
83			private $markerClusterer;
84
85			/**
86			* @var array
87			*/
88			private $clusterOptions;
89
90			/**
91			* @var bool
92			*/
93			private $scrollable = FALSE;
94
95			/**
96			* @var array
97			*/
98			private $waypoints;
99
100			/**
101			* @var array
102			*/
103			private $direction = ['travelmode' => 'DRIVING'];
104
105
106			public function __construct()
107			{
108
109	1		}
110
111
112			/**
113			* @param array $config
114			* @internal
115			*/
116			public function setup(array $config)
117			{
118	1		$this->width = $config['width'];
119	1		$this->height = $config['height'];
120	1		}
121
122
123			/**
124			* @param array $coordinates (latitude, longitude) - center of the map
125			* @return $this
126			*/
127			public function setCoordinates(array $coordinates)
128			{
129	1		if(!count($coordinates))
130	1		{
131	1		$this->coordinates = array(NULL, NULL);
132	1		} else
133			{
134	1		$this->coordinates = array_values($coordinates);
135			}
136
137	1		return $this;
138			}
139
140
141			/**
142			* @param double\|string $width
143			* @param double\|string $height
144			* @return $this
145			*/
146			public function setProportions($width, $height)
147			{
148	1		$this->width = $width;
149	1		$this->height = $height;
150	1		return $this;
151			}
152
153
154			/**
155			* @param string $key
156			* @return $this
157			*/
158			public function setKey($key)
159			{
160	1		$this->key = $key;
161	1		return $this;
162			}
163
164
165			/**
166			* @param int $zoom <0, 19>
167			* @return $this
168			* @throws InvalidArgumentException
169			* @throws LogicException
170			*/
171			public function setZoom($zoom)
172			{
173	1		if (!is_int($zoom))
174	1		{
175	1		throw new InvalidArgumentException("type must be integer, $zoom (".gettype($zoom).") was given");
176			}
177
178	1		if ($zoom < 0 \|\| $zoom > 19)
179	1		{
180	1		throw new LogicException('Zoom must be betwen <0, 19>.');
181			}
182
183	1		$this->zoom = (int) $zoom;
184	1		return $this;
185			}
186
187
188			/**
189			* @param string $type
190			* @return $this
191			* @throws InvalidArgumentException
192			*/
193			public function setType($type)
194			{
195	1		if($type !== self::HYBRID && $type !== self::ROADMAP && $type !== self::SATELLITE &&
196	1		$type !== self::TERRAIN)
197	1		{
198	1		throw new InvalidArgumentException;
199			}
200	1		$this->type = $type;
201	1		return $this;
202			}
203
204
205			/**
206			* @param string $key
207			* @param array $waypoint
208			* @return $this
209			* @throws InvalidArgumentException
210			*/
211			public function setWaypoint($key, array $waypoint)
212			{
213	1		if (!in_array($key, ['start', 'end', 'waypoint']))
214	1		{
215	1		throw new InvalidArgumentException('First argument must be "start\|end\|waypoint", ' . $key . ' was given');
216			}
217
218	1		if($key === 'waypoint')
219	1		{
220	1		$this->waypoints['waypoints'][] = $waypoint;
221
222	1		} else
223			{
224	1		$this->waypoints[$key] = $waypoint;
225			}
226	1		return $this;
227			}
228
229
230			/**
231			* @param array $direction
232			* @return $this
233			* @throws InvalidArgumentException
234			*/
235			public function setDirection(array $direction)
236			{
237	1		$this->direction = $direction;
238	1		if(!array_key_exists('travelmode', $this->direction))
239	1		{
240	1		$this->direction['travelmode'] = 'DRIVING';
241	1		} else if (!in_array($direction['travelmode'], [
242	1		self::BICYCLING, self::DRIVING, self::WALKING, self::TRANSIT
243	1		]))
244	1		{
245	1		throw new InvalidArgumentException;
246			}
247	1		return $this;
248			}
249
250
251			/**
252			* @return array Width and Height of the map.
253			*/
254			public function getProportions()
255			{
256	1		return array('width' => $this->width, 'height' => $this->height);
257			}
258
259
260			/**
261			* @return array Center of the map
262			*/
263			public function getCoordinates()
264			{
265	1		return $this->coordinates;
266			}
267
268
269			/**
270			* @return int
271			*/
272			public function getZoom()
273			{
274	1		return $this->zoom;
275			}
276
277
278			/**
279			* @return string Which map type will be show
280			*/
281			public function getType()
282			{
283	1		return $this->type;
284			}
285
286
287			/**
288			* @return array
289			*/
290			public function getWaypoints()
291			{
292	1		return $this->waypoints;
293			}
294
295
296			/**
297			* @return array
298			*/
299			public function getDirection()
300			{
301	1		return $this->direction;
302			}
303
304
305			/**
306			* @return string
307			*/
308			public function getKey()
309			{
310	1		return $this->key;
311			}
312
313
314			/**
315			* @param bool $staticMap
316			* @return $this
317			* @throws InvalidArgumentException
318			*/
319		View Code Duplication	public function isStaticMap($staticMap = TRUE)
			0 ignored issues – show Duplication introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
320			{
321	1		if (!is_bool($staticMap))
322	1		{
323	1		throw new InvalidArgumentException("staticMap must be boolean, $staticMap (".gettype($staticMap).") was given");
324			}
325
326	1		$this->staticMap = $staticMap;
327	1		return $this;
328			}
329
330
331			/**
332			* @return bool
333			*/
334			public function getIsStaticMap()
335			{
336	1		return $this->staticMap;
337			}
338
339
340			/**
341			* @param bool\|callable $clickable
342			* @return $this
343			* @throws InvalidArgumentException
344			*/
345			public function isClickable($clickable = TRUE)
346			{
347	1		if (!$this->staticMap)
348	1		{
349	1		throw new InvalidArgumentException("the 'clickable' option only applies to static map");
350			}
351
352	1	View Code Duplication	if (!is_bool($clickable) && !is_callable($clickable))
			0 ignored issues – show Duplication introduced 2016-02-05 20:31 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
353	1		{
354	1		throw new InvalidArgumentException(
355	1		"clickable must be boolean or callable, $clickable (".gettype($clickable).") was given"
356	1		);
357			}
358
359	1		if (is_callable($clickable)) {
360	1		$this->clickable = $clickable;
361
362	1		} else if ($clickable !== FALSE)
363	1		{
364	1		$this->clickable = '<a href="https://maps.google.com/maps/place/' .
365	1		$this->coordinates[0] . ',' . $this->coordinates[1] . '/">';
366	1		}
367
368	1		return $this;
369			}
370
371
372			/**
373			* @return bool
374			*/
375			public function getIsClicable()
376			{
377	1		return $this->clickable;
378			}
379
380
381			/**
382			* @param bool $scrollable
383			* @return $this
384			* @throws InvalidArgumentException
385			*/
386		View Code Duplication	public function isScrollable($scrollable = TRUE)
			0 ignored issues – show Duplication introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
387			{
388	1		if (!is_bool($scrollable))
389	1		{
390	1		throw new InvalidArgumentException("staticMap must be boolean, $scrollable (".gettype($scrollable).") was given");
391			}
392
393	1		$this->scrollable = $scrollable;
394	1		return $this;
395			}
396
397
398			/**
399			* @return bool
400			*/
401			public function getIsScrollable()
402			{
403	1		return $this->scrollable;
404			}
405
406
407			/**
408			* @param Markers $markers
409			* @return $this
410			*/
411			public function addMarkers(Markers $markers)
412			{
413			$this->markers = $markers->getMarkers();
414			$this->bound = $markers->getBound();
415			$this->markerClusterer = $markers->getMarkerClusterer();
416			$this->clusterOptions = $markers->getClusterOptions();
417			return $this;
418			}
419
420
421			/**
422			* Alias to handleMarkers()
423			*/
424			public function invalidateMarkers()
425			{
426			$this->handleMarkers();
427			}
428
429
430			/**
431			* @throws \Nette\Utils\JsonException
432			*/
433			public function render()
434			{
435			if ($this->staticMap)
436			{
437			if (is_callable($this->clickable))
438			{
439			$this->clickable = call_user_func_array($this->clickable, [
440			'https://maps.google.com/maps/place/' . $this->coordinates[0] . ',' .
441			$this->coordinates[1] . '/',
442			$this->getCoordinates()
443			]);
444			}
445
446			$this->template->height = $this->height;
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report Accessing `height` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
447			$this->template->width = $this->width;
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report Accessing `width` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
448			$this->template->zoom = $this->zoom;
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report Accessing `zoom` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
449			$this->template->position = $this->coordinates;
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report Accessing `position` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
450			$this->template->markers = $this->markers;
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report Accessing `markers` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
451			$this->template->clickable = $this->clickable instanceof Html ? $this->clickable->startTag() :
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report Accessing `clickable` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
452			$this->clickable;
453			$this->template->setFile(dirname(__FILE__) . '/static.latte');
454			} else
455			{
456			$map = array(
457			'position' => $this->coordinates,
458			'height' => $this->height,
459			'width' => $this->width,
460			'zoom' => $this->zoom,
461			'type' => $this->type,
462			'scrollable' => $this->scrollable,
463			'key' => $this->key,
464			'bound' => $this->bound,
465			'cluster' => $this->markerClusterer,
466			'clusterOptions' => $this->clusterOptions,
467			'waypoint' => !is_null($this->waypoints) ? array_merge($this->waypoints, $this->direction) : NULL
468			);
469			$this->template->map = Json::encode($map);
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report Accessing `map` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
470			$this->template->setFile(dirname(__FILE__) . '/template.latte');
471			}
472			$this->template->render();
473			}
474
475
476			/**
477			* Send markers to template as JSON
478			* @internal
479			*/
480			public function handleMarkers()
481			{
482			$this->getPresenter()->sendResponse(new JsonResponse($this->markers));
			0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Nette\ComponentModel\IComponent` as the method `sendResponse()` does only exist in the following implementations of said interface: `Nette\Application\UI\Presenter`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
483			}
484			}
485

Olicek / GoogleMapAPI

GitHub Access Token became invalid

Push — master ( 65884f...516ada )

MapAPI B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

26 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like