VatNumberCheck\Test\TestCase\Controller\VatNumberChecksControllerTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	3	1
A	testCheck()	0	8	1

<?php
namespace VatNumberCheck\Test\TestCase\Controller;

use Cake\TestSuite\IntegrationTestTrait;
use Cake\TestSuite\TestCase;
use VatNumberCheck\Controller\VatNumberChecksController;
use VatNumberCheck\Utility\VatNumberCheck;
use VatNumberCheck\Test\TestApp;
/**
 * VatNumberChecksController Test Case.
 *
 * @property \VatNumberCheck\Controller\VatNumberChecksController $VatNumberChecks
 */
class VatNumberChecksControllerTest extends TestCase
{
	use IntegrationTestTrait;

The trait Cake\TestSuite\IntegrationTestTrait requires the property $viewVars which is not provided by VatNumberCheck\Test\TestCase\Controller\VatNumberChecksControllerTest.

/**
 * Fixtures
 *
 * @var array
 */
	public $fixtures = [];

/**
 * setUp method
 *
 * @return void
 */
	public function setUp() {
		$this->useHttpServer(true);
		$VatNumberChecks = new VatNumberCheck();

The assignment to $VatNumberChecks is dead and can be removed.

	}
/**
 * Tests `/vat_number_check/vat_number_checks/check.json`.
 *
 * @return void
 */
	public function testCheck() {
		$url = '/vat_number_check/vat_number_checks/check.json';
		// Post request, correct vat
		$data = ['vatNumber' => 'NL820345672B01'];

		$this->get('url');
		$actual = $this->post($url, $data);

The assignment to $actual is dead and can be removed.

Are you sure the assignment to $actual is correct as $this->post($url, $data) targeting VatNumberCheck\Test\TestCase\Controller\VatNumberChecksControllerTest::post() seems to always return null.

		$expected = array_merge($data, ['status' => 'ok']);

The assignment to $expected is dead and can be removed.

		// // Test response body
		// $this->assertSame($expected, json_decode($actual, true));
		// $actual = $VatNumberChecks->response->statusCode();
		// $expected = 200;
		// // Test response code
		// $this->assertSame($expected, $actual);
		// // Get request
		// $VatNumberChecks = $this->_getMock();
		// $data = ['vatNumber' => ''];
		// $actual = $this->get($url, ['return' => 'contents']);
		// $expected = array_merge($data, ['status' => 'failure']);
		// $this->assertSame($expected, json_decode($actual, true));
		// // Post request, incorrect vat
		// $VatNumberChecks = $this->_getMock();
		// $data = ['vatNumber' => 'NL820345672B02'];
		// $actual = $this->get($url, ['return' => 'contents', 'data' => $data, 'method' => 'post']);
		// $expected = array_merge($data, ['status' => 'failure']);
		// $this->assertSame($expected, json_decode($actual, true));
		// // Post request, correct vat, timeout
		// $VatNumberChecks = $this->generate('VatNumberCheck.VatNumberChecks', [
		// 	'models' => [
		// 		'VatNumberCheck.VatNumberCheck' => ['check']
		// 	]
		// ]);
		// $VatNumberChecks->VatNumberCheck->setDataSource('vatNumberCheckWebservice');
		// $VatNumberChecks->VatNumberCheck->expects($this->any())
		// 	->method('check')->will($this->throwException(new Exception()));
		// $data = ['vatNumber' => 'NL820345672B01'];
		// $actual = $this->get($url, ['return' => 'contents', 'data' => $data, 'method' => 'post']);
		// $expected = array_merge($data, ['status' => 'failure']);
		// // Test response body
		// $this->assertSame($expected, json_decode($actual, true));
		// $actual = $VatNumberChecks->response->statusCode();
		// $expected = 503;
		// // Test response code
		// $this->assertSame($expected, $actual);
	}
}