UniLoginController::_dispatch() - Code Metrics - Oefenweb/cakephp-uni-login - Measure and Improve Code Quality continuously with Scrutinizer

UniLoginController::_dispatch() A
last analyzed 2019-01-23 12:30 UTC

↳ Parent: UniLoginController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
c	0
b	0
f	0
nc	1
nop	2
dl	0
loc	8
rs	10

<?php
App::uses('UniLoginUtil', 'UniLogin.Lib');

/**
 * UniLogin Controller.
 *
 */
class UniLoginController extends UniLoginAppController {

/**
 * An array of names of models to load.
 *
 * @var array
 */
	public $uses = [];

/**
 * Starts the Uni-Login login process (by redirecting the user to the authentication provider).
 *
 * @return \Cake\Network\Response|null
filter:
    dependency_paths: ["lib/*"]
 */
	public function login() {
		// Default callback url
		$url = ['action' => 'callback'];
		$returnUrl = $this->request->query('returnUrl');
		if ($returnUrl) {
			$path = parse_url($returnUrl, PHP_URL_PATH);
			$url['?'] = [
				'returnUrl' => $path,
			];
		}

		$url = Router::url($url, true);
filter:
    dependency_paths: ["lib/*"]

		$query = [
			'path' => UniLoginUtil::encodeUrl($url),
			'auth' => UniLoginUtil::calculateUrlFingerprint($url),
			'id' => Configure::read('UniLogin.provider.applicationId')
filter:
    dependency_paths: ["lib/*"]
		];

		$redirectUrl = Configure::read('UniLogin.provider.url');
		$redirectUrl .= '?' . http_build_query($query);

		return $this->redirect($redirectUrl);
	}

/**
 * Receives auth response and does validation.
 *
 * @return void
 */
	public function callback() {
		$response = $this->request->query;

		$user = $this->request->query('user');
		$timestamp = $this->request->query('timestamp');
		$auth = $this->request->query('auth');

		$fingerprint = UniLoginUtil::calculateFingerprint($timestamp, $user);

		if ($user && $timestamp && $auth && UniLoginUtil::validateFingerprint($timestamp, $user, $fingerprint)) {
			$response['validated'] = true;
		} else {
			$response['validated'] = false;
		}

		$completeUrl = Configure::read('UniLogin.application.completeUrl');

		$returnUrl = $this->request->query('returnUrl');
		if ($returnUrl) {
			$path = parse_url($returnUrl, PHP_URL_PATH);
			$completeUrl = $path;
		}

		$response['hmac'] = UniLoginUtil::hmac($response);

		return $this->_dispatch($completeUrl, $response);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
	}

/**
 * Redirects user to action in application with validated response data available as POST data retrievable at
 * $this->request->data` at your app's controller.
 *
 * @param string $url Url in application to dispatch to
 * @param array $data A list with post data
 * @return void
 */
	protected function _dispatch($url, $data) {
		$CakeRequest = new CakeRequest($url);
filter:
    dependency_paths: ["lib/*"]
		$CakeRequest->data = $data;

		$Dispatcher = new Dispatcher();
filter:
    dependency_paths: ["lib/*"]
		$Dispatcher->dispatch($CakeRequest, new CakeResponse());
filter:
    dependency_paths: ["lib/*"]

		$this->_stop();
	}
}


1			<?php
2			App::uses('UniLoginUtil', 'UniLogin.Lib');
3
4			/**
5			* UniLogin Controller.
6			*
7			*/
8			class UniLoginController extends UniLoginAppController {
9
10			/**
11			* An array of names of models to load.
12			*
13			* @var array
14			*/
15			public $uses = [];
16
17			/**
18			* Starts the Uni-Login login process (by redirecting the user to the authentication provider).
19			*
20			* @return \Cake\Network\Response\|null
			0 ignored issues – show Bug introduced 2019-01-22 22:56 UTC by Report Bug Copy Issue Report The type `Cake\Network\Response` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
21			*/
22			public function login() {
23			// Default callback url
24			$url = ['action' => 'callback'];
25			$returnUrl = $this->request->query('returnUrl');
26			if ($returnUrl) {
27			$path = parse_url($returnUrl, PHP_URL_PATH);
28			$url['?'] = [
29			'returnUrl' => $path,
30			];
31			}
32
33			$url = Router::url($url, true);
			0 ignored issues – show Bug introduced 2019-01-22 22:56 UTC by Report Bug Copy Issue Report The type `Router` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
34
35			$query = [
36			'path' => UniLoginUtil::encodeUrl($url),
37			'auth' => UniLoginUtil::calculateUrlFingerprint($url),
38			'id' => Configure::read('UniLogin.provider.applicationId')
			0 ignored issues – show Bug introduced 2019-01-22 22:56 UTC by Report Bug Copy Issue Report The type `Configure` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
39			];
40
41			$redirectUrl = Configure::read('UniLogin.provider.url');
42			$redirectUrl .= '?' . http_build_query($query);
43
44			return $this->redirect($redirectUrl);
45			}
46
47			/**
48			* Receives auth response and does validation.
49			*
50			* @return void
51			*/
52			public function callback() {
53			$response = $this->request->query;
54
55			$user = $this->request->query('user');
56			$timestamp = $this->request->query('timestamp');
57			$auth = $this->request->query('auth');
58
59			$fingerprint = UniLoginUtil::calculateFingerprint($timestamp, $user);
60
61			if ($user && $timestamp && $auth && UniLoginUtil::validateFingerprint($timestamp, $user, $fingerprint)) {
62			$response['validated'] = true;
63			} else {
64			$response['validated'] = false;
65			}
66
67			$completeUrl = Configure::read('UniLogin.application.completeUrl');
68
69			$returnUrl = $this->request->query('returnUrl');
70			if ($returnUrl) {
71			$path = parse_url($returnUrl, PHP_URL_PATH);
72			$completeUrl = $path;
73			}
74
75			$response['hmac'] = UniLoginUtil::hmac($response);
76
77			return $this->_dispatch($completeUrl, $response);
			0 ignored issues – show Bug introduced 2019-01-22 22:56 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->_dispatch($completeUrl, $response)` targeting `UniLoginController::_dispatch()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
78			}
79
80			/**
81			* Redirects user to action in application with validated response data available as POST data retrievable at
82			* $this->request->data` at your app's controller.
83			*
84			* @param string $url Url in application to dispatch to
85			* @param array $data A list with post data
86			* @return void
87			*/
88			protected function _dispatch($url, $data) {
89			$CakeRequest = new CakeRequest($url);
			0 ignored issues – show Bug introduced 2019-01-22 22:56 UTC by Report Bug Copy Issue Report The type `CakeRequest` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
90			$CakeRequest->data = $data;
91
92			$Dispatcher = new Dispatcher();
			0 ignored issues – show Bug introduced 2019-01-22 22:56 UTC by Report Bug Copy Issue Report The type `Dispatcher` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
93			$Dispatcher->dispatch($CakeRequest, new CakeResponse());
			0 ignored issues – show Bug introduced 2019-01-22 22:56 UTC by Report Bug Copy Issue Report The type `CakeResponse` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
94
95			$this->_stop();
96			}
97			}
98

Oefenweb / cakephp-uni-login

UniLoginController::_dispatch() A last analyzed 2019-01-23 12:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

UniLoginController::_dispatch() A
last analyzed 2019-01-23 12:30 UTC