Issues in NullObjectFunctionalTest.php (master) - Issues in master - Ocramius/ProxyManager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1446)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Functional/NullObjectFunctionalTest.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace ProxyManagerTest\Functional;

use PHPUnit\Framework\TestCase;
use ProxyManager\Factory\NullObjectFactory;
use ProxyManager\Proxy\NullObjectInterface;
use ProxyManagerTestAsset\BaseClass;
use ProxyManagerTestAsset\BaseInterface;
use ProxyManagerTestAsset\ClassWithMethodWithByRefVariadicFunction;
use ProxyManagerTestAsset\ClassWithMethodWithVariadicFunction;
use ProxyManagerTestAsset\ClassWithParentHint;
use ProxyManagerTestAsset\ClassWithSelfHint;
use ProxyManagerTestAsset\EmptyClass;
use ProxyManagerTestAsset\VoidCounter;
use stdClass;
use function array_values;
use function random_int;
use function serialize;
use function uniqid;
use function unserialize;

/**
 * Tests for {@see \ProxyManager\ProxyGenerator\NullObjectGenerator} produced objects
 *
 * @group Functional
 * @coversNothing
 */
final class NullObjectFunctionalTest extends TestCase
{
    /**
     * @param mixed[] $params
     *
     * @dataProvider getProxyMethods
     *
     * @psalm-param class-string $className
     */
    public function testMethodCalls(string $className, string $method, array $params) : void
    {
        $proxy = (new NullObjectFactory())->createProxy($className);

        $this->assertNullMethodCall($proxy, $method, $params);
    }

    /**
     * @param mixed[] $params
     *
     * @dataProvider getProxyMethods
     *
     * @psalm-param class-string $className
     */
    public function testMethodCallsAfterUnSerialization(string $className, string $method, array $params) : void
    {
        /** @var NullObjectInterface $proxy */
        $proxy = unserialize(serialize((new NullObjectFactory())->createProxy($className)));

        $this->assertNullMethodCall($proxy, $method, $params);
    }

    /**
     * @param mixed[] $params
     *
     * @dataProvider getProxyMethods
     *
     * @psalm-param class-string $className
     */
    public function testMethodCallsAfterCloning(string $className, string $method, array $params) : void
    {
        $proxy = (new NullObjectFactory())->createProxy($className);

        $this->assertNullMethodCall(clone $proxy, $method, $params);
    }

    /**
     * @dataProvider getPropertyAccessProxies
     */
    public function testPropertyReadAccess(NullObjectInterface $proxy, string $publicProperty) : void
    {
        self::assertNull($proxy->$publicProperty);

    }

    /**
     * @dataProvider getPropertyAccessProxies
     */
    public function testPropertyWriteAccess(NullObjectInterface $proxy, string $publicProperty) : void
    {
        $newValue               = uniqid('', true);
        $proxy->$publicProperty = $newValue;

        self::assertSame($newValue, $proxy->$publicProperty);

    }

    /**
     * @dataProvider getPropertyAccessProxies
     */
    public function testPropertyExistence(NullObjectInterface $proxy, string $publicProperty) : void
    {
        self::assertNull($proxy->$publicProperty);

    }

    /**
     * @dataProvider getPropertyAccessProxies
     */
    public function testPropertyUnset(NullObjectInterface $proxy, string $publicProperty) : void
    {
        unset($proxy->$publicProperty);

        self::assertFalse(isset($proxy->$publicProperty));

    }

    /**
     * Generates a list of object | invoked method | parameters | expected result
     *
     * @return string[][]|null[][]|mixed[][][]|object[][]
     */
    public function getProxyMethods() : array
    {
        $selfHintParam = new ClassWithSelfHint();
        $empty         = new EmptyClass();

        return [
            [
                BaseClass::class,
                'publicMethod',
                [],
                'publicMethodDefault',
            ],
            [
                BaseClass::class,
                'publicTypeHintedMethod',
                ['param' => new stdClass()],
                'publicTypeHintedMethodDefault',
            ],
            [
                BaseClass::class,
                'publicByReferenceMethod',
                [],
                'publicByReferenceMethodDefault',
            ],
            [
                BaseInterface::class,
                'publicMethod',
                [],
                'publicMethodDefault',
            ],
            [
                ClassWithSelfHint::class,
                'selfHintMethod',
                ['parameter' => $selfHintParam],
                $selfHintParam,
            ],
            [
                ClassWithParentHint::class,
                'parentHintMethod',
                ['parameter' => $empty],
                $empty,
            ],
            [
                ClassWithMethodWithVariadicFunction::class,
                'buz',
                ['Ocramius', 'Malukenho'],
                null,
            ],
            [
                ClassWithMethodWithByRefVariadicFunction::class,
                'tuz',
                ['Ocramius', 'Malukenho'],
                null,
            ],
            [
                VoidCounter::class,
                'increment',
                [random_int(10, 1000)],
                null,
            ],
        ];
    }

    /**
     * Generates proxies and instances with a public property to feed to the property accessor methods
     *
     * @return array<int, array<int, NullObjectInterface|string>>

     */
    public function getPropertyAccessProxies() : array
    {
        $factory = new NullObjectFactory();
        /** @var NullObjectInterface $serialized */
        $serialized = unserialize(serialize($factory->createProxy(BaseClass::class)));

        return [
            [
                $factory->createProxy(BaseClass::class),
                'publicProperty',
                'publicPropertyDefault',
            ],
            [
                $serialized,
                'publicProperty',
                'publicPropertyDefault',
            ],
        ];
    }

    /**
     * @param mixed[] $parameters
     */
    private function assertNullMethodCall(NullObjectInterface $proxy, string $methodName, array $parameters) : void
    {
        $method = [$proxy, $methodName];

        self::assertIsCallable($method);


        $parameterValues = array_values($parameters);

        self::assertNull($method(...$parameterValues));

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ProxyManagerTest\Functional;
6
7			use PHPUnit\Framework\TestCase;
8			use ProxyManager\Factory\NullObjectFactory;
9			use ProxyManager\Proxy\NullObjectInterface;
10			use ProxyManagerTestAsset\BaseClass;
11			use ProxyManagerTestAsset\BaseInterface;
12			use ProxyManagerTestAsset\ClassWithMethodWithByRefVariadicFunction;
13			use ProxyManagerTestAsset\ClassWithMethodWithVariadicFunction;
14			use ProxyManagerTestAsset\ClassWithParentHint;
15			use ProxyManagerTestAsset\ClassWithSelfHint;
16			use ProxyManagerTestAsset\EmptyClass;
17			use ProxyManagerTestAsset\VoidCounter;
18			use stdClass;
19			use function array_values;
20			use function random_int;
21			use function serialize;
22			use function uniqid;
23			use function unserialize;
24
25			/**
26			* Tests for {@see \ProxyManager\ProxyGenerator\NullObjectGenerator} produced objects
27			*
28			* @group Functional
29			* @coversNothing
30			*/
31			final class NullObjectFunctionalTest extends TestCase
32			{
33			/**
34			* @param mixed[] $params
35			*
36			* @dataProvider getProxyMethods
37			*
38			* @psalm-param class-string $className
39			*/
40			public function testMethodCalls(string $className, string $method, array $params) : void
41			{
42			$proxy = (new NullObjectFactory())->createProxy($className);
43
44			$this->assertNullMethodCall($proxy, $method, $params);
45			}
46
47			/**
48			* @param mixed[] $params
49			*
50			* @dataProvider getProxyMethods
51			*
52			* @psalm-param class-string $className
53			*/
54			public function testMethodCallsAfterUnSerialization(string $className, string $method, array $params) : void
55			{
56			/** @var NullObjectInterface $proxy */
57			$proxy = unserialize(serialize((new NullObjectFactory())->createProxy($className)));
58
59			$this->assertNullMethodCall($proxy, $method, $params);
60			}
61
62			/**
63			* @param mixed[] $params
64			*
65			* @dataProvider getProxyMethods
66			*
67			* @psalm-param class-string $className
68			*/
69			public function testMethodCallsAfterCloning(string $className, string $method, array $params) : void
70			{
71			$proxy = (new NullObjectFactory())->createProxy($className);
72
73			$this->assertNullMethodCall(clone $proxy, $method, $params);
74			}
75
76			/**
77			* @dataProvider getPropertyAccessProxies
78			*/
79			public function testPropertyReadAccess(NullObjectInterface $proxy, string $publicProperty) : void
80			{
81			self::assertNull($proxy->$publicProperty);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertNull()` does not exist on `ProxyManagerTest\Functio...ullObjectFunctionalTest`. Did you maybe mean `assertNullMethodCall()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
82			}
83
84			/**
85			* @dataProvider getPropertyAccessProxies
86			*/
87			public function testPropertyWriteAccess(NullObjectInterface $proxy, string $publicProperty) : void
88			{
89			$newValue = uniqid('', true);
90			$proxy->$publicProperty = $newValue;
91
92			self::assertSame($newValue, $proxy->$publicProperty);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...llObjectFunctionalTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
93			}
94
95			/**
96			* @dataProvider getPropertyAccessProxies
97			*/
98			public function testPropertyExistence(NullObjectInterface $proxy, string $publicProperty) : void
99			{
100			self::assertNull($proxy->$publicProperty);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertNull()` does not exist on `ProxyManagerTest\Functio...ullObjectFunctionalTest`. Did you maybe mean `assertNullMethodCall()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
101			}
102
103			/**
104			* @dataProvider getPropertyAccessProxies
105			*/
106			public function testPropertyUnset(NullObjectInterface $proxy, string $publicProperty) : void
107			{
108			unset($proxy->$publicProperty);
109
110			self::assertFalse(isset($proxy->$publicProperty));
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertFalse()` does not seem to exist on `object<ProxyManagerTest\...llObjectFunctionalTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
111			}
112
113			/**
114			* Generates a list of object \| invoked method \| parameters \| expected result
115			*
116			* @return string[][]\|null[][]\|mixed[][][]\|object[][]
117			*/
118			public function getProxyMethods() : array
119			{
120			$selfHintParam = new ClassWithSelfHint();
121			$empty = new EmptyClass();
122
123			return [
124			[
125			BaseClass::class,
126			'publicMethod',
127			[],
128			'publicMethodDefault',
129			],
130			[
131			BaseClass::class,
132			'publicTypeHintedMethod',
133			['param' => new stdClass()],
134			'publicTypeHintedMethodDefault',
135			],
136			[
137			BaseClass::class,
138			'publicByReferenceMethod',
139			[],
140			'publicByReferenceMethodDefault',
141			],
142			[
143			BaseInterface::class,
144			'publicMethod',
145			[],
146			'publicMethodDefault',
147			],
148			[
149			ClassWithSelfHint::class,
150			'selfHintMethod',
151			['parameter' => $selfHintParam],
152			$selfHintParam,
153			],
154			[
155			ClassWithParentHint::class,
156			'parentHintMethod',
157			['parameter' => $empty],
158			$empty,
159			],
160			[
161			ClassWithMethodWithVariadicFunction::class,
162			'buz',
163			['Ocramius', 'Malukenho'],
164			null,
165			],
166			[
167			ClassWithMethodWithByRefVariadicFunction::class,
168			'tuz',
169			['Ocramius', 'Malukenho'],
170			null,
171			],
172			[
173			VoidCounter::class,
174			'increment',
175			[random_int(10, 1000)],
176			null,
177			],
178			];
179			}
180
181			/**
182			* Generates proxies and instances with a public property to feed to the property accessor methods
183			*
184			* @return array<int, array<int, NullObjectInterface\|string>>
			0 ignored issues – show Documentation introduced 2019-06-20 03:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `array<int,` could not be parsed: Expected ">" at position 5, but found "end of type". (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
185			*/
186			public function getPropertyAccessProxies() : array
187			{
188			$factory = new NullObjectFactory();
189			/** @var NullObjectInterface $serialized */
190			$serialized = unserialize(serialize($factory->createProxy(BaseClass::class)));
191
192			return [
193			[
194			$factory->createProxy(BaseClass::class),
195			'publicProperty',
196			'publicPropertyDefault',
197			],
198			[
199			$serialized,
200			'publicProperty',
201			'publicPropertyDefault',
202			],
203			];
204			}
205
206			/**
207			* @param mixed[] $parameters
208			*/
209			private function assertNullMethodCall(NullObjectInterface $proxy, string $methodName, array $parameters) : void
210			{
211			$method = [$proxy, $methodName];
212
213			self::assertIsCallable($method);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertIsCallable()` does not seem to exist on `object<ProxyManagerTest\...llObjectFunctionalTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
214
215			$parameterValues = array_values($parameters);
216
217			self::assertNull($method(...$parameterValues));
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertNull()` does not exist on `ProxyManagerTest\Functio...ullObjectFunctionalTest`. Did you maybe mean `assertNullMethodCall()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
218			}
219			}
220

Ocramius / ProxyManager

Issues (1446)

Security Analysis no request data

Functional/NullObjectFunctionalTest.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like