Issues in AutoloaderTest.php - Fixed Issues - Inspection of "Merge pull request #442 from malukenho/improve-tes..." - Ocramius/ProxyManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6a6c80...a2c1e8 )

by Marco

created 2019-02-27 13:37 UTC

ProxyManagerTest/Autoloader/AutoloaderTest.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace ProxyManagerTest\Autoloader;

use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use ProxyManager\Autoloader\Autoloader;
use ProxyManager\FileLocator\FileLocatorInterface;
use ProxyManager\Generator\Util\UniqueIdentifierGenerator;
use ProxyManager\Inflector\ClassNameInflectorInterface;
use function class_exists;
use function file_put_contents;
use function spl_autoload_register;
use function spl_autoload_unregister;
use function sprintf;
use function sys_get_temp_dir;
use function uniqid;

/**
 * Tests for {@see \ProxyManager\Autoloader\Autoloader}
 *
 * @covers \ProxyManager\Autoloader\Autoloader
 * @group Coverage
 */
class AutoloaderTest extends TestCase
{
    /** @var Autoloader */
    protected $autoloader;

    /** @var FileLocatorInterface|MockObject */
    protected $fileLocator;

    /** @var ClassNameInflectorInterface|MockObject */
    protected $classNameInflector;

    /**
     * @covers \ProxyManager\Autoloader\Autoloader::__construct
     */
    protected function setUp() : void
    {
        $this->fileLocator        = $this->createMock(FileLocatorInterface::class);
        $this->classNameInflector = $this->createMock(ClassNameInflectorInterface::class);
        $this->autoloader         = new Autoloader($this->fileLocator, $this->classNameInflector);
    }

    /**
     * @covers \ProxyManager\Autoloader\Autoloader::__invoke
     */
    public function testWillNotAutoloadUserClasses() : void
    {
        $className = 'Foo\\' . UniqueIdentifierGenerator::getIdentifier('Bar');
        $this
            ->classNameInflector
            ->expects(self::once())
            ->method('isProxyClassName')
            ->with($className)
            ->will(self::returnValue(false));

        self::assertFalse($this->autoloadWithoutFurtherAutoloaders($className));
    }

    /**
     * @covers \ProxyManager\Autoloader\Autoloader::__invoke
     */
    public function testWillNotAutoloadNonExistingClass() : void
    {
        $className = 'Foo\\' . UniqueIdentifierGenerator::getIdentifier('Bar');
        $this
            ->classNameInflector
            ->expects(self::once())
            ->method('isProxyClassName')
            ->with($className)
            ->will(self::returnValue(true));
        $this

            ->fileLocator
            ->expects(self::once())
            ->method('getProxyFileName')
            ->will(self::returnValue(__DIR__ . '/non-existing'));

        self::assertFalse($this->autoloadWithoutFurtherAutoloaders($className));
    }

    /**
     * @covers \ProxyManager\Autoloader\Autoloader::__invoke
     */
    public function testWillNotAutoloadExistingClass() : void
    {
        self::assertFalse($this->autoloadWithoutFurtherAutoloaders(self::class));
    }

    /**
     * @covers \ProxyManager\Autoloader\Autoloader::__invoke
     */
    public function testWillAutoloadExistingFile() : void
    {
        $namespace = 'Foo';
        $className = UniqueIdentifierGenerator::getIdentifier('Bar');
        $fqcn      = $namespace . '\\' . $className;
        $fileName  = sys_get_temp_dir() . '/foo_' . uniqid() . '.php';

        file_put_contents($fileName, '<?php namespace ' . $namespace . '; class ' . $className . '{}');

        $this
            ->classNameInflector
            ->expects(self::once())
            ->method('isProxyClassName')
            ->with($fqcn)
            ->will(self::returnValue(true));
        $this

            ->fileLocator
            ->expects(self::once())
            ->method('getProxyFileName')
            ->will(self::returnValue($fileName));

        self::assertTrue($this->autoloadWithoutFurtherAutoloaders($fqcn));
        self::assertTrue(class_exists($fqcn, false));
    }

    private function autoloadWithoutFurtherAutoloaders(string $className) : bool
    {
        $failingAutoloader = null;
        $failingAutoloader = function (string $className) use (& $failingAutoloader) : void {
            spl_autoload_unregister($failingAutoloader);

            $this->fail(sprintf('Fallback autoloading was triggered to load "%s"', $className));
        };

        spl_autoload_register($failingAutoloader);

        $result = $this->autoloader->__invoke($className);

        spl_autoload_unregister($failingAutoloader);

        return $result;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ProxyManagerTest\Autoloader;
6
7			use PHPUnit\Framework\MockObject\MockObject;
8			use PHPUnit\Framework\TestCase;
9			use ProxyManager\Autoloader\Autoloader;
10			use ProxyManager\FileLocator\FileLocatorInterface;
11			use ProxyManager\Generator\Util\UniqueIdentifierGenerator;
12			use ProxyManager\Inflector\ClassNameInflectorInterface;
13			use function class_exists;
14			use function file_put_contents;
15			use function spl_autoload_register;
16			use function spl_autoload_unregister;
17			use function sprintf;
18			use function sys_get_temp_dir;
19			use function uniqid;
20
21			/**
22			* Tests for {@see \ProxyManager\Autoloader\Autoloader}
23			*
24			* @covers \ProxyManager\Autoloader\Autoloader
25			* @group Coverage
26			*/
27			class AutoloaderTest extends TestCase
28			{
29			/** @var Autoloader */
30			protected $autoloader;
31
32			/** @var FileLocatorInterface\|MockObject */
33			protected $fileLocator;
34
35			/** @var ClassNameInflectorInterface\|MockObject */
36			protected $classNameInflector;
37
38			/**
39			* @covers \ProxyManager\Autoloader\Autoloader::__construct
40			*/
41			protected function setUp() : void
42			{
43			$this->fileLocator = $this->createMock(FileLocatorInterface::class);
44			$this->classNameInflector = $this->createMock(ClassNameInflectorInterface::class);
45			$this->autoloader = new Autoloader($this->fileLocator, $this->classNameInflector);
46			}
47
48			/**
49			* @covers \ProxyManager\Autoloader\Autoloader::__invoke
50			*/
51			public function testWillNotAutoloadUserClasses() : void
52			{
53			$className = 'Foo\\' . UniqueIdentifierGenerator::getIdentifier('Bar');
54			$this
55			->classNameInflector
56			->expects(self::once())
57			->method('isProxyClassName')
58			->with($className)
59			->will(self::returnValue(false));
60
61			self::assertFalse($this->autoloadWithoutFurtherAutoloaders($className));
62			}
63
64			/**
65			* @covers \ProxyManager\Autoloader\Autoloader::__invoke
66			*/
67			public function testWillNotAutoloadNonExistingClass() : void
68			{
69			$className = 'Foo\\' . UniqueIdentifierGenerator::getIdentifier('Bar');
70			$this
71			->classNameInflector
72			->expects(self::once())
73			->method('isProxyClassName')
74			->with($className)
75			->will(self::returnValue(true));
76			$this
			0 ignored issues – show Bug introduced 2017-05-04 11:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<ProxyManager\File...r\FileLocatorInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
77			->fileLocator
78			->expects(self::once())
79			->method('getProxyFileName')
80			->will(self::returnValue(__DIR__ . '/non-existing'));
81
82			self::assertFalse($this->autoloadWithoutFurtherAutoloaders($className));
83			}
84
85			/**
86			* @covers \ProxyManager\Autoloader\Autoloader::__invoke
87			*/
88			public function testWillNotAutoloadExistingClass() : void
89			{
90			self::assertFalse($this->autoloadWithoutFurtherAutoloaders(self::class));
91			}
92
93			/**
94			* @covers \ProxyManager\Autoloader\Autoloader::__invoke
95			*/
96			public function testWillAutoloadExistingFile() : void
97			{
98			$namespace = 'Foo';
99			$className = UniqueIdentifierGenerator::getIdentifier('Bar');
100			$fqcn = $namespace . '\\' . $className;
101			$fileName = sys_get_temp_dir() . '/foo_' . uniqid() . '.php';
102
103			file_put_contents($fileName, '<?php namespace ' . $namespace . '; class ' . $className . '{}');
104
105			$this
106			->classNameInflector
107			->expects(self::once())
108			->method('isProxyClassName')
109			->with($fqcn)
110			->will(self::returnValue(true));
111			$this
			0 ignored issues – show Bug introduced 2017-05-04 11:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<ProxyManager\File...r\FileLocatorInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
112			->fileLocator
113			->expects(self::once())
114			->method('getProxyFileName')
115			->will(self::returnValue($fileName));
116
117			self::assertTrue($this->autoloadWithoutFurtherAutoloaders($fqcn));
118			self::assertTrue(class_exists($fqcn, false));
119			}
120
121			private function autoloadWithoutFurtherAutoloaders(string $className) : bool
122			{
123			$failingAutoloader = null;
124			$failingAutoloader = function (string $className) use (& $failingAutoloader) : void {
125			spl_autoload_unregister($failingAutoloader);
126
127			$this->fail(sprintf('Fallback autoloading was triggered to load "%s"', $className));
128			};
129
130			spl_autoload_register($failingAutoloader);
131
132			$result = $this->autoloader->__invoke($className);
133
134			spl_autoload_unregister($failingAutoloader);
135
136			return $result;
137			}
138			}
139

Ocramius / ProxyManager

Push — master ( 6a6c80...a2c1e8 )

ProxyManagerTest/Autoloader/AutoloaderTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like