MethodGenerator::fromReflectionWithoutBodyAndDocBlock() - Code Metrics - Inspection of "Covered benchmarks via static types through psalm" - Ocramius/ProxyManager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#467)

by Marco

created 2019-06-18 08:56 UTC

fromReflectionWithoutBodyAndDocBlock() A

↳ Parent: MethodGenerator

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	4
cts	4
cp	1
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace ProxyManager\Generator;

use Zend\Code\Generator\DocBlockGenerator;
use Zend\Code\Generator\MethodGenerator as ZendMethodGenerator;
use Zend\Code\Reflection\MethodReflection;

/**
 * Method generator that fixes minor quirks in ZF2's method generator
 */
class MethodGenerator extends ZendMethodGenerator
{
    /**
     * {@inheritDoc}
     */
    public static function fromReflectionWithoutBodyAndDocBlock(MethodReflection $reflectionMethod) : self
    {
        /** @var self $method */
        $method = parent::copyMethodSignature($reflectionMethod);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        $method->setInterface(false);
        $method->setBody('');

        return $method;
    }

    /**
     * {@inheritDoc} override needed to specify type in more detail
     */
    public function getDocBlock() : ?DocBlockGenerator
    {
        return parent::getDocBlock();
    }

    /**
     * {@inheritDoc} override needed to specify type in more detail
     */
    public function getSourceContent() : ?string
    {
        return parent::getSourceContent();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ProxyManager\Generator;
6
7		use Zend\Code\Generator\DocBlockGenerator;
8		use Zend\Code\Generator\MethodGenerator as ZendMethodGenerator;
9		use Zend\Code\Reflection\MethodReflection;
10
11		/**
12		* Method generator that fixes minor quirks in ZF2's method generator
13		*/
14		class MethodGenerator extends ZendMethodGenerator
15		{
16		/**
17		* {@inheritDoc}
18		*/
19		public static function fromReflectionWithoutBodyAndDocBlock(MethodReflection $reflectionMethod) : self
20		{
21	19	/** @var self $method */
22		$method = parent::copyMethodSignature($reflectionMethod);
		0 ignored issues – show Comprehensibility Bug introduced 2017-10-20 15:53 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`copyMethodSignature()` instead of `fromReflectionWithoutBodyAndDocBlock()`). Are you sure this is correct? If so, you might want to change this to `$this->copyMethodSignature()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
23
24	19	$method->setInterface(false);
25		$method->setBody('');
26	19
27	19	return $method;
28		}
29	19
30		/**
31		* {@inheritDoc} override needed to specify type in more detail
32		*/
33		public function getDocBlock() : ?DocBlockGenerator
34		{
35		return parent::getDocBlock();
36		}
37
38		/**
39		* {@inheritDoc} override needed to specify type in more detail
40		*/
41		public function getSourceContent() : ?string
42		{
43		return parent::getSourceContent();
44		}
45		}
46

Ocramius / ProxyManager

Pull Request — master (#467)

fromReflectionWithoutBodyAndDocBlock() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like