ConstructorTest::testBodyStructure() - Code Metrics - Ocramius/ProxyManager - Measure and Improve Code Quality continuously with Scrutinizer

ConstructorTest::testBodyStructure() A
last analyzed 2020-04-01 06:30 UTC

↳ Parent: ConstructorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	28
rs	9.472
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace ProxyManagerTest\ProxyGenerator\ValueHolder\MethodGenerator;

use Laminas\Code\Generator\PropertyGenerator;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use ProxyManager\ProxyGenerator\ValueHolder\MethodGenerator\Constructor;
use ProxyManagerTestAsset\ClassWithMixedProperties;
use ProxyManagerTestAsset\ClassWithVariadicConstructorArgument;
use ProxyManagerTestAsset\EmptyClass;
use ProxyManagerTestAsset\ProxyGenerator\LazyLoading\MethodGenerator\ClassWithTwoPublicProperties;
use ReflectionClass;

/**
 * Tests for {@see \ProxyManager\ProxyGenerator\ValueHolder\MethodGenerator\Constructor}
 *
 * @covers \ProxyManager\ProxyGenerator\ValueHolder\MethodGenerator\Constructor
 * @group Coverage
 */
final class ConstructorTest extends TestCase
{
    public function testBodyStructure() : void
    {
        $valueHolder = $this->createMock(PropertyGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $valueHolder->method('getName')->willReturn('foo');


        $constructor = Constructor::generateMethod(
            new ReflectionClass(
                ClassWithTwoPublicProperties::class
            ),
            $valueHolder
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame('__construct', $constructor->getName());

        self::assertCount(0, $constructor->getParameters());

        self::assertSame(

            'static $reflection;

if (! $this->foo) {
    $reflection = $reflection ?: new \ReflectionClass(\'ProxyManagerTestAsset\\\\ProxyGenerator\\\\LazyLoading\\\\'
            . 'MethodGenerator\\\\ClassWithTwoPublicProperties\');
    $this->foo = $reflection->newInstanceWithoutConstructor();
unset($this->bar, $this->baz);

}',
            $constructor->getBody()
        );
    }

    public function testBodyStructureWithoutPublicProperties() : void
    {
        $valueHolder = $this->createMock(PropertyGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $valueHolder->method('getName')->willReturn('foo');


        $constructor = Constructor::generateMethod(
            new ReflectionClass(EmptyClass::class),
            $valueHolder
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame('__construct', $constructor->getName());

        self::assertCount(0, $constructor->getParameters());

        self::assertSame(

            'static $reflection;

if (! $this->foo) {
    $reflection = $reflection ?: new \ReflectionClass(\'ProxyManagerTestAsset\\\\EmptyClass\');
    $this->foo = $reflection->newInstanceWithoutConstructor();
}',
            $constructor->getBody()
        );
    }

    public function testBodyStructureWithStaticProperties() : void
    {
        $valueHolder = $this->createMock(PropertyGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $valueHolder->method('getName')->willReturn('foo');


        $constructor = Constructor::generateMethod(new ReflectionClass(ClassWithMixedProperties::class), $valueHolder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertSame('__construct', $constructor->getName());

        self::assertCount(0, $constructor->getParameters());


        $expectedCode = 'static $reflection;

if (! $this->foo) {
    $reflection = $reflection ?: new \ReflectionClass(\'ProxyManagerTestAsset\\\\ClassWithMixedProperties\');
    $this->foo = $reflection->newInstanceWithoutConstructor();
unset($this->publicProperty0, $this->publicProperty1, $this->publicProperty2, $this->protectedProperty0, '
            . '$this->protectedProperty1, $this->protectedProperty2);

\Closure::bind(function (\ProxyManagerTestAsset\ClassWithMixedProperties $instance) {
    unset($instance->privateProperty0, $instance->privateProperty1, $instance->privateProperty2);
}, $this, \'ProxyManagerTestAsset\\\\ClassWithMixedProperties\')->__invoke($this);

}';

        self::assertSame($expectedCode, $constructor->getBody());

    }

    public function testBodyStructureWithVariadicArguments() : void
    {
        $valueHolder = $this->createMock(PropertyGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $valueHolder->method('getName')->willReturn('foo');


        $constructor = Constructor::generateMethod(
            new ReflectionClass(ClassWithVariadicConstructorArgument::class),
            $valueHolder
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame('__construct', $constructor->getName());

        self::assertCount(2, $constructor->getParameters());


        $expectedCode = <<<'PHP'
static $reflection;

if (! $this->foo) {
    $reflection = $reflection ?: new \ReflectionClass('ProxyManagerTestAsset\\ClassWithVariadicConstructorArgument');
    $this->foo = $reflection->newInstanceWithoutConstructor();
\Closure::bind(function (\ProxyManagerTestAsset\ClassWithVariadicConstructorArgument $instance) {
    unset($instance->foo, $instance->bar);
}, $this, 'ProxyManagerTestAsset\\ClassWithVariadicConstructorArgument')->__invoke($this);

}

$this->foo->__construct($foo, ...$bar);
PHP;

        self::assertSame($expectedCode, $constructor->getBody());

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ProxyManagerTest\ProxyGenerator\ValueHolder\MethodGenerator;
6
7			use Laminas\Code\Generator\PropertyGenerator;
8			use PHPUnit\Framework\MockObject\MockObject;
9			use PHPUnit\Framework\TestCase;
10			use ProxyManager\ProxyGenerator\ValueHolder\MethodGenerator\Constructor;
11			use ProxyManagerTestAsset\ClassWithMixedProperties;
12			use ProxyManagerTestAsset\ClassWithVariadicConstructorArgument;
13			use ProxyManagerTestAsset\EmptyClass;
14			use ProxyManagerTestAsset\ProxyGenerator\LazyLoading\MethodGenerator\ClassWithTwoPublicProperties;
15			use ReflectionClass;
16
17			/**
18			* Tests for {@see \ProxyManager\ProxyGenerator\ValueHolder\MethodGenerator\Constructor}
19			*
20			* @covers \ProxyManager\ProxyGenerator\ValueHolder\MethodGenerator\Constructor
21			* @group Coverage
22			*/
23			final class ConstructorTest extends TestCase
24			{
25			public function testBodyStructure() : void
26			{
27			$valueHolder = $this->createMock(PropertyGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$valueHolder` is correct as `$this->createMock(\Lamin...opertyGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
28
29			$valueHolder->method('getName')->willReturn('foo');
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$valueHolder` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
30
31			$constructor = Constructor::generateMethod(
32			new ReflectionClass(
33			ClassWithTwoPublicProperties::class
34			),
35			$valueHolder
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$valueHolder` is of type `null`, but the function expects a `object<Laminas\Code\Generator\PropertyGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			);
37
38			self::assertSame('__construct', $constructor->getName());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
39			self::assertCount(0, $constructor->getParameters());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertCount()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
40			self::assertSame(
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41			'static $reflection;
42
43			if (! $this->foo) {
44			$reflection = $reflection ?: new \ReflectionClass(\'ProxyManagerTestAsset\\\\ProxyGenerator\\\\LazyLoading\\\\'
45			. 'MethodGenerator\\\\ClassWithTwoPublicProperties\');
46			$this->foo = $reflection->newInstanceWithoutConstructor();
47			unset($this->bar, $this->baz);
48
49			}',
50			$constructor->getBody()
51			);
52			}
53
54			public function testBodyStructureWithoutPublicProperties() : void
55			{
56			$valueHolder = $this->createMock(PropertyGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$valueHolder` is correct as `$this->createMock(\Lamin...opertyGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
57
58			$valueHolder->method('getName')->willReturn('foo');
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$valueHolder` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
59
60			$constructor = Constructor::generateMethod(
61			new ReflectionClass(EmptyClass::class),
62			$valueHolder
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$valueHolder` is of type `null`, but the function expects a `object<Laminas\Code\Generator\PropertyGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63			);
64
65			self::assertSame('__construct', $constructor->getName());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
66			self::assertCount(0, $constructor->getParameters());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertCount()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
67			self::assertSame(
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68			'static $reflection;
69
70			if (! $this->foo) {
71			$reflection = $reflection ?: new \ReflectionClass(\'ProxyManagerTestAsset\\\\EmptyClass\');
72			$this->foo = $reflection->newInstanceWithoutConstructor();
73			}',
74			$constructor->getBody()
75			);
76			}
77
78			public function testBodyStructureWithStaticProperties() : void
79			{
80			$valueHolder = $this->createMock(PropertyGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$valueHolder` is correct as `$this->createMock(\Lamin...opertyGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
81
82			$valueHolder->method('getName')->willReturn('foo');
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$valueHolder` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
83
84			$constructor = Constructor::generateMethod(new ReflectionClass(ClassWithMixedProperties::class), $valueHolder);
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$valueHolder` is of type `null`, but the function expects a `object<Laminas\Code\Generator\PropertyGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85
86			self::assertSame('__construct', $constructor->getName());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
87			self::assertCount(0, $constructor->getParameters());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertCount()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
88
89			$expectedCode = 'static $reflection;
90
91			if (! $this->foo) {
92			$reflection = $reflection ?: new \ReflectionClass(\'ProxyManagerTestAsset\\\\ClassWithMixedProperties\');
93			$this->foo = $reflection->newInstanceWithoutConstructor();
94			unset($this->publicProperty0, $this->publicProperty1, $this->publicProperty2, $this->protectedProperty0, '
95			. '$this->protectedProperty1, $this->protectedProperty2);
96
97			\Closure::bind(function (\ProxyManagerTestAsset\ClassWithMixedProperties $instance) {
98			unset($instance->privateProperty0, $instance->privateProperty1, $instance->privateProperty2);
99			}, $this, \'ProxyManagerTestAsset\\\\ClassWithMixedProperties\')->__invoke($this);
100
101			}';
102
103			self::assertSame($expectedCode, $constructor->getBody());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
104			}
105
106			public function testBodyStructureWithVariadicArguments() : void
107			{
108			$valueHolder = $this->createMock(PropertyGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$valueHolder` is correct as `$this->createMock(\Lamin...opertyGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
109
110			$valueHolder->method('getName')->willReturn('foo');
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$valueHolder` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
111
112			$constructor = Constructor::generateMethod(
113			new ReflectionClass(ClassWithVariadicConstructorArgument::class),
114			$valueHolder
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$valueHolder` is of type `null`, but the function expects a `object<Laminas\Code\Generator\PropertyGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
115			);
116
117			self::assertSame('__construct', $constructor->getName());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
118			self::assertCount(2, $constructor->getParameters());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertCount()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
119
120			$expectedCode = <<<'PHP'
121			static $reflection;
122
123			if (! $this->foo) {
124			$reflection = $reflection ?: new \ReflectionClass('ProxyManagerTestAsset\\ClassWithVariadicConstructorArgument');
125			$this->foo = $reflection->newInstanceWithoutConstructor();
126			\Closure::bind(function (\ProxyManagerTestAsset\ClassWithVariadicConstructorArgument $instance) {
127			unset($instance->foo, $instance->bar);
128			}, $this, 'ProxyManagerTestAsset\\ClassWithVariadicConstructorArgument')->__invoke($this);
129
130			}
131
132			$this->foo->__construct($foo, ...$bar);
133			PHP;
134
135			self::assertSame($expectedCode, $constructor->getBody());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...erator\ConstructorTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
136			}
137			}
138

Ocramius / ProxyManager

ConstructorTest::testBodyStructure() A last analyzed 2020-04-01 06:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ConstructorTest::testBodyStructure() A
last analyzed 2020-04-01 06:30 UTC