ClassGeneratorUtilsTest::testCanAddANotFinalMethod() - Code Metrics - Ocramius/ProxyManager - Measure and Improve Code Quality continuously with Scrutinizer

testCanAddANotFinalMethod() A
last analyzed 2020-04-01 06:30 UTC

↳ Parent: ClassGeneratorUtilsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace ProxyManagerTest\Generator\Util;

use Laminas\Code\Generator\ClassGenerator;
use Laminas\Code\Generator\MethodGenerator;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use ProxyManager\Generator\Util\ClassGeneratorUtils;
use ProxyManagerTestAsset\BaseClass;
use ProxyManagerTestAsset\ClassWithFinalMethods;
use ReflectionClass;

/**
 * Test to {@see ProxyManager\Generator\Util\ClassGeneratorUtils}
 *
 * @covers ProxyManager\Generator\Util\ClassGeneratorUtils
 * @group Coverage
 */
final class ClassGeneratorUtilsTest extends TestCase
{
    public function testCantAddAFinalMethod() : void
    {
        $classGenerator  = $this->createMock(ClassGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $methodGenerator = $this->createMock(MethodGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $methodGenerator

            ->expects(self::once())

            ->method('getName')
            ->willReturn('foo');

        $classGenerator

            ->expects(self::never())

            ->method('addMethodFromGenerator');

        $reflection = new ReflectionClass(ClassWithFinalMethods::class);

        self::assertFalse(ClassGeneratorUtils::addMethodIfNotFinal($reflection, $classGenerator, $methodGenerator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testCanAddANotFinalMethod() : void
    {
        $classGenerator  = $this->createMock(ClassGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $methodGenerator = $this->createMock(MethodGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $methodGenerator

            ->expects(self::once())

            ->method('getName')
            ->willReturn('publicMethod');

        $classGenerator

            ->expects(self::once())

            ->method('addMethodFromGenerator');

        $reflection = new ReflectionClass(BaseClass::class);

        self::assertTrue(ClassGeneratorUtils::addMethodIfNotFinal($reflection, $classGenerator, $methodGenerator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ProxyManagerTest\Generator\Util;
6
7			use Laminas\Code\Generator\ClassGenerator;
8			use Laminas\Code\Generator\MethodGenerator;
9			use PHPUnit\Framework\MockObject\MockObject;
10			use PHPUnit\Framework\TestCase;
11			use ProxyManager\Generator\Util\ClassGeneratorUtils;
12			use ProxyManagerTestAsset\BaseClass;
13			use ProxyManagerTestAsset\ClassWithFinalMethods;
14			use ReflectionClass;
15
16			/**
17			* Test to {@see ProxyManager\Generator\Util\ClassGeneratorUtils}
18			*
19			* @covers ProxyManager\Generator\Util\ClassGeneratorUtils
20			* @group Coverage
21			*/
22			final class ClassGeneratorUtilsTest extends TestCase
23			{
24			public function testCantAddAFinalMethod() : void
25			{
26			$classGenerator = $this->createMock(ClassGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$classGenerator` is correct as `$this->createMock(\Lamin...\ClassGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
27			$methodGenerator = $this->createMock(MethodGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$methodGenerator` is correct as `$this->createMock(\Lamin...MethodGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
28
29			$methodGenerator
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `expects` cannot be called on `$methodGenerator` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
30			->expects(self::once())
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `once()` does not seem to exist on `object<ProxyManagerTest\...lassGeneratorUtilsTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			->method('getName')
32			->willReturn('foo');
33
34			$classGenerator
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `expects` cannot be called on `$classGenerator` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
35			->expects(self::never())
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `never()` does not seem to exist on `object<ProxyManagerTest\...lassGeneratorUtilsTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
36			->method('addMethodFromGenerator');
37
38			$reflection = new ReflectionClass(ClassWithFinalMethods::class);
39
40			self::assertFalse(ClassGeneratorUtils::addMethodIfNotFinal($reflection, $classGenerator, $methodGenerator));
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$classGenerator` is of type `null`, but the function expects a `object<Laminas\Code\Generator\ClassGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$methodGenerator` is of type `null`, but the function expects a `object<Laminas\Code\Generator\MethodGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<ProxyManagerTest\...lassGeneratorUtilsTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41			}
42
43			public function testCanAddANotFinalMethod() : void
44			{
45			$classGenerator = $this->createMock(ClassGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$classGenerator` is correct as `$this->createMock(\Lamin...\ClassGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
46			$methodGenerator = $this->createMock(MethodGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$methodGenerator` is correct as `$this->createMock(\Lamin...MethodGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
47
48			$methodGenerator
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `expects` cannot be called on `$methodGenerator` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
49			->expects(self::once())
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `once()` does not seem to exist on `object<ProxyManagerTest\...lassGeneratorUtilsTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
50			->method('getName')
51			->willReturn('publicMethod');
52
53			$classGenerator
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `expects` cannot be called on `$classGenerator` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
54			->expects(self::once())
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `once()` does not seem to exist on `object<ProxyManagerTest\...lassGeneratorUtilsTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
55			->method('addMethodFromGenerator');
56
57			$reflection = new ReflectionClass(BaseClass::class);
58
59			self::assertTrue(ClassGeneratorUtils::addMethodIfNotFinal($reflection, $classGenerator, $methodGenerator));
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$classGenerator` is of type `null`, but the function expects a `object<Laminas\Code\Generator\ClassGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$methodGenerator` is of type `null`, but the function expects a `object<Laminas\Code\Generator\MethodGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<ProxyManagerTest\...lassGeneratorUtilsTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
60			}
61			}
62

Ocramius / ProxyManager

testCanAddANotFinalMethod() A last analyzed 2020-04-01 06:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

testCanAddANotFinalMethod() A
last analyzed 2020-04-01 06:30 UTC