MagicIssetTest - Code Metrics - Ocramius/ProxyManager - Measure and Improve Code Quality continuously with Scrutinizer

MagicIssetTest A
last analyzed 2020-04-01 06:30 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	2
dl	0
loc	31
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testBodyStructure()	0	25	1

<?php

declare(strict_types=1);

namespace ProxyManagerTest\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator;

use Laminas\Code\Generator\PropertyGenerator;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use ProxyManager\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator\MagicIsset;
use ProxyManager\ProxyGenerator\PropertyGenerator\PublicPropertiesMap;
use ProxyManagerTestAsset\EmptyClass;
use ReflectionClass;
use function strpos;

/**
 * Tests for {@see \ProxyManager\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator\MagicIsset}
 *
 * @group Coverage
 */
final class MagicIssetTest extends TestCase
{
    /**
     * @covers \ProxyManager\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator\MagicIsset::__construct
     */
    public function testBodyStructure() : void
    {
        $reflection         = new ReflectionClass(EmptyClass::class);
        $valueHolder        = $this->createMock(PropertyGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $prefixInterceptors = $this->createMock(PropertyGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $suffixInterceptors = $this->createMock(PropertyGenerator::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $publicProperties   = $this->createMock(PublicPropertiesMap::class);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $valueHolder->method('getName')->willReturn('bar');

        $prefixInterceptors->method('getName')->willReturn('pre');

        $suffixInterceptors->method('getName')->willReturn('post');

        $publicProperties->method('isEmpty')->willReturn(false);


        $magicIsset = new MagicIsset(
            $reflection,
            $valueHolder,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $prefixInterceptors,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $suffixInterceptors,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $publicProperties
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame('__isset', $magicIsset->getName());

        self::assertCount(1, $magicIsset->getParameters());

        self::assertGreaterThan(0, strpos($magicIsset->getBody(), '$returnValue = isset($this->bar->$name);'));

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ProxyManagerTest\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator;
6
7			use Laminas\Code\Generator\PropertyGenerator;
8			use PHPUnit\Framework\MockObject\MockObject;
9			use PHPUnit\Framework\TestCase;
10			use ProxyManager\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator\MagicIsset;
11			use ProxyManager\ProxyGenerator\PropertyGenerator\PublicPropertiesMap;
12			use ProxyManagerTestAsset\EmptyClass;
13			use ReflectionClass;
14			use function strpos;
15
16			/**
17			* Tests for {@see \ProxyManager\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator\MagicIsset}
18			*
19			* @group Coverage
20			*/
21			final class MagicIssetTest extends TestCase
22			{
23			/**
24			* @covers \ProxyManager\ProxyGenerator\AccessInterceptorValueHolder\MethodGenerator\MagicIsset::__construct
25			*/
26			public function testBodyStructure() : void
27			{
28			$reflection = new ReflectionClass(EmptyClass::class);
29			$valueHolder = $this->createMock(PropertyGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$valueHolder` is correct as `$this->createMock(\Lamin...opertyGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
30			$prefixInterceptors = $this->createMock(PropertyGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$prefixInterceptors` is correct as `$this->createMock(\Lamin...opertyGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
31			$suffixInterceptors = $this->createMock(PropertyGenerator::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$suffixInterceptors` is correct as `$this->createMock(\Lamin...opertyGenerator::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
32			$publicProperties = $this->createMock(PublicPropertiesMap::class);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$publicProperties` is correct as `$this->createMock(\Proxy...icPropertiesMap::class)` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
33
34			$valueHolder->method('getName')->willReturn('bar');
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$valueHolder` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
35			$prefixInterceptors->method('getName')->willReturn('pre');
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$prefixInterceptors` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
36			$suffixInterceptors->method('getName')->willReturn('post');
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$suffixInterceptors` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
37			$publicProperties->method('isEmpty')->willReturn(false);
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `method` cannot be called on `$publicProperties` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
38
39			$magicIsset = new MagicIsset(
40			$reflection,
41			$valueHolder,
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$valueHolder` is of type `null`, but the function expects a `object<Laminas\Code\Generator\PropertyGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			$prefixInterceptors,
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$prefixInterceptors` is of type `null`, but the function expects a `object<Laminas\Code\Generator\PropertyGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43			$suffixInterceptors,
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$suffixInterceptors` is of type `null`, but the function expects a `object<Laminas\Code\Generator\PropertyGenerator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44			$publicProperties
			0 ignored issues – show Documentation introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report `$publicProperties` is of type `null`, but the function expects a `object<ProxyManager\Prox...or\PublicPropertiesMap>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45			);
46
47			self::assertSame('__isset', $magicIsset->getName());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<ProxyManagerTest\...nerator\MagicIssetTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
48			self::assertCount(1, $magicIsset->getParameters());
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertCount()` does not seem to exist on `object<ProxyManagerTest\...nerator\MagicIssetTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
49			self::assertGreaterThan(0, strpos($magicIsset->getBody(), '$returnValue = isset($this->bar->$name);'));
			0 ignored issues – show Bug introduced 2020-04-01 06:30 UTC by Report Bug Copy Issue Report The method `assertGreaterThan()` does not seem to exist on `object<ProxyManagerTest\...nerator\MagicIssetTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
50			}
51			}
52

Ocramius / ProxyManager

MagicIssetTest A last analyzed 2020-04-01 06:30 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

MagicIssetTest A
last analyzed 2020-04-01 06:30 UTC