PSR7CsrfTest\HttpMethod\IsSafeHttpRequestTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	137
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testSafeMethods()	0	9	1
A	httpMethodsProvider()	0	35	1
A	testSafeMethodsWithDefaults()	0	9	1
B	safeDefaultsMatchingProvider()	0	65	1

<?php

declare(strict_types=1);

namespace PSR7CsrfTest\HttpMethod;

use PHPUnit\Framework\TestCase;
use Psr\Http\Message\RequestInterface;
use PSR7Csrf\HttpMethod\IsSafeHttpRequest;

/**
 * @covers \PSR7Csrf\HttpMethod\IsSafeHttpRequest
 */
final class IsSafeHttpRequestTest extends TestCase
{
    /**
     * @dataProvider httpMethodsProvider
     *
     * @param array  $safeMethods
     * @param string $httpMethod
     * @param bool   $expectedResult
     */
    public function testSafeMethods(array $safeMethods, string $httpMethod, bool $expectedResult)
    {
        /* @var $request RequestInterface|\PHPUnit_Framework_MockObject_MockObject */
        $request = $this->createMock(RequestInterface::class);

        $request->expects(self::any())->method('getMethod')->willReturn($httpMethod);

        self::assertSame($expectedResult, (new IsSafeHttpRequest(...$safeMethods))->__invoke($request));

It seems like $request defined by $this->createMock(\Psr\Http\Message\RequestInterface::class) on line 26 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, PSR7Csrf\HttpMethod\IsSafeHttpRequest::__invoke() does only seem to accept object<Psr\Http\Message\RequestInterface>, maybe add an additional type check?

    }

    public function httpMethodsProvider() : array
    {
        return [
            'empty' => [
                [],
                'GET',
                false,
            ],
            'GET only' => [
                ['GET'],
                'GET',
                true,
            ],
            'get only' => [
                ['get'],
                'GET',
                true,
            ],
            'GET only, matching lowercase get' => [
                ['GET'],
                'get',
                true,
            ],
            'GET only, non-matching method' => [
                ['GET'],
                'PUT',
                false,
            ],
            'GET, PUT only, matching method' => [
                ['GET', 'PUT'],
                'PUT',
                true,
            ],
        ];
    }

    /**
     * @dataProvider safeDefaultsMatchingProvider
     *
     * @param string $httpMethod
     * @param bool   $expectedResult
     */
    public function testSafeMethodsWithDefaults(string $httpMethod, bool $expectedResult)
    {
        /* @var $request RequestInterface|\PHPUnit_Framework_MockObject_MockObject */
        $request = $this->createMock(RequestInterface::class);

        $request->expects(self::any())->method('getMethod')->willReturn($httpMethod);

        self::assertSame($expectedResult, IsSafeHttpRequest::fromDefaultSafeMethods()->__invoke($request));
    }

    public function safeDefaultsMatchingProvider() : array
    {
        return [
            'empty' => [
                '',
                false,
            ],
            'GET' => [
                'GET',
                true,
            ],
            'get' => [
                'get',
                true,
            ],
            'HEAD' => [
                'HEAD',
                true,
            ],
            'head' => [
                'head',
                true,
            ],
            'OPTIONS' => [
                'OPTIONS',
                true,
            ],
            'options' => [
                'options',
                true,
            ],
            'DELETE' => [
                'DELETE',
                false,
            ],
            'delete' => [
                'delete',
                false,
            ],
            'POST' => [
                'POST',
                false,
            ],
            'post' => [
                'post',
                false,
            ],
            'PUT' => [
                'PUT',
                false,
            ],
            'put' => [
                'put',
                false,
            ],
            'UNKNOWN' => [
                'UNKNOWN',
                false,
            ],
            'unknown' => [
                'unknown',
                false,
            ],
        ];
    }
}