ExtractUniqueKeyFromSessionTest - Code Metrics - Ocramius/PSR7Csrf - Measure and Improve Code Quality continuously with Scrutinizer

ExtractUniqueKeyFromSessionTest A
last analyzed 2018-08-11 09:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	0
loc	97
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	testExtractionWithExistingKey()	11	1
A	testExtractionWithEmptyExistingKey()	28	1
A	testExtractionWithNonStringExistingKey()	28	1
A	keysProvider()	9	1

<?php

declare(strict_types=1);

namespace PSR7CsrfTest\HttpMethod;

use PHPUnit\Framework\TestCase;
use PSR7Csrf\Session\ExtractUniqueKeyFromSession;
use PSR7Sessions\Storageless\Session\SessionInterface;

/**
 * @covers \PSR7Csrf\Session\ExtractUniqueKeyFromSession
 */
final class ExtractUniqueKeyFromSessionTest extends TestCase
{
    /**
     * @dataProvider keysProvider
     *
     * @param string $key
     */
    public function testExtractionWithExistingKey(string $key)
    {
        /* @var $session SessionInterface|\PHPUnit_Framework_MockObject_MockObject */
        $session     = $this->createMock(SessionInterface::class);
        $superSecret = uniqid('', true);

        $session->expects(self::any())->method('get')->with($key, '')->willReturn($superSecret);
        $session->expects(self::never())->method('set');

        self::assertSame($superSecret, (new ExtractUniqueKeyFromSession($key))->__invoke($session));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @dataProvider keysProvider
     *
     * @param string $key
     */
    public function testExtractionWithEmptyExistingKey(string $key)
    {
        $extractKey = new ExtractUniqueKeyFromSession($key);

        /* @var $session SessionInterface|\PHPUnit_Framework_MockObject_MockObject */
        $session = $this->createMock(SessionInterface::class);

        $session->expects(self::any())->method('get')->with($key, '')->willReturn('');
        $session->expects(self::exactly(2))->method('set')->with(
            $key,
            self::callback(function (string $secret) {
                self::assertNotEmpty($secret);

                return true;
            })
        );

        $secretUniqueKey = $extractKey->__invoke($session);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertInternalType('string', $secretUniqueKey);
        self::assertNotEmpty($secretUniqueKey);

        $anotherSecretKey = $extractKey->__invoke($session);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertInternalType('string', $anotherSecretKey);
        self::assertNotEmpty($anotherSecretKey);
        self::assertNotEquals($secretUniqueKey, $anotherSecretKey);
    }

    /**
     * @dataProvider keysProvider
     *
     * @param string $key
     */
    public function testExtractionWithNonStringExistingKey(string $key)
    {
        $extractKey = new ExtractUniqueKeyFromSession($key);

        /* @var $session SessionInterface|\PHPUnit_Framework_MockObject_MockObject */
        $session = $this->createMock(SessionInterface::class);

        $session->expects(self::any())->method('get')->with($key, '')->willReturn(123);
        $session->expects(self::exactly(2))->method('set')->with(
            $key,
            self::callback(function (string $secret) {
                self::assertNotEmpty($secret);

                return true;
            })
        );

        $secretUniqueKey = $extractKey->__invoke($session);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertInternalType('string', $secretUniqueKey);
        self::assertNotEmpty($secretUniqueKey);

        $anotherSecretKey = $extractKey->__invoke($session);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        self::assertInternalType('string', $anotherSecretKey);
        self::assertNotEmpty($anotherSecretKey);
        self::assertNotEquals($secretUniqueKey, $anotherSecretKey);
    }

    public function keysProvider() : array
    {
        return [
            [''],
            ['key'],
            ['123'],
            ['123 456'],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace PSR7CsrfTest\HttpMethod;
6
7			use PHPUnit\Framework\TestCase;
8			use PSR7Csrf\Session\ExtractUniqueKeyFromSession;
9			use PSR7Sessions\Storageless\Session\SessionInterface;
10
11			/**
12			* @covers \PSR7Csrf\Session\ExtractUniqueKeyFromSession
13			*/
14			final class ExtractUniqueKeyFromSessionTest extends TestCase
15			{
16			/**
17			* @dataProvider keysProvider
18			*
19			* @param string $key
20			*/
21			public function testExtractionWithExistingKey(string $key)
22			{
23			/* @var $session SessionInterface\|\PHPUnit_Framework_MockObject_MockObject */
24			$session = $this->createMock(SessionInterface::class);
25			$superSecret = uniqid('', true);
26
27			$session->expects(self::any())->method('get')->with($key, '')->willReturn($superSecret);
28			$session->expects(self::never())->method('set');
29
30			self::assertSame($superSecret, (new ExtractUniqueKeyFromSession($key))->__invoke($session));
			0 ignored issues – show Bug introduced 2018-01-28 08:51 UTC by Report Bug Copy Issue Report It seems like `$session` defined by `$this->createMock(\PSR7S...essionInterface::class)` on line `24` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `PSR7Csrf\Session\Extract...FromSession::__invoke()` does only seem to accept `object<PSR7Sessions\Stor...ssion\SessionInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
31			}
32
33			/**
34			* @dataProvider keysProvider
35			*
36			* @param string $key
37			*/
38			public function testExtractionWithEmptyExistingKey(string $key)
39			{
40			$extractKey = new ExtractUniqueKeyFromSession($key);
41
42			/* @var $session SessionInterface\|\PHPUnit_Framework_MockObject_MockObject */
43			$session = $this->createMock(SessionInterface::class);
44
45			$session->expects(self::any())->method('get')->with($key, '')->willReturn('');
46			$session->expects(self::exactly(2))->method('set')->with(
47			$key,
48			self::callback(function (string $secret) {
49			self::assertNotEmpty($secret);
50
51			return true;
52			})
53			);
54
55			$secretUniqueKey = $extractKey->__invoke($session);
			0 ignored issues – show Bug introduced 2018-01-28 08:51 UTC by Report Bug Copy Issue Report It seems like `$session` defined by `$this->createMock(\PSR7S...essionInterface::class)` on line `43` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `PSR7Csrf\Session\Extract...FromSession::__invoke()` does only seem to accept `object<PSR7Sessions\Stor...ssion\SessionInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
56
57			self::assertInternalType('string', $secretUniqueKey);
58			self::assertNotEmpty($secretUniqueKey);
59
60			$anotherSecretKey = $extractKey->__invoke($session);
			0 ignored issues – show Bug introduced 2018-01-28 08:51 UTC by Report Bug Copy Issue Report It seems like `$session` defined by `$this->createMock(\PSR7S...essionInterface::class)` on line `43` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `PSR7Csrf\Session\Extract...FromSession::__invoke()` does only seem to accept `object<PSR7Sessions\Stor...ssion\SessionInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
61
62			self::assertInternalType('string', $anotherSecretKey);
63			self::assertNotEmpty($anotherSecretKey);
64			self::assertNotEquals($secretUniqueKey, $anotherSecretKey);
65			}
66
67			/**
68			* @dataProvider keysProvider
69			*
70			* @param string $key
71			*/
72			public function testExtractionWithNonStringExistingKey(string $key)
73			{
74			$extractKey = new ExtractUniqueKeyFromSession($key);
75
76			/* @var $session SessionInterface\|\PHPUnit_Framework_MockObject_MockObject */
77			$session = $this->createMock(SessionInterface::class);
78
79			$session->expects(self::any())->method('get')->with($key, '')->willReturn(123);
80			$session->expects(self::exactly(2))->method('set')->with(
81			$key,
82			self::callback(function (string $secret) {
83			self::assertNotEmpty($secret);
84
85			return true;
86			})
87			);
88
89			$secretUniqueKey = $extractKey->__invoke($session);
			0 ignored issues – show Bug introduced 2018-01-28 08:51 UTC by Report Bug Copy Issue Report It seems like `$session` defined by `$this->createMock(\PSR7S...essionInterface::class)` on line `77` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `PSR7Csrf\Session\Extract...FromSession::__invoke()` does only seem to accept `object<PSR7Sessions\Stor...ssion\SessionInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
90
91			self::assertInternalType('string', $secretUniqueKey);
92			self::assertNotEmpty($secretUniqueKey);
93
94			$anotherSecretKey = $extractKey->__invoke($session);
			0 ignored issues – show Bug introduced 2018-01-28 08:51 UTC by Report Bug Copy Issue Report It seems like `$session` defined by `$this->createMock(\PSR7S...essionInterface::class)` on line `77` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `PSR7Csrf\Session\Extract...FromSession::__invoke()` does only seem to accept `object<PSR7Sessions\Stor...ssion\SessionInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
95
96			self::assertInternalType('string', $anotherSecretKey);
97			self::assertNotEmpty($anotherSecretKey);
98			self::assertNotEquals($secretUniqueKey, $anotherSecretKey);
99			}
100
101			public function keysProvider() : array
102			{
103			return [
104			[''],
105			['key'],
106			['123'],
107			['123 456'],
108			];
109			}
110			}
111

Ocramius / PSR7Csrf

ExtractUniqueKeyFromSessionTest A last analyzed 2018-08-11 09:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

ExtractUniqueKeyFromSessionTest A
last analyzed 2018-08-11 09:42 UTC