Issues in ClassWithPrivatePropertiesAndParent.php - All Issues - Inspection of "Merge pull request #73 from Ocramius/enhancement/u..." - Ocramius/GeneratedHydrator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2bbfc9...9b6b62 )

by Marco

created 2017-11-28 20:58 UTC

ClassWithPrivatePropertiesAndParent.php (2 issues)

Labels

Comprehensibility 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace GeneratedHydratorTestAsset;

/**
 * Base test class to play around with parent class private properties
 *
 * @author Marco Pivetta <[email protected]>
 * @author Pierre Rineau <[email protected]>
 * @license MIT
 */
class ClassWithPrivatePropertiesAndParent extends ClassWithPrivateProperties
{
    private $property0 = 'property0_fromChild';


    private $property1 = 'property1_fromChild';


    private $property20 = 'property20';

    protected $property21 = 'property21';

    public $property22 = 'property22';

    /**
     * @param string $property0
     */
    public function setProperty0($property0)
    {
        $this->property0 = $property0;
    }

    /**
     * @return string
     */
    public function getProperty0()
    {
        return $this->property0;
    }

    /**
     * @param string $property1
     */
    public function setProperty1($property1)
    {
        $this->property1 = $property1;
    }

    /**
     * @return string
     */
    public function getProperty1()
    {
        return $this->property1;
    }

    /**
     * @param string $property20
     */
    public function setProperty20($property20)
    {
        $this->property20 = $property20;
    }

    /**
     * @return string
     */
    public function getProperty20()
    {
        return $this->property20;
    }

    /**
     * @param string $property21
     */
    public function setProperty21($property21)
    {
        $this->property21 = $property21;
    }

    /**
     * @return string
     */
    public function getProperty21()
    {
        return $this->property21;
    }

    /**
     * @param string $property22
     */
    public function setProperty22($property22)
    {
        $this->property22 = $property22;
    }

    /**
     * @return string
     */
    public function getProperty22()
    {
        return $this->property22;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace GeneratedHydratorTestAsset;
6
7			/**
8			* Base test class to play around with parent class private properties
9			*
10			* @author Marco Pivetta <[email protected]>
11			* @author Pierre Rineau <[email protected]>
12			* @license MIT
13			*/
14			class ClassWithPrivatePropertiesAndParent extends ClassWithPrivateProperties
15			{
16			private $property0 = 'property0_fromChild';
			0 ignored issues – show Comprehensibility introduced 2017-01-11 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
17
18			private $property1 = 'property1_fromChild';
			0 ignored issues – show Comprehensibility introduced 2017-01-11 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
19
20			private $property20 = 'property20';
21
22			protected $property21 = 'property21';
23
24			public $property22 = 'property22';
25
26			/**
27			* @param string $property0
28			*/
29			public function setProperty0($property0)
30			{
31			$this->property0 = $property0;
32			}
33
34			/**
35			* @return string
36			*/
37			public function getProperty0()
38			{
39			return $this->property0;
40			}
41
42			/**
43			* @param string $property1
44			*/
45			public function setProperty1($property1)
46			{
47			$this->property1 = $property1;
48			}
49
50			/**
51			* @return string
52			*/
53			public function getProperty1()
54			{
55			return $this->property1;
56			}
57
58			/**
59			* @param string $property20
60			*/
61			public function setProperty20($property20)
62			{
63			$this->property20 = $property20;
64			}
65
66			/**
67			* @return string
68			*/
69			public function getProperty20()
70			{
71			return $this->property20;
72			}
73
74			/**
75			* @param string $property21
76			*/
77			public function setProperty21($property21)
78			{
79			$this->property21 = $property21;
80			}
81
82			/**
83			* @return string
84			*/
85			public function getProperty21()
86			{
87			return $this->property21;
88			}
89
90			/**
91			* @param string $property22
92			*/
93			public function setProperty22($property22)
94			{
95			$this->property22 = $property22;
96			}
97
98			/**
99			* @return string
100			*/
101			public function getProperty22()
102			{
103			return $this->property22;
104			}
105			}
106

Ocramius / GeneratedHydrator

Push — master ( 2bbfc9...9b6b62 )

ClassWithPrivatePropertiesAndParent.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like