| Conditions | 1 |
| Paths | 1 |
| Total Lines | 88 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 38 | public function pathsProvider() : array |
||
| 39 | { |
||
| 40 | return [ |
||
| 41 | [ |
||
| 42 | [__DIR__ . '/../../../src'], |
||
| 43 | '', |
||
| 44 | 0, |
||
| 45 | ], |
||
| 46 | [ |
||
| 47 | [__DIR__ . '/../../FinalizerTestAsset'], |
||
| 48 | <<<'OUTPUT' |
||
| 49 | Following classes need to be made final: |
||
| 50 | +--------------------------------------------------------------+ |
||
| 51 | | FinalizerTestAsset\Finalizable\ClassWithConstructor | |
||
| 52 | | FinalizerTestAsset\Finalizable\ClassWithNoMethods | |
||
| 53 | | FinalizerTestAsset\Finalizable\ClassWithPrivateMethod | |
||
| 54 | | FinalizerTestAsset\Finalizable\ClassWithProtectedMethod | |
||
| 55 | | FinalizerTestAsset\Finalizable\EmptyChildClass | |
||
| 56 | | FinalizerTestAsset\Finalizable\FooBarConstructorMethodClass | |
||
| 57 | | FinalizerTestAsset\Finalizable\FooBarMethodClass | |
||
| 58 | | FinalizerTestAsset\Finalizable\FooMethodClass | |
||
| 59 | | FinalizerTestAsset\Finalizable\InvokableClass | |
||
| 60 | | FinalizerTestAsset\Finalizable\InvokableClassWithConstructor | |
||
| 61 | +--------------------------------------------------------------+ |
||
| 62 | Following classes are final and need to be made extensible again: |
||
| 63 | +-----------------------------------------------------------+ |
||
| 64 | | FinalizerTestAsset\InvalidFinal\ClassThatShouldNotBeFinal | |
||
| 65 | +-----------------------------------------------------------+ |
||
| 66 | |||
| 67 | OUTPUT |
||
| 68 | , |
||
| 69 | 1 |
||
| 70 | ], |
||
| 71 | [ |
||
| 72 | [__DIR__ . '/../../../src', __DIR__ . '/../../FinalizerTestAsset'], |
||
| 73 | <<<'OUTPUT' |
||
| 74 | Following classes need to be made final: |
||
| 75 | +--------------------------------------------------------------+ |
||
| 76 | | FinalizerTestAsset\Finalizable\ClassWithConstructor | |
||
| 77 | | FinalizerTestAsset\Finalizable\ClassWithNoMethods | |
||
| 78 | | FinalizerTestAsset\Finalizable\ClassWithPrivateMethod | |
||
| 79 | | FinalizerTestAsset\Finalizable\ClassWithProtectedMethod | |
||
| 80 | | FinalizerTestAsset\Finalizable\EmptyChildClass | |
||
| 81 | | FinalizerTestAsset\Finalizable\FooBarConstructorMethodClass | |
||
| 82 | | FinalizerTestAsset\Finalizable\FooBarMethodClass | |
||
| 83 | | FinalizerTestAsset\Finalizable\FooMethodClass | |
||
| 84 | | FinalizerTestAsset\Finalizable\InvokableClass | |
||
| 85 | | FinalizerTestAsset\Finalizable\InvokableClassWithConstructor | |
||
| 86 | +--------------------------------------------------------------+ |
||
| 87 | Following classes are final and need to be made extensible again: |
||
| 88 | +-----------------------------------------------------------+ |
||
| 89 | | FinalizerTestAsset\InvalidFinal\ClassThatShouldNotBeFinal | |
||
| 90 | +-----------------------------------------------------------+ |
||
| 91 | |||
| 92 | OUTPUT |
||
| 93 | , |
||
| 94 | 1 |
||
| 95 | ], |
||
| 96 | [ |
||
| 97 | [ |
||
| 98 | __DIR__ . '/../../FinalizerTestAsset/Finalizable', |
||
| 99 | __DIR__ . '/../../FinalizerTestAsset/InvalidFinal', |
||
| 100 | ], |
||
| 101 | <<<'OUTPUT' |
||
| 102 | Following classes need to be made final: |
||
| 103 | +--------------------------------------------------------------+ |
||
| 104 | | FinalizerTestAsset\Finalizable\ClassWithConstructor | |
||
| 105 | | FinalizerTestAsset\Finalizable\ClassWithNoMethods | |
||
| 106 | | FinalizerTestAsset\Finalizable\ClassWithPrivateMethod | |
||
| 107 | | FinalizerTestAsset\Finalizable\ClassWithProtectedMethod | |
||
| 108 | | FinalizerTestAsset\Finalizable\EmptyChildClass | |
||
| 109 | | FinalizerTestAsset\Finalizable\FooBarConstructorMethodClass | |
||
| 110 | | FinalizerTestAsset\Finalizable\FooBarMethodClass | |
||
| 111 | | FinalizerTestAsset\Finalizable\FooMethodClass | |
||
| 112 | | FinalizerTestAsset\Finalizable\InvokableClass | |
||
| 113 | | FinalizerTestAsset\Finalizable\InvokableClassWithConstructor | |
||
| 114 | +--------------------------------------------------------------+ |
||
| 115 | Following classes are final and need to be made extensible again: |
||
| 116 | +-----------------------------------------------------------+ |
||
| 117 | | FinalizerTestAsset\InvalidFinal\ClassThatShouldNotBeFinal | |
||
| 118 | +-----------------------------------------------------------+ |
||
| 119 | |||
| 120 | OUTPUT |
||
| 121 | , |
||
| 122 | 1 |
||
| 123 | ], |
||
| 124 | ]; |
||
| 125 | } |
||
| 126 | } |
||
| 127 |