$items was never initialized. Although not strictly required by PHP, it is generally a good practice to add $items = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.
Let’s take a look at an example:
foreach($collectionas$item){$myArray['foo']=$item->getFoo();if($item->hasBar()){$myArray['bar']=$item->getBar();}// do something with $myArray}
As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.
This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray=array() either outside or inside the foreach loop.
Loading history...
21
'aliases' => ['cmt'],
22
'description' => 'Show the content moderation as a table.',
23
];
24
25
$items['como-graphviz'] = [
26
'aliases' => ['cmg'],
27
'description' => 'Show the content moderation as a Graphviz DOT file.',
28
'arguments' => [
29
'workflow' => 'The machine name of a workflow',
30
]
31
];
32
33
$items['qa-workflows-list'] = [
34
'aliases' => ['qawl'],
35
'description' => 'Show a summary of available workflows',
36
];
37
38
$items['qa-dependencies'] = [
39
'description' => 'Build a Graphviz DOT file showing the module and theme dependencies on the site',
40
'aliases' => ['qadep'],
41
];
42
43
$items['qa-force-removed'] = [
44
'description' => 'List extensions removed without a clean uninstall.',
OSInet /
qa
Frederic G. MARAND
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.