qa.drush.inc::qa_drush_command() - Code Metrics - Inspection of "Added qafrm command." - OSInet/qa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.x-1.x ( 32ffa2...019f08 )

by Frédéric G.

created 2018-01-20 09:17 UTC

qa.drush.inc::qa_drush_command() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	0
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * @file
 * Drush plugin.
 */

use OSInet\DrupalQA\ForceRemoved;

/**
 * Implementation of hook_drush_command().
 */
function qa_drush_command() {
  $items['qa-dependencies'] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    'description' => 'Build a Graphviz DOT file showing the module and theme dependencies on the site',
    'aliases' => ['qadep'],
  ];

  $items['qa-force-removed'] = [
    'description' => 'List extensions removed without a clean uninstall.',
    'aliases' => ['qafrm'],
  ];
  return $items;
}

function drush_qa_dependencies() {
  module_load_include('inc', 'qa', 'qa_dependencies');
  $G = qa_dependencies();
  echo $G->parse();
}

function drush_qa_force_removed() {
  $finder = ForceRemoved::create();
  echo $finder->find();
}

1			<?php
2
3			/**
4			* @file
5			* Drush plugin.
6			*/
7
8			use OSInet\DrupalQA\ForceRemoved;
9
10			/**
11			* Implementation of hook_drush_command().
12			*/
13			function qa_drush_command() {
14			$items['qa-dependencies'] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-20 09:18 UTC by Report Bug Copy Issue Report `$items` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$items = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
15			'description' => 'Build a Graphviz DOT file showing the module and theme dependencies on the site',
16			'aliases' => ['qadep'],
17			];
18
19			$items['qa-force-removed'] = [
20			'description' => 'List extensions removed without a clean uninstall.',
21			'aliases' => ['qafrm'],
22			];
23			return $items;
24			}
25
26			function drush_qa_dependencies() {
27			module_load_include('inc', 'qa', 'qa_dependencies');
28			$G = qa_dependencies();
29			echo $G->parse();
30			}
31
32			function drush_qa_force_removed() {
33			$finder = ForceRemoved::create();
34			echo $finder->find();
35			}

OSInet / qa

Push — 7.x-1.x ( 32ffa2...019f08 )

qa.drush.inc::qa_drush_command() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like