qa.drush.inc::qa_drush_command() - Code Metrics - Inspection of "Working admin/reports/qa/workflows and drush qawl." - OSInet/qa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.x-1.x ( 3c8412...894b5c )

by Frédéric G.

created 2017-02-15 18:48 UTC

qa.drush.inc::qa_drush_command() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	13
nc	1
nop	0
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0

<?php

use Drupal\qa\Controller\WorkflowsReportController;
use Drupal\qa\Workflows\ContentModerationGraph;
use Drupal\qa\Workflows\ContentModerationGrid;
use Drupal\qa\Workflows\WorkflowList;
use Symfony\Component\Yaml\Yaml;

function qa_drush_command() {
  $items['como-table'] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    'aliases' => ['cmt'],
    'description' => 'Show the content moderation as a table.',
  ];

  $items['como-graphviz'] = [
    'aliases' => ['cmg'],
    'description' => 'Show the content moderation as a Graphviz DOT file.',
    'arguments' => [
      'workflow' => 'The machine name of a workflow',
    ]
  ];

  $items['qa-workflows-list'] = [
    'aliases' => ['qawl'],
    'description' => 'Show a summary of available workflows',
  ];

  return $items;
}

function drush_qa_como_graphviz() {
  $graph = ContentModerationGraph::create(\Drupal::getContainer());
  echo $graph->report();
}

/**
 * Command callback for qa-workflows-list.
 */
function drush_qa_workflows_list() {
  $listBuilder = WorkflowsReportController::create(Drupal::getContainer());
  $list = $listBuilder->getWorkflowSummary(
    $listBuilder->storage->loadMultiple()
  );
  drush_print(Yaml::dump($list));
}

function drush_qa_como_table() {
  $table = ContentModerationGrid::create(\Drupal::getContainer());
  $table->report();
}



1			<?php
2
3			use Drupal\qa\Controller\WorkflowsReportController;
4			use Drupal\qa\Workflows\ContentModerationGraph;
5			use Drupal\qa\Workflows\ContentModerationGrid;
6			use Drupal\qa\Workflows\WorkflowList;
7			use Symfony\Component\Yaml\Yaml;
8
9			function qa_drush_command() {
10			$items['como-table'] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-15 18:50 UTC by Report Bug Copy Issue Report `$items` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$items = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
11			'aliases' => ['cmt'],
12			'description' => 'Show the content moderation as a table.',
13			];
14
15			$items['como-graphviz'] = [
16			'aliases' => ['cmg'],
17			'description' => 'Show the content moderation as a Graphviz DOT file.',
18			'arguments' => [
19			'workflow' => 'The machine name of a workflow',
20			]
21			];
22
23			$items['qa-workflows-list'] = [
24			'aliases' => ['qawl'],
25			'description' => 'Show a summary of available workflows',
26			];
27
28			return $items;
29			}
30
31			function drush_qa_como_graphviz() {
32			$graph = ContentModerationGraph::create(\Drupal::getContainer());
33			echo $graph->report();
34			}
35
36			/**
37			* Command callback for qa-workflows-list.
38			*/
39			function drush_qa_workflows_list() {
40			$listBuilder = WorkflowsReportController::create(Drupal::getContainer());
41			$list = $listBuilder->getWorkflowSummary(
42			$listBuilder->storage->loadMultiple()
43			);
44			drush_print(Yaml::dump($list));
45			}
46
47			function drush_qa_como_table() {
48			$table = ContentModerationGrid::create(\Drupal::getContainer());
49			$table->report();
50			}
51
52

OSInet / qa

Push — 8.x-1.x ( 3c8412...894b5c )

qa.drush.inc::qa_drush_command() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like