$items was never initialized. Although not strictly required by PHP, it is generally a good practice to add $items = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.
Let’s take a look at an example:
foreach($collectionas$item){$myArray['foo']=$item->getFoo();if($item->hasBar()){$myArray['bar']=$item->getBar();}// do something with $myArray}
As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.
This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray=array() either outside or inside the foreach loop.
Loading history...
16
'description' => 'Build a Graphviz DOT file showing the module and theme dependencies on the site',
17
'aliases' => ['qadep'],
18
];
19
20
$items['qa-force-removed'] = [
21
'description' => 'List extensions removed without a clean uninstall.',
22
'aliases' => ['qafrm'],
23
];
24
25
$items['qa-project-usage'] = [
26
'description' => 'List usage and components for projects',
27
'options' => [
28
'only-unused' => 'Only include totally unused packages',
OSInet /
qa
Frederic G. MARAND
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.