DomainConverter::fromJson() - Code Metrics - Inspection of "Events restored" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( c24b3a...b512e9 )

by Florent

created 2018-05-24 20:40 UTC

DomainConverter::fromJson() B

↳ Parent: DomainConverter

Complexity

Conditions	6
Paths	12

Size

Total Lines	29
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	8.439
c	0
b	0
f	0
cc	6
eloc	18
nc	12
nop	1

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Component\Core\Domain;

use League\JsonGuard\Validator;
use League\JsonReference\Dereferencer;
use OAuth2Framework\Component\Core\Message\OAuth2Message;
use League\JsonReference\LoaderManager;

class DomainConverter
{
    /**
     * @var Dereferencer
     */
    private $dereferencer;

    /**
     * @var int
     */
    private $options;

    /**
     * DomainConverter constructor.
     *
     * @param DomainUriLoader $domainUriLoader
     */
    public function __construct(DomainUriLoader $domainUriLoader)
    {
        $this->options = JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE;
        $loaderManager = new LoaderManager(['https' => $domainUriLoader]);
        $this->dereferencer = new Dereferencer();
        $this->dereferencer->setLoaderManager($loaderManager);
    }

    /**
     * @param string $jsonData
     *
     * @return DomainObject
     *
     * @throws OAuth2Message
     */
    public function fromJson(string $jsonData): DomainObject
    {
        try {
            $decoded = json_decode($jsonData, false, $this->options);
            if (!$decoded instanceof \stdClass) {
                throw new \RuntimeException('Unable to decode');
            }
            if (!property_exists($decoded, '$schema')) {
                throw new \InvalidArgumentException('The object is not a valid Json object from the domain.');
            }
            $schema = $this->dereferencer->dereference($decoded->{'$schema'});

            $validator = new Validator($decoded, $schema);

            if ($validator->fails()) {
                throw new \InvalidArgumentException('The domain object cannot be verified with the selected schema.');
            }

            $class = $decoded->type;
            if (!class_exists($class)) {
                throw new \InvalidArgumentException(sprintf('Unsupported class "%s"', $class));
            }
            $domainObject = $class::createFromJson($decoded);
        } catch (\Exception $e) {
            throw new OAuth2Message(500, OAuth2Message::ERROR_INTERNAL, 'The server encountered and internal error.', $e);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $domainObject;
    }

    /**
     * @param DomainObject $domainObject
     *
     * @return string
     *
     * @throws OAuth2Message
     */
    public function toJson(DomainObject $domainObject): string
    {
        try {
            $jsonData = (object) $domainObject->jsonSerialize();
            $schema = $this->dereferencer->dereference($jsonData->{'$schema'});

            $validator = new Validator($jsonData, $schema);

            if ($validator->fails()) {
                throw new \InvalidArgumentException('The domain object cannot be verified with the selected schema.');
            }
        } catch (\Exception $e) {
            throw new OAuth2Message(500, OAuth2Message::ERROR_INTERNAL, 'The server encountered and internal error.', $e);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return json_encode($jsonData, $this->options);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2018 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace OAuth2Framework\Component\Core\Domain;
15
16			use League\JsonGuard\Validator;
17			use League\JsonReference\Dereferencer;
18			use OAuth2Framework\Component\Core\Message\OAuth2Message;
19			use League\JsonReference\LoaderManager;
20
21			class DomainConverter
22			{
23			/**
24			* @var Dereferencer
25			*/
26			private $dereferencer;
27
28			/**
29			* @var int
30			*/
31			private $options;
32
33			/**
34			* DomainConverter constructor.
35			*
36			* @param DomainUriLoader $domainUriLoader
37			*/
38			public function __construct(DomainUriLoader $domainUriLoader)
39			{
40			$this->options = JSON_UNESCAPED_SLASHES \| JSON_UNESCAPED_UNICODE;
41			$loaderManager = new LoaderManager(['https' => $domainUriLoader]);
42			$this->dereferencer = new Dereferencer();
43			$this->dereferencer->setLoaderManager($loaderManager);
44			}
45
46			/**
47			* @param string $jsonData
48			*
49			* @return DomainObject
50			*
51			* @throws OAuth2Message
52			*/
53			public function fromJson(string $jsonData): DomainObject
54			{
55			try {
56			$decoded = json_decode($jsonData, false, $this->options);
57			if (!$decoded instanceof \stdClass) {
58			throw new \RuntimeException('Unable to decode');
59			}
60			if (!property_exists($decoded, '$schema')) {
61			throw new \InvalidArgumentException('The object is not a valid Json object from the domain.');
62			}
63			$schema = $this->dereferencer->dereference($decoded->{'$schema'});
64
65			$validator = new Validator($decoded, $schema);
66
67			if ($validator->fails()) {
68			throw new \InvalidArgumentException('The domain object cannot be verified with the selected schema.');
69			}
70
71			$class = $decoded->type;
72			if (!class_exists($class)) {
73			throw new \InvalidArgumentException(sprintf('Unsupported class "%s"', $class));
74			}
75			$domainObject = $class::createFromJson($decoded);
76			} catch (\Exception $e) {
77			throw new OAuth2Message(500, OAuth2Message::ERROR_INTERNAL, 'The server encountered and internal error.', $e);
			0 ignored issues – show Documentation introduced 2018-05-24 20:54 UTC by Report Bug Copy Issue Report `$e` is of type `object<Exception>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
78			}
79
80			return $domainObject;
81			}
82
83			/**
84			* @param DomainObject $domainObject
85			*
86			* @return string
87			*
88			* @throws OAuth2Message
89			*/
90			public function toJson(DomainObject $domainObject): string
91			{
92			try {
93			$jsonData = (object) $domainObject->jsonSerialize();
94			$schema = $this->dereferencer->dereference($jsonData->{'$schema'});
95
96			$validator = new Validator($jsonData, $schema);
97
98			if ($validator->fails()) {
99			throw new \InvalidArgumentException('The domain object cannot be verified with the selected schema.');
100			}
101			} catch (\Exception $e) {
102			throw new OAuth2Message(500, OAuth2Message::ERROR_INTERNAL, 'The server encountered and internal error.', $e);
			0 ignored issues – show Documentation introduced 2018-05-24 20:54 UTC by Report Bug Copy Issue Report `$e` is of type `object<Exception>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
103			}
104
105			return json_encode($jsonData, $this->options);
106			}
107			}
108

OAuth2-Framework / oauth2-framework

Push — master ( c24b3a...b512e9 )

DomainConverter::fromJson() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like