AuthorizationEndpointTest::theRequestIsValidButNoAccountIsSelected() - Code Metrics - Inspection of "WIP" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 7c3864...930f9b )

by Florent

created 2018-10-03 11:43 UTC

theRequestIsValidButNoAccountIsSelected() B

↳ Parent: AuthorizationEndpointTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	60
rs	8.8727
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\ServerBundle\Tests\Functional\Grant\AuthorizationCode;

use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeGrantType;
use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
use OAuth2Framework\ServerBundle\Tests\TestBundle\Entity\User;
use OAuth2Framework\ServerBundle\Tests\TestBundle\Entity\UserAccount;
use Symfony\Bundle\FrameworkBundle\Client;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\BrowserKit\Cookie;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;

/**
 * @group ServerBundle
 * @group Functional
 * @group Grant
 * @group AuthorizationCode
 */
class AuthorizationEndpointTest extends WebTestCase
{
    protected function setUp()
    {
        if (!\class_exists(AuthorizationCodeGrantType::class)) {
            static::markTestSkipped('The component "oauth2-framework/authorization-code-grant" is not installed.');
        }
    }

    /**
     * @test
     */
    public function theRequestIsValidButNoAccountIsSelected()
    {
        $uri = $this->buildUri([
            'client_id' => 'CLIENT_ID_2',
            'redirect_uri' => 'https://example.com/cb/?foo=bar',
            'response_type' => 'code',
        ]);
        $client = static::createClient();
        $this->logIn(
            $client,
            new User(
                'admin',
                ['ROLE_ADMIN', 'ROLE_USER'],
                ['john.1'],
                new \DateTimeImmutable('now -25 hours'),
                new \DateTimeImmutable('now -15 days')
            ),
            new UserAccount(
                new UserAccountId('john.1'),
                [
                    'address', [
                        'street_address' => '5 rue Sainte Anne',
                        'region' => 'Île de France',
                        'postal_code' => '75001',
                        'locality' => 'Paris',
                        'country' => 'France',
                    ],
                    'name' => 'John Doe',
                    'given_name' => 'John',
                    'family_name' => 'Doe',
                    'middle_name' => 'Jack',
                    'nickname' => 'Little John',
                    'profile' => 'https://profile.doe.fr/john/',
                    'preferred_username' => 'j-d',
                    'gender' => 'M',
                    'phone_number' => '+0123456789',
                    'phone_number_verified' => true,
                    'zoneinfo' => 'Europe/Paris',
                    'locale' => 'en',
                    'picture' => 'https://www.google.com',
                    'birthdate' => '1950-01-01',
                    'email' => '[email protected]',
                    'email_verified' => false,
                    'website' => 'https://john.doe.com',
                    'website#fr_fr' => 'https://john.doe.fr',
                    'website#fr' => 'https://john.doe.fr',
                    'picture#de' => 'https://john.doe.de/picture',
                ]
            )
        );
        $client->request('GET', $uri, [], [], ['HTTPS' => 'on'], null);
        $response = $client->getResponse();

        static::assertEquals(303, $response->getStatusCode());
        static::assertTrue($response->headers->has('location'));

        $client->followRedirect();
        $response = $client->getResponse();
        dump($response->headers->get('location'));
    }

    private function buildUri(array $query): string
    {
        $query = http_build_query($query);

        return empty($query) ? '/authorize' : \Safe\sprintf('/authorize?%s', $query);
    }

    private function logIn(Client $client, User $user, ?UserAccount $userAccount): void
    {
        $session = $client->getContainer()->get('session');

        $firewallName = 'main';
        $firewallContext = 'main';

        $token = new UsernamePasswordToken($user, null, $firewallName, ['ROLE_ADMIN']);
        $session->set('_security_'.$firewallContext, serialize($token));
        $session->set('user_account', $userAccount);
        $session->save();

        $cookie = new Cookie($session->getName(), $session->getId());
        $client->getCookieJar()->set($cookie);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2018 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace OAuth2Framework\ServerBundle\Tests\Functional\Grant\AuthorizationCode;
15
16			use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeGrantType;
17			use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
18			use OAuth2Framework\ServerBundle\Tests\TestBundle\Entity\User;
19			use OAuth2Framework\ServerBundle\Tests\TestBundle\Entity\UserAccount;
20			use Symfony\Bundle\FrameworkBundle\Client;
21			use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
22			use Symfony\Component\BrowserKit\Cookie;
23			use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
24
25			/**
26			* @group ServerBundle
27			* @group Functional
28			* @group Grant
29			* @group AuthorizationCode
30			*/
31			class AuthorizationEndpointTest extends WebTestCase
32			{
33			protected function setUp()
34			{
35			if (!\class_exists(AuthorizationCodeGrantType::class)) {
36			static::markTestSkipped('The component "oauth2-framework/authorization-code-grant" is not installed.');
37			}
38			}
39
40			/**
41			* @test
42			*/
43			public function theRequestIsValidButNoAccountIsSelected()
44			{
45			$uri = $this->buildUri([
46			'client_id' => 'CLIENT_ID_2',
47			'redirect_uri' => 'https://example.com/cb/?foo=bar',
48			'response_type' => 'code',
49			]);
50			$client = static::createClient();
51			$this->logIn(
52			$client,
53			new User(
54			'admin',
55			['ROLE_ADMIN', 'ROLE_USER'],
56			['john.1'],
57			new \DateTimeImmutable('now -25 hours'),
58			new \DateTimeImmutable('now -15 days')
59			),
60			new UserAccount(
61			new UserAccountId('john.1'),
62			[
63			'address', [
64			'street_address' => '5 rue Sainte Anne',
65			'region' => 'Île de France',
66			'postal_code' => '75001',
67			'locality' => 'Paris',
68			'country' => 'France',
69			],
70			'name' => 'John Doe',
71			'given_name' => 'John',
72			'family_name' => 'Doe',
73			'middle_name' => 'Jack',
74			'nickname' => 'Little John',
75			'profile' => 'https://profile.doe.fr/john/',
76			'preferred_username' => 'j-d',
77			'gender' => 'M',
78			'phone_number' => '+0123456789',
79			'phone_number_verified' => true,
80			'zoneinfo' => 'Europe/Paris',
81			'locale' => 'en',
82			'picture' => 'https://www.google.com',
83			'birthdate' => '1950-01-01',
84			'email' => '[email protected]',
85			'email_verified' => false,
86			'website' => 'https://john.doe.com',
87			'website#fr_fr' => 'https://john.doe.fr',
88			'website#fr' => 'https://john.doe.fr',
89			'picture#de' => 'https://john.doe.de/picture',
90			]
91			)
92			);
93			$client->request('GET', $uri, [], [], ['HTTPS' => 'on'], null);
94			$response = $client->getResponse();
95
96			static::assertEquals(303, $response->getStatusCode());
97			static::assertTrue($response->headers->has('location'));
98
99			$client->followRedirect();
100			$response = $client->getResponse();
101			dump($response->headers->get('location'));
102			}
103
104			private function buildUri(array $query): string
105			{
106			$query = http_build_query($query);
107
108			return empty($query) ? '/authorize' : \Safe\sprintf('/authorize?%s', $query);
109			}
110
111			private function logIn(Client $client, User $user, ?UserAccount $userAccount): void
112			{
113			$session = $client->getContainer()->get('session');
114
115			$firewallName = 'main';
116			$firewallContext = 'main';
117
118			$token = new UsernamePasswordToken($user, null, $firewallName, ['ROLE_ADMIN']);
119			$session->set('_security_'.$firewallContext, serialize($token));
120			$session->set('user_account', $userAccount);
121			$session->save();
122
123			$cookie = new Cookie($session->getName(), $session->getId());
124			$client->getCookieJar()->set($cookie);
125			}
126			}
127

OAuth2-Framework / oauth2-framework

Push — master ( 7c3864...930f9b )

theRequestIsValidButNoAccountIsSelected() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like