Failed Conditions
Push — master ( 7c3864...930f9b )
by Florent
14:15
created

SelectAccountEndpointController::getRouteFor()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
nc 1
nop 2
1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * The MIT License (MIT)
7
 *
8
 * Copyright (c) 2014-2018 Spomky-Labs
9
 *
10
 * This software may be modified and distributed under the terms
11
 * of the MIT license.  See the LICENSE file for details.
12
 */
13
14
namespace OAuth2Framework\ServerBundle\Controller;
15
16
use Http\Message\ResponseFactory;
17
use OAuth2Framework\Component\AuthorizationEndpoint\SelectAccountEndpoint;
18
use OAuth2Framework\Component\AuthorizationEndpoint\SelectAccountHandler;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, OAuth2Framework\ServerBu...er\SelectAccountHandler.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
19
use Symfony\Component\HttpFoundation\Session\SessionInterface;
20
use Symfony\Component\Routing\RouterInterface;
21
22
final class SelectAccountEndpointController extends SelectAccountEndpoint
23
{
24
    private $router;
25
26
    public function __construct(ResponseFactory $responseFactory, SessionInterface $session, SelectAccountHandler $selectAccountHandler, RouterInterface $router)
27
    {
28
        parent::__construct($responseFactory, $session, $selectAccountHandler);
29
        $this->router = $router;
30
    }
31
32
    protected function getRouteFor(string $action, string $authorizationId): string
33
    {
34
        return $this->router->generate($action, ['authorization_id' => $authorizationId]);
35
    }
36
}
37