PairwiseSubjectSource::continueConfiguration() - Code Metrics - Inspection of "Better OpenID Connect support (#31)" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 8e9cbc...6d4032 )

by Florent

created 2017-04-09 13:52 UTC

PairwiseSubjectSource::continueConfiguration() A

↳ Parent: PairwiseSubjectSource

Complexity

Conditions	2
Paths	1

Size

Total Lines	15
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	12
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2017 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Bundle\Server\DependencyInjection\Source\OpenIdConnect;

use OAuth2Framework\Bundle\Server\DependencyInjection\Source\ActionableSource;
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Component\DependencyInjection\ContainerBuilder;

final class PairwiseSubjectSource extends ActionableSource
{
    /**
     * {@inheritdoc}
     */
    protected function continueLoading(string $path, ContainerBuilder $container, array $config)
    {
        $container->setAlias($path.'.service', $config['service']);
        $container->setParameter($path.'.is_default', $config['is_default']);
    }

    /**
     * {@inheritdoc}
     */
    protected function name(): string
    {
        return 'pairwise_subject';
    }

    /**
     * {@inheritdoc}
     */
    protected function continueConfiguration(NodeDefinition $node)
    {
        parent::continueConfiguration($node);
        $node
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->validate()
                ->ifTrue(function ($config) {
                    return true === $config['enabled'] && empty($config['service']);
                })
                ->thenInvalid('The pairwise subject service must be set.')
            ->end()
            ->children()
                ->scalarNode('service')->end()
                ->booleanNode('is_default')->defaultTrue()->end()
            ->end();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2017 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace OAuth2Framework\Bundle\Server\DependencyInjection\Source\OpenIdConnect;
15
16			use OAuth2Framework\Bundle\Server\DependencyInjection\Source\ActionableSource;
17			use Symfony\Component\Config\Definition\Builder\NodeDefinition;
18			use Symfony\Component\DependencyInjection\ContainerBuilder;
19
20			final class PairwiseSubjectSource extends ActionableSource
21			{
22			/**
23			* {@inheritdoc}
24			*/
25			protected function continueLoading(string $path, ContainerBuilder $container, array $config)
26			{
27			$container->setAlias($path.'.service', $config['service']);
28			$container->setParameter($path.'.is_default', $config['is_default']);
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			protected function name(): string
35			{
36			return 'pairwise_subject';
37			}
38
39			/**
40			* {@inheritdoc}
41			*/
42			protected function continueConfiguration(NodeDefinition $node)
43			{
44			parent::continueConfiguration($node);
45			$node
			0 ignored issues – show Bug introduced 2017-04-09 13:29 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Config...\Builder\NodeDefinition` as the method `children()` does only exist in the following sub-classes of `Symfony\Component\Config...\Builder\NodeDefinition`: `Symfony\Component\Config...der\ArrayNodeDefinition`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
46			->validate()
47			->ifTrue(function ($config) {
48			return true === $config['enabled'] && empty($config['service']);
49			})
50			->thenInvalid('The pairwise subject service must be set.')
51			->end()
52			->children()
53			->scalarNode('service')->end()
54			->booleanNode('is_default')->defaultTrue()->end()
55			->end();
56			}
57			}
58

OAuth2-Framework / oauth2-framework

Push — master ( 8e9cbc...6d4032 )

PairwiseSubjectSource::continueConfiguration() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like