Failed Conditions
Push — ng ( ca946d...fcb055 )
by Florent
10:43
created

ClientAuthenticationSource   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 73
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 9

Importance

Changes 0
Metric Value
wmc 8
lcom 1
cbo 9
dl 0
loc 73
rs 10
c 0
b 0
f 0

5 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 9 1
A name() 0 4 1
A load() 0 11 2
A getNodeDefinition() 0 10 2
A prepend() 0 12 2
1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * The MIT License (MIT)
7
 *
8
 * Copyright (c) 2014-2018 Spomky-Labs
9
 *
10
 * This software may be modified and distributed under the terms
11
 * of the MIT license.  See the LICENSE file for details.
12
 */
13
14
namespace OAuth2Framework\Bundle\DependencyInjection\Component\ClientAuthentication;
15
16
use OAuth2Framework\Bundle\DependencyInjection\Component\Component;
17
use OAuth2Framework\Component\TokenEndpoint\AuthenticationMethod\AuthenticationMethod;
18
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
19
use Symfony\Component\Config\FileLocator;
20
use Symfony\Component\DependencyInjection\ContainerBuilder;
21
use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
22
23
class ClientAuthenticationSource implements Component
24
{
25
    /**
26
     * @var Component[]
27
     */
28
    private $subComponents = [];
29
30
    /**
31
     * EndpointSource constructor.
32
     */
33
    public function __construct()
34
    {
35
        $this->subComponents = [
36
            new NoneSource(),
37
            new ClientSecretBasicSource(),
38
            new ClientSecretPostSource(),
39
            new ClientAssertionJwtSource(),
40
        ];
41
    }
42
43
    /**
44
     * @return string
45
     */
46
    public function name(): string
47
    {
48
        return 'client_authentication';
49
    }
50
51
    /**
52
     * {@inheritdoc}
53
     */
54
    public function load(array $configs, ContainerBuilder $container)
55
    {
56
        $container->registerForAutoconfiguration(AuthenticationMethod::class)->addTag('oauth2_server_client_authentication');
57
58
        $loader = new PhpFileLoader($container, new FileLocator(__DIR__ . '/../../../Resources/config/client_authentication'));
59
        $loader->load('client_authentication.php');
60
61
        foreach ($this->subComponents as $subComponent) {
62
            $subComponent->load($configs, $container);
63
        }
64
    }
65
66
    /**
67
     * {@inheritdoc}
68
     */
69
    public function getNodeDefinition(NodeDefinition $node)
70
    {
71
        $childNode = $node->children()
0 ignored issues
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Symfony\Component\Config...\Builder\NodeDefinition as the method children() does only exist in the following sub-classes of Symfony\Component\Config...\Builder\NodeDefinition: Symfony\Component\Config...der\ArrayNodeDefinition. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
72
            ->arrayNode($this->name())
73
            ->addDefaultsIfNotSet();
74
75
        foreach ($this->subComponents as $subComponent) {
76
            $subComponent->getNodeDefinition($childNode);
77
        }
78
    }
79
80
    /**
81
     * {@inheritdoc}
82
     */
83
    public function prepend(ContainerBuilder $container, array $config): array
84
    {
85
        $updatedConfig = [];
86
        foreach ($this->subComponents as $subComponent) {
87
            $updatedConfig = array_merge(
88
                $updatedConfig,
89
                $subComponent->prepend($container, $config)
90
            );
91
        }
92
93
        return $updatedConfig;
94
    }
95
}
96