AuthenticationMethodReference::isAvailableForUserAccount() - Code Metrics - Inspection of "Userinfo Endpoint" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 1312dd...bb342a )

by Florent

created 2018-06-11 21:41 UTC

isAvailableForUserAccount() A

↳ Parent: AuthenticationMethodReference

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
c	0
b	0
f	0
rs	9.4285
cc	3
eloc	4
nc	2
nop	2

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Component\OpenIdConnect\UserInfo\Claim;

use OAuth2Framework\Component\Core\UserAccount\AuthenticationMethodReferenceSupport;
use OAuth2Framework\Component\Core\UserAccount\UserAccount;
use OAuth2Framework\Component\Core\UserAccount\UserAccountManager;

final class AuthenticationMethodReference implements Claim
{
    private const CLAIM_NAME = 'amr';

    /**
     * @var UserAccountManager|AuthenticationMethodReferenceSupport
     */
    private $userAccountManager;

    public function __construct(UserAccountManager $userAccountManager)
    {
        $this->userAccountManager = $userAccountManager;
    }

    /**
     * {@inheritdoc}
     */
    public function name(): string
    {
        return self::CLAIM_NAME;
    }

    /**
     * {@inheritdoc}
     */
    public function isAvailableForUserAccount(UserAccount $userAccount, ?string $claimLocale): bool
    {
        if (null === $this->userAccountManager || !$this->userAccountManager instanceof AuthenticationMethodReferenceSupport) {
            return false;
        }

        return null !== $this->userAccountManager->getAuthenticationMethodReferenceFor($userAccount);
    }

    /**
     * {@inheritdoc}
     */
    public function getForUserAccount(UserAccount $userAccount, ?string $claimLocale)
    {
        return $this->userAccountManager->getAuthenticationMethodReferenceFor($userAccount);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2018 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace OAuth2Framework\Component\OpenIdConnect\UserInfo\Claim;
15
16			use OAuth2Framework\Component\Core\UserAccount\AuthenticationMethodReferenceSupport;
17			use OAuth2Framework\Component\Core\UserAccount\UserAccount;
18			use OAuth2Framework\Component\Core\UserAccount\UserAccountManager;
19
20			final class AuthenticationMethodReference implements Claim
21			{
22			private const CLAIM_NAME = 'amr';
23
24			/**
25			* @var UserAccountManager\|AuthenticationMethodReferenceSupport
26			*/
27			private $userAccountManager;
28
29			public function __construct(UserAccountManager $userAccountManager)
30			{
31			$this->userAccountManager = $userAccountManager;
32			}
33
34			/**
35			* {@inheritdoc}
36			*/
37			public function name(): string
38			{
39			return self::CLAIM_NAME;
40			}
41
42			/**
43			* {@inheritdoc}
44			*/
45			public function isAvailableForUserAccount(UserAccount $userAccount, ?string $claimLocale): bool
46			{
47			if (null === $this->userAccountManager \|\| !$this->userAccountManager instanceof AuthenticationMethodReferenceSupport) {
48			return false;
49			}
50
51			return null !== $this->userAccountManager->getAuthenticationMethodReferenceFor($userAccount);
52			}
53
54			/**
55			* {@inheritdoc}
56			*/
57			public function getForUserAccount(UserAccount $userAccount, ?string $claimLocale)
58			{
59			return $this->userAccountManager->getAuthenticationMethodReferenceFor($userAccount);
			0 ignored issues – show Bug introduced 2018-06-11 21:46 UTC by Report Bug Copy Issue Report The method `getAuthenticationMethodReferenceFor` does only exist in `OAuth2Framework\Componen...nMethodReferenceSupport`, but not in `OAuth2Framework\Componen...ount\UserAccountManager`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
60			}
61			}
62

OAuth2-Framework / oauth2-framework

Push — master ( 1312dd...bb342a )

isAvailableForUserAccount() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like