Inspection of "Bug fixed" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( aea50b...4aa0c5 )

by Florent

created 2018-05-22 11:02 UTC

Status

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -14,25 +14,25 @@
 block discarded – undo
 namespace OAuth2Framework\Component\TokenEndpoint\Tests;
 
 use Http\Message\MessageFactory\GuzzleMessageFactory;
+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenId;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
-use Psr\Http\Server\RequestHandlerInterface;
-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Client\ClientId;
 use OAuth2Framework\Component\Core\Client\ClientRepository;
 use OAuth2Framework\Component\Core\DataBag\DataBag;
-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
+use OAuth2Framework\Component\Core\TokenType\TokenType;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
 use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
 use OAuth2Framework\Component\TokenEndpoint\TokenEndpoint;
-use OAuth2Framework\Component\Core\TokenType\TokenType;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Server\RequestHandlerInterface;
 
 /**
  * @group TokenEndpoint

Please login to merge, or discard this patch.

src/Component/TokenEndpoint/TokenEndpoint.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -14,23 +14,23 @@
 block discarded – undo
 namespace OAuth2Framework\Component\TokenEndpoint;
 
 use Http\Message\ResponseFactory;
+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
-use Psr\Http\Server\RequestHandlerInterface;
-use Psr\Http\Server\MiddlewareInterface;
-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Client\ClientId;
 use OAuth2Framework\Component\Core\Client\ClientRepository;
-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
+use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
+use OAuth2Framework\Component\Core\TokenType\TokenType;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
-use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
-use OAuth2Framework\Component\Core\TokenType\TokenType;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Server\MiddlewareInterface;
+use Psr\Http\Server\RequestHandlerInterface;
 
 class TokenEndpoint implements MiddlewareInterface
 {

Please login to merge, or discard this patch.

src/ServerBundle/Form/Handler/AuthorizationFormHandler.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,9 +13,9 @@
 block discarded – undo
 
 namespace OAuth2Framework\ServerBundle\Form\Handler;
 
-use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
 use OAuth2Framework\Component\AuthorizationEndpoint\Authorization;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
 use Psr\Http\Message\ServerRequestInterface;
 use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;
 use Symfony\Component\Form\ClickableInterface;

Please login to merge, or discard this patch.

src/Component/AuthorizationCodeGrant/AuthorizationCodeGrantType.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -14,10 +14,10 @@
 block discarded – undo
 namespace OAuth2Framework\Component\AuthorizationCodeGrant;
 
 use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\PKCEMethodManager;
-use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\TokenEndpoint\GrantType;
+use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use Psr\Http\Message\ServerRequestInterface;
 
 final class AuthorizationCodeGrantType implements GrantType

Please login to merge, or discard this patch.

src/Component/Scope/TokenEndpointScopeExtension.php 1 patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -15,12 +15,12 @@
 block discarded – undo
 
 use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\Client\Client;
+use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
+use OAuth2Framework\Component\Scope\Policy\ScopePolicyManager;
 use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtension;
-use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use OAuth2Framework\Component\TokenEndpoint\GrantType;
-use OAuth2Framework\Component\Scope\Policy\ScopePolicyManager;
-use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use Psr\Http\Message\ServerRequestInterface;
 
 final class TokenEndpointScopeExtension implements TokenEndpointExtension

Please login to merge, or discard this patch.

ClientConfigurationEndpoint/Tests/ClientConfigurationEndpointTest.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -15,7 +15,6 @@  discard block
 block discarded – undo
 
 use Http\Message\MessageFactory\DiactorosMessageFactory;
 use Http\Message\ResponseFactory;
-use Psr\Http\Server\RequestHandlerInterface;
 use OAuth2Framework\Component\BearerTokenType\BearerToken;
 use OAuth2Framework\Component\ClientConfigurationEndpoint\ClientConfigurationEndpoint;
 use OAuth2Framework\Component\ClientRule\RuleManager;
@@ -26,6 +25,7 @@  discard block
 block discarded – undo
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Server\RequestHandlerInterface;
 
 /**
  * @group ClientConfigurationEndpoint

Please login to merge, or discard this patch.

src/Component/Core/Client/Client.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -14,8 +14,8 @@
 block discarded – undo
 namespace OAuth2Framework\Component\Core\Client;
 
 use OAuth2Framework\Component\Core\DataBag\DataBag;
-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
 use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
 
 /**

Please login to merge, or discard this patch.

Component/ClientCredentialsGrant/Tests/ClientCredentialsGrantTypeTest.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,11 +13,11 @@
 block discarded – undo
 
 namespace OAuth2Framework\Component\ClientCredentialsGrant\Tests;
 
+use OAuth2Framework\Component\ClientCredentialsGrant\ClientCredentialsGrantType;
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Client\ClientId;
 use OAuth2Framework\Component\Core\DataBag\DataBag;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
-use OAuth2Framework\Component\ClientCredentialsGrant\ClientCredentialsGrantType;
 use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Message\ServerRequestInterface;

Please login to merge, or discard this patch.

src/Component/Core/Middleware/AccessTokenMiddleware.php 1 patch

Unused Use Statements +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,14 +13,14 @@
 block discarded – undo
 
 namespace OAuth2Framework\Component\Core\Middleware;
 
-use Psr\Http\Server\RequestHandlerInterface;
-use Psr\Http\Server\MiddlewareInterface;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenId;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\Core\TokenType\TokenTypeManager;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Server\MiddlewareInterface;
+use Psr\Http\Server\RequestHandlerInterface;
 
 final class AccessTokenMiddleware implements MiddlewareInterface
 {

Please login to merge, or discard this patch.

		@@ -14,25 +14,25 @@
		block discarded – undo
14	14	namespace OAuth2Framework\Component\TokenEndpoint\Tests;
15	15
16	16	use Http\Message\MessageFactory\GuzzleMessageFactory;
	17	+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
17	18	use OAuth2Framework\Component\Core\AccessToken\AccessTokenId;
18	19	use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
19	20	use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
20		-use Psr\Http\Server\RequestHandlerInterface;
21		-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
22	21	use OAuth2Framework\Component\Core\Client\Client;
23	22	use OAuth2Framework\Component\Core\Client\ClientId;
24	23	use OAuth2Framework\Component\Core\Client\ClientRepository;
25	24	use OAuth2Framework\Component\Core\DataBag\DataBag;
26		-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
27	25	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	26	+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
	27	+use OAuth2Framework\Component\Core\TokenType\TokenType;
28	28	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
29	29	use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
30	30	use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
31	31	use OAuth2Framework\Component\TokenEndpoint\TokenEndpoint;
32		-use OAuth2Framework\Component\Core\TokenType\TokenType;
33	32	use PHPUnit\Framework\TestCase;
34	33	use Prophecy\Argument;
35	34	use Psr\Http\Message\ServerRequestInterface;
	35	+use Psr\Http\Server\RequestHandlerInterface;
36	36
37	37	/**
38	38	* @group TokenEndpoint

		@@ -14,23 +14,23 @@
		block discarded – undo
14	14	namespace OAuth2Framework\Component\TokenEndpoint;
15	15
16	16	use Http\Message\ResponseFactory;
	17	+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
17	18	use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
18	19	use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
19		-use Psr\Http\Server\RequestHandlerInterface;
20		-use Psr\Http\Server\MiddlewareInterface;
21		-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
22	20	use OAuth2Framework\Component\Core\Client\Client;
23	21	use OAuth2Framework\Component\Core\Client\ClientId;
24	22	use OAuth2Framework\Component\Core\Client\ClientRepository;
25		-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
	23	+use OAuth2Framework\Component\Core\Message\OAuth2Message;
26	24	use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
	25	+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
	26	+use OAuth2Framework\Component\Core\TokenType\TokenType;
27	27	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
28	28	use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
29		-use OAuth2Framework\Component\Core\Message\OAuth2Message;
30	29	use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
31		-use OAuth2Framework\Component\Core\TokenType\TokenType;
32	30	use Psr\Http\Message\ResponseInterface;
33	31	use Psr\Http\Message\ServerRequestInterface;
	32	+use Psr\Http\Server\MiddlewareInterface;
	33	+use Psr\Http\Server\RequestHandlerInterface;
34	34
35	35	class TokenEndpoint implements MiddlewareInterface
36	36	{

		@@ -13,9 +13,9 @@
		block discarded – undo
13	13
14	14	namespace OAuth2Framework\ServerBundle\Form\Handler;
15	15
16		-use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
17	16	use OAuth2Framework\Component\AuthorizationEndpoint\Authorization;
18	17	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	18	+use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
19	19	use Psr\Http\Message\ServerRequestInterface;
20	20	use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;
21	21	use Symfony\Component\Form\ClickableInterface;

		@@ -14,10 +14,10 @@
		block discarded – undo
14	14	namespace OAuth2Framework\Component\AuthorizationCodeGrant;
15	15
16	16	use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\PKCEMethodManager;
17		-use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
18	17	use OAuth2Framework\Component\Core\Client\Client;
19	18	use OAuth2Framework\Component\Core\Message\OAuth2Message;
20	19	use OAuth2Framework\Component\TokenEndpoint\GrantType;
	20	+use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
21	21	use Psr\Http\Message\ServerRequestInterface;
22	22
23	23	final class AuthorizationCodeGrantType implements GrantType

		@@ -15,12 +15,12 @@
		block discarded – undo
15	15
16	16	use OAuth2Framework\Component\Core\AccessToken\AccessToken;
17	17	use OAuth2Framework\Component\Core\Client\Client;
	18	+use OAuth2Framework\Component\Core\Message\OAuth2Message;
18	19	use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
	20	+use OAuth2Framework\Component\Scope\Policy\ScopePolicyManager;
19	21	use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtension;
20		-use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
21	22	use OAuth2Framework\Component\TokenEndpoint\GrantType;
22		-use OAuth2Framework\Component\Scope\Policy\ScopePolicyManager;
23		-use OAuth2Framework\Component\Core\Message\OAuth2Message;
	23	+use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
24	24	use Psr\Http\Message\ServerRequestInterface;
25	25
26	26	final class TokenEndpointScopeExtension implements TokenEndpointExtension

		@@ -15,7 +15,6 @@ discard block
		block discarded – undo
15	15
16	16	use Http\Message\MessageFactory\DiactorosMessageFactory;
17	17	use Http\Message\ResponseFactory;
18		-use Psr\Http\Server\RequestHandlerInterface;
19	18	use OAuth2Framework\Component\BearerTokenType\BearerToken;
20	19	use OAuth2Framework\Component\ClientConfigurationEndpoint\ClientConfigurationEndpoint;
21	20	use OAuth2Framework\Component\ClientRule\RuleManager;
		@@ -26,6 +25,7 @@ discard block
		block discarded – undo
26	25	use PHPUnit\Framework\TestCase;
27	26	use Prophecy\Argument;
28	27	use Psr\Http\Message\ServerRequestInterface;
	28	+use Psr\Http\Server\RequestHandlerInterface;
29	29
30	30	/**
31	31	* @group ClientConfigurationEndpoint

		@@ -14,8 +14,8 @@
		block discarded – undo
14	14	namespace OAuth2Framework\Component\Core\Client;
15	15
16	16	use OAuth2Framework\Component\Core\DataBag\DataBag;
17		-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
18	17	use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
	18	+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
19	19	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
20	20
21	21	/**

		@@ -13,11 +13,11 @@
		block discarded – undo
13	13
14	14	namespace OAuth2Framework\Component\ClientCredentialsGrant\Tests;
15	15
	16	+use OAuth2Framework\Component\ClientCredentialsGrant\ClientCredentialsGrantType;
16	17	use OAuth2Framework\Component\Core\Client\Client;
17	18	use OAuth2Framework\Component\Core\Client\ClientId;
18	19	use OAuth2Framework\Component\Core\DataBag\DataBag;
19	20	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
20		-use OAuth2Framework\Component\ClientCredentialsGrant\ClientCredentialsGrantType;
21	21	use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
22	22	use PHPUnit\Framework\TestCase;
23	23	use Psr\Http\Message\ServerRequestInterface;

		@@ -13,14 +13,14 @@
		block discarded – undo
13	13
14	14	namespace OAuth2Framework\Component\Core\Middleware;
15	15
16		-use Psr\Http\Server\RequestHandlerInterface;
17		-use Psr\Http\Server\MiddlewareInterface;
18	16	use OAuth2Framework\Component\Core\AccessToken\AccessTokenId;
19	17	use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
20	18	use OAuth2Framework\Component\Core\Message\OAuth2Message;
21	19	use OAuth2Framework\Component\Core\TokenType\TokenTypeManager;
22	20	use Psr\Http\Message\ResponseInterface;
23	21	use Psr\Http\Message\ServerRequestInterface;
	22	+use Psr\Http\Server\MiddlewareInterface;
	23	+use Psr\Http\Server\RequestHandlerInterface;
24	24
25	25	final class AccessTokenMiddleware implements MiddlewareInterface
26	26	{

OAuth2-Framework / oauth2-framework

Push — master ( aea50b...4aa0c5 )

Status

Category

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +2 added lines, -2 removed lines patch added patch discarded remove patch