OAuth2Framework\Bundle\Server\Security\Factory\OAuth2SecurityFactory

Complexity

Total Complexity

4

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	19	1
A	getPosition()	0	4	1
A	getKey()	0	4	1
A	addConfiguration()	0	10	1

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2017 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Bundle\Server\Security\Factory;

use OAuth2Framework\Bundle\Server\Security\Authentication\Provider\OAuth2Provider;
use OAuth2Framework\Bundle\Server\Security\EntryPoint\OAuth2EntryPoint;
use OAuth2Framework\Bundle\Server\Security\Firewall\OAuth2Listener;
use Symfony\Component\DependencyInjection\ChildDefinition;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Bundle\SecurityBundle\DependencyInjection\Security\Factory\SecurityFactoryInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;

final class OAuth2SecurityFactory implements SecurityFactoryInterface
{
    public function create(ContainerBuilder $container, $id, $config, $userProvider, $defaultEntryPoint)
    {
        $providerId = 'security.authentication.provider.oauth2.'.$id;
        $container
            ->setDefinition($providerId, new ChildDefinition(OAuth2Provider::class))
            ->setAutowired(true)
        ;

        $listenerId = 'security.authentication.listener.oauth2.'.$id;
        $listener = $container

$listener is not used, you could remove the assignment.

            ->setDefinition($listenerId, new ChildDefinition(OAuth2Listener::class))
            ->setArguments([
                new Reference(TokenStorageInterface::class),
                new Reference('security.authentication.manager')
            ])
        ;

        return array($providerId, $listenerId, OAuth2EntryPoint::class);
    }

    /**
     * {@inheritdoc}
     */
    public function getPosition()
    {
        return 'pre_auth';
    }

    /**
     * {@inheritdoc}
     */
    public function getKey()
    {
        return 'oauth2';
    }

    /**
     * {@inheritdoc}
     */
    public function addConfiguration(NodeDefinition $node)
    {
        $node

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Config\Definition\Builder\NodeDefinition as the method children() does only exist in the following sub-classes of Symfony\Component\Config\Definition\Builder\NodeDefinition: Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition. Maybe you want to instanceof check for one of these explicitly?

            ->children()
                ->scalarNode('access_token_handler_manager')
                    ->info('The access token handler manager has to retrieve access tokens on demand. Access token can be find from a database, the introspection or any other method.')
                    ->isRequired()
                ->end()
            ->end();
    }
}