AnnotationDriver::addChecker() - Code Metrics - Inspection of "Apply fixes from StyleCI" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — ng (#80)

by Florent

created 2018-01-30 22:57 UTC

AnnotationDriver::addChecker() A

↳ Parent: AnnotationDriver

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Bundle\Annotation;

use Doctrine\Common\Annotations\Reader;
use OAuth2Framework\Bundle\Annotation\Checker\CheckerInterface;
use OAuth2Framework\Bundle\Security\Authentication\Token\OAuth2Token;
use OAuth2Framework\Component\Response\OAuth2ResponseFactoryManager;
use OAuth2Framework\Component\Response\OAuth2ResponseInterface;
use OAuth2Framework\Component\TokenType\TokenTypeManager;
use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;
use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;

final class AnnotationDriver
{
    /**
     * @var Reader
     */
    private $reader;

    /**
     * @var TokenStorageInterface
     */
    private $tokenStorage;

    /**
     * @var CheckerInterface[]
     */
    private $checkers = [];

    /**
     * @var TokenTypeManager
     */
    private $tokenTypeManager;

    /**
     * @var OAuth2ResponseFactoryManager
     */
    private $oauth2ResponseFactoryManager;

    /**
     * AnnotationDriver constructor.
     *
     * @param Reader                       $reader
     * @param TokenStorageInterface        $tokenStorage
     * @param TokenTypeManager             $tokenTypeManager
     * @param OAuth2ResponseFactoryManager $oauth2ResponseFactoryManager
     */
    public function __construct(Reader $reader, TokenStorageInterface $tokenStorage, TokenTypeManager $tokenTypeManager, OAuth2ResponseFactoryManager $oauth2ResponseFactoryManager)
    {
        $this->reader = $reader;
        $this->tokenStorage = $tokenStorage;
        $this->tokenTypeManager = $tokenTypeManager;
        $this->oauth2ResponseFactoryManager = $oauth2ResponseFactoryManager;
    }

    /**
     * @param CheckerInterface $checker
     *
     * @return AnnotationDriver
     */
    public function addChecker(CheckerInterface $checker): self
    {
        $this->checkers[] = $checker;

        return $this;
    }

    /**
     * @return CheckerInterface[]
     */
    public function getCheckers(): array
    {
        return $this->checkers;
    }

    public function onKernelController(FilterControllerEvent $event)
    {
        if (!is_array($controller = $event->getController())) {
            return;
        }

        $object = new \ReflectionObject($controller[0]);
        $method = $object->getMethod($controller[1]);
        $classConfigurations = $this->reader->getClassAnnotations($object);
        $methodConfigurations = $this->reader->getMethodAnnotations($method);

        foreach (array_merge($classConfigurations, $methodConfigurations) as $configuration) {
            if ($configuration instanceof OAuth2) {
                $token = $this->tokenStorage->getToken();

                if (!$token instanceof OAuth2Token) {
                    $this->createAuthenticationException($event, 'OAuth2 authentication required');

                    return;
                }

                foreach ($this->getCheckers() as $checker) {
                    $message = $checker->check($token, $configuration);
                    if (null !== $message) {
                        $this->createAccessDeniedException($event, $message);

                        return;
                    }
                }
            }
        }
    }

    /**
     * @param FilterControllerEvent $event
     * @param string                $message
     */
    private function createAuthenticationException(FilterControllerEvent &$event, $message)
    {
        $schemes = $this->tokenTypeManager->getSchemes();
        $response = $this->oauth2ResponseFactoryManager->getResponse(
            401,
            [
                'error' => OAuth2ResponseFactoryManager::ERROR_ACCESS_DENIED,
                'error_description' => $message,
                'schemes' => $schemes,
            ]
        );

        $this->updateFilterControllerEvent($event, $response);
    }

    /**
     * @param FilterControllerEvent $event
     * @param string                $message
     */
    private function createAccessDeniedException(FilterControllerEvent &$event, $message)
    {
        $response = $this->oauth2ResponseFactoryManager->getResponse(
            403,
            [
                'error' => OAuth2ResponseFactoryManager::ERROR_ACCESS_DENIED,
                'error_description' => $message,
            ]
        );
        $this->updateFilterControllerEvent($event, $response);
    }

    /**
     * @param FilterControllerEvent   $event
     * @param OAuth2ResponseInterface $response
     */
    private function updateFilterControllerEvent(FilterControllerEvent &$event, OAuth2ResponseInterface $response)
    {
        $event->setController(function () use ($response) {
            $factory = new HttpFoundationFactory();
            $response = $factory->createResponse($response->getResponse());
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)

            return $response;
        });
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2018 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace OAuth2Framework\Bundle\Annotation;
15
16			use Doctrine\Common\Annotations\Reader;
17			use OAuth2Framework\Bundle\Annotation\Checker\CheckerInterface;
18			use OAuth2Framework\Bundle\Security\Authentication\Token\OAuth2Token;
19			use OAuth2Framework\Component\Response\OAuth2ResponseFactoryManager;
20			use OAuth2Framework\Component\Response\OAuth2ResponseInterface;
21			use OAuth2Framework\Component\TokenType\TokenTypeManager;
22			use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;
23			use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
24			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
25
26			final class AnnotationDriver
27			{
28			/**
29			* @var Reader
30			*/
31			private $reader;
32
33			/**
34			* @var TokenStorageInterface
35			*/
36			private $tokenStorage;
37
38			/**
39			* @var CheckerInterface[]
40			*/
41			private $checkers = [];
42
43			/**
44			* @var TokenTypeManager
45			*/
46			private $tokenTypeManager;
47
48			/**
49			* @var OAuth2ResponseFactoryManager
50			*/
51			private $oauth2ResponseFactoryManager;
52
53			/**
54			* AnnotationDriver constructor.
55			*
56			* @param Reader $reader
57			* @param TokenStorageInterface $tokenStorage
58			* @param TokenTypeManager $tokenTypeManager
59			* @param OAuth2ResponseFactoryManager $oauth2ResponseFactoryManager
60			*/
61			public function __construct(Reader $reader, TokenStorageInterface $tokenStorage, TokenTypeManager $tokenTypeManager, OAuth2ResponseFactoryManager $oauth2ResponseFactoryManager)
62			{
63			$this->reader = $reader;
64			$this->tokenStorage = $tokenStorage;
65			$this->tokenTypeManager = $tokenTypeManager;
66			$this->oauth2ResponseFactoryManager = $oauth2ResponseFactoryManager;
67			}
68
69			/**
70			* @param CheckerInterface $checker
71			*
72			* @return AnnotationDriver
73			*/
74			public function addChecker(CheckerInterface $checker): self
75			{
76			$this->checkers[] = $checker;
77
78			return $this;
79			}
80
81			/**
82			* @return CheckerInterface[]
83			*/
84			public function getCheckers(): array
85			{
86			return $this->checkers;
87			}
88
89			public function onKernelController(FilterControllerEvent $event)
90			{
91			if (!is_array($controller = $event->getController())) {
92			return;
93			}
94
95			$object = new \ReflectionObject($controller[0]);
96			$method = $object->getMethod($controller[1]);
97			$classConfigurations = $this->reader->getClassAnnotations($object);
98			$methodConfigurations = $this->reader->getMethodAnnotations($method);
99
100			foreach (array_merge($classConfigurations, $methodConfigurations) as $configuration) {
101			if ($configuration instanceof OAuth2) {
102			$token = $this->tokenStorage->getToken();
103
104			if (!$token instanceof OAuth2Token) {
105			$this->createAuthenticationException($event, 'OAuth2 authentication required');
106
107			return;
108			}
109
110			foreach ($this->getCheckers() as $checker) {
111			$message = $checker->check($token, $configuration);
112			if (null !== $message) {
113			$this->createAccessDeniedException($event, $message);
114
115			return;
116			}
117			}
118			}
119			}
120			}
121
122			/**
123			* @param FilterControllerEvent $event
124			* @param string $message
125			*/
126			private function createAuthenticationException(FilterControllerEvent &$event, $message)
127			{
128			$schemes = $this->tokenTypeManager->getSchemes();
129			$response = $this->oauth2ResponseFactoryManager->getResponse(
130			401,
131			[
132			'error' => OAuth2ResponseFactoryManager::ERROR_ACCESS_DENIED,
133			'error_description' => $message,
134			'schemes' => $schemes,
135			]
136			);
137
138			$this->updateFilterControllerEvent($event, $response);
139			}
140
141			/**
142			* @param FilterControllerEvent $event
143			* @param string $message
144			*/
145			private function createAccessDeniedException(FilterControllerEvent &$event, $message)
146			{
147			$response = $this->oauth2ResponseFactoryManager->getResponse(
148			403,
149			[
150			'error' => OAuth2ResponseFactoryManager::ERROR_ACCESS_DENIED,
151			'error_description' => $message,
152			]
153			);
154			$this->updateFilterControllerEvent($event, $response);
155			}
156
157			/**
158			* @param FilterControllerEvent $event
159			* @param OAuth2ResponseInterface $response
160			*/
161			private function updateFilterControllerEvent(FilterControllerEvent &$event, OAuth2ResponseInterface $response)
162			{
163			$event->setController(function () use ($response) {
164			$factory = new HttpFoundationFactory();
165			$response = $factory->createResponse($response->getResponse());
			0 ignored issues – show Bug introduced 2017-10-03 19:40 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$response`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
166
167			return $response;
168			});
169			}
170			}
171

OAuth2-Framework / oauth2-framework

Pull Request — ng (#80)

AnnotationDriver::addChecker() A

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like