OAuth2Framework\Bundle\DependencyInjection\Component\OpenIdConnect\PairwiseSubjectSource

Complexity

Total Complexity

4

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	continueLoading()	0	5	1
A	name()	0	4	1
A	getNodeDefinition()	0	15	2

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Bundle\DependencyInjection\Component\OpenIdConnect;

use OAuth2Framework\Bundle\DependencyInjection\Component\Component;
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Component\DependencyInjection\ContainerBuilder;

final class PairwiseSubjectSource implements Component

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: load, prepend

{
    /**
     * {@inheritdoc}
     */
    protected function continueLoading(string $path, ContainerBuilder $container, array $config)
    {
        $container->setAlias($path.'.service', $config['service']);
        $container->setParameter($path.'.is_default', $config['is_default']);
    }

    /**
     * {@inheritdoc}
     */
    public function name(): string
    {
        return 'pairwise_subject';
    }

    /**
     * {@inheritdoc}
     */
    public function getNodeDefinition(NodeDefinition $node)
    {

        $node

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Config\Definition\Builder\NodeDefinition as the method children() does only exist in the following sub-classes of Symfony\Component\Config\Definition\Builder\NodeDefinition: Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition. Maybe you want to instanceof check for one of these explicitly?

            ->validate()
                ->ifTrue(function ($config) {
                    return true === $config['enabled'] && empty($config['service']);
                })
                ->thenInvalid('The pairwise subject service must be set.')
            ->end()
            ->children()
                ->scalarNode('service')->end()
                ->booleanNode('is_default')->defaultTrue()->end()
            ->end();
    }
}