Inspection of "Userinfo Endpoint" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 0aaa64...eb8694 )

by Florent

created 2018-06-06 21:15 UTC

Status

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -13,19 +13,19 @@
 block discarded – undo
 
 namespace OAuth2Framework\Component\AuthorizationCodeGrant\Tests;
 
+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCode;
+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeGrantType;
+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeId;
+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeRepository;
 use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\PKCEMethodManager;
 use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\Plain;
 use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\S256;
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Client\ClientId;
 use OAuth2Framework\Component\Core\DataBag\DataBag;
-use OAuth2Framework\Component\Core\ResourceServer\ResourceServerId;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\Component\Core\ResourceServer\ResourceServerId;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCode;
-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeGrantType;
-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeId;
-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeRepository;
 use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;

Please login to merge, or discard this patch.

src/Component/JwtBearerGrant/Tests/JwtBearerGrantTypeTest.php 1 patch

Unused Use Statements +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -41,12 +41,12 @@
 block discarded – undo
 use OAuth2Framework\Component\Core\Client\ClientRepository;
 use OAuth2Framework\Component\Core\DataBag\DataBag;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuer;
+use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuerRepository;
 use OAuth2Framework\Component\Core\UserAccount\UserAccount;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
 use OAuth2Framework\Component\JwtBearerGrant\JwtBearerGrantType;
-use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuer;
-use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuerRepository;
 use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;

Please login to merge, or discard this patch.

src/Component/ResourceServerAuthentication/AuthenticationMethodManager.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,9 +13,9 @@
 block discarded – undo
 
 namespace OAuth2Framework\Component\ResourceServerAuthentication;
 
+use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\Core\ResourceServer\ResourceServer;
 use OAuth2Framework\Component\Core\ResourceServer\ResourceServerId;
-use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use Psr\Http\Message\ServerRequestInterface;
 
 class AuthenticationMethodManager

Please login to merge, or discard this patch.

src/Component/Scope/Tests/TokenEndpointScopeExtensionTest.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -18,8 +18,8 @@
 block discarded – undo
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Client\ClientId;
 use OAuth2Framework\Component\Core\DataBag\DataBag;
-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
 use OAuth2Framework\Component\Scope\Policy\NoScopePolicy;
 use OAuth2Framework\Component\Scope\Policy\ScopePolicyManager;

Please login to merge, or discard this patch.

src/Component/TokenEndpoint/Extension/TokenEndpointExtensionManager.php 2 patches

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -71,7 +71,7 @@  discard block
 block discarded – undo
     /**
      * @param int $index
      *
-     * @return callable
+     * @return \Closure
      *
      * @throws OAuth2Message
      */
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
     /**
      * @param int $index
      *
-     * @return callable
+     * @return \Closure
      *
      * @throws OAuth2Message
      */

Please login to merge, or discard this patch.

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -15,8 +15,8 @@
 block discarded – undo
 
 use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\Client\Client;
-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
 use OAuth2Framework\Component\TokenEndpoint\GrantType;
 use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
 use Psr\Http\Message\ServerRequestInterface;

Please login to merge, or discard this patch.

src/Component/TokenEndpoint/GrantType.php 1 patch

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -38,6 +38,7 @@
 block discarded – undo
      * @param ServerRequestInterface $request The request
      *
      * @throws OAuth2Message
+     * @return void
      */
     public function checkRequest(ServerRequestInterface $request);
 

Please login to merge, or discard this patch.

src/Component/TokenEndpoint/Tests/TokenEndpointTest.php 1 patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -14,25 +14,25 @@
 block discarded – undo
 namespace OAuth2Framework\Component\TokenEndpoint\Tests;
 
 use Http\Message\MessageFactory\GuzzleMessageFactory;
+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenId;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
-use Psr\Http\Server\RequestHandlerInterface;
-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Client\ClientId;
 use OAuth2Framework\Component\Core\Client\ClientRepository;
 use OAuth2Framework\Component\Core\DataBag\DataBag;
-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
+use OAuth2Framework\Component\Core\TokenType\TokenType;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
 use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
 use OAuth2Framework\Component\TokenEndpoint\TokenEndpoint;
-use OAuth2Framework\Component\Core\TokenType\TokenType;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Server\RequestHandlerInterface;
 
 /**
  * @group TokenEndpoint

Please login to merge, or discard this patch.

src/Component/TokenEndpoint/TokenEndpoint.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -14,23 +14,23 @@
 block discarded – undo
 namespace OAuth2Framework\Component\TokenEndpoint;
 
 use Http\Message\ResponseFactory;
+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
 use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
-use Psr\Http\Server\RequestHandlerInterface;
-use Psr\Http\Server\MiddlewareInterface;
-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
 use OAuth2Framework\Component\Core\Client\Client;
 use OAuth2Framework\Component\Core\Client\ClientId;
 use OAuth2Framework\Component\Core\Client\ClientRepository;
-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
+use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
+use OAuth2Framework\Component\Core\TokenType\TokenType;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
 use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
-use OAuth2Framework\Component\Core\Message\OAuth2Message;
 use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
-use OAuth2Framework\Component\Core\TokenType\TokenType;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Server\MiddlewareInterface;
+use Psr\Http\Server\RequestHandlerInterface;
 
 class TokenEndpoint implements MiddlewareInterface
 {

Please login to merge, or discard this patch.

src/ServerBundle/Form/Handler/AuthorizationFormHandler.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,9 +13,9 @@
 block discarded – undo
 
 namespace OAuth2Framework\ServerBundle\Form\Handler;
 
-use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
 use OAuth2Framework\Component\AuthorizationEndpoint\Authorization;
 use OAuth2Framework\Component\Core\Message\OAuth2Message;
+use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
 use Psr\Http\Message\ServerRequestInterface;
 use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;
 use Symfony\Component\Form\ClickableInterface;

Please login to merge, or discard this patch.

		@@ -41,12 +41,12 @@
		block discarded – undo
41	41	use OAuth2Framework\Component\Core\Client\ClientRepository;
42	42	use OAuth2Framework\Component\Core\DataBag\DataBag;
43	43	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	44	+use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuer;
	45	+use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuerRepository;
44	46	use OAuth2Framework\Component\Core\UserAccount\UserAccount;
45	47	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
46	48	use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
47	49	use OAuth2Framework\Component\JwtBearerGrant\JwtBearerGrantType;
48		-use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuer;
49		-use OAuth2Framework\Component\Core\TrustedIssuer\TrustedIssuerRepository;
50	50	use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
51	51	use PHPUnit\Framework\TestCase;
52	52	use Prophecy\Argument;

		@@ -13,19 +13,19 @@
		block discarded – undo
13	13
14	14	namespace OAuth2Framework\Component\AuthorizationCodeGrant\Tests;
15	15
	16	+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCode;
	17	+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeGrantType;
	18	+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeId;
	19	+use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeRepository;
16	20	use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\PKCEMethodManager;
17	21	use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\Plain;
18	22	use OAuth2Framework\Component\AuthorizationCodeGrant\PKCEMethod\S256;
19	23	use OAuth2Framework\Component\Core\Client\Client;
20	24	use OAuth2Framework\Component\Core\Client\ClientId;
21	25	use OAuth2Framework\Component\Core\DataBag\DataBag;
22		-use OAuth2Framework\Component\Core\ResourceServer\ResourceServerId;
23	26	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	27	+use OAuth2Framework\Component\Core\ResourceServer\ResourceServerId;
24	28	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
25		-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCode;
26		-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeGrantType;
27		-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeId;
28		-use OAuth2Framework\Component\AuthorizationCodeGrant\AuthorizationCodeRepository;
29	29	use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
30	30	use PHPUnit\Framework\TestCase;
31	31	use Prophecy\Argument;

		@@ -13,9 +13,9 @@
		block discarded – undo
13	13
14	14	namespace OAuth2Framework\Component\ResourceServerAuthentication;
15	15
	16	+use OAuth2Framework\Component\Core\Message\OAuth2Message;
16	17	use OAuth2Framework\Component\Core\ResourceServer\ResourceServer;
17	18	use OAuth2Framework\Component\Core\ResourceServer\ResourceServerId;
18		-use OAuth2Framework\Component\Core\Message\OAuth2Message;
19	19	use Psr\Http\Message\ServerRequestInterface;
20	20
21	21	class AuthenticationMethodManager

		@@ -18,8 +18,8 @@
		block discarded – undo
18	18	use OAuth2Framework\Component\Core\Client\Client;
19	19	use OAuth2Framework\Component\Core\Client\ClientId;
20	20	use OAuth2Framework\Component\Core\DataBag\DataBag;
21		-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
22	21	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	22	+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
23	23	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
24	24	use OAuth2Framework\Component\Scope\Policy\NoScopePolicy;
25	25	use OAuth2Framework\Component\Scope\Policy\ScopePolicyManager;

		@@ -71,7 +71,7 @@ discard block
		block discarded – undo
71	71	/**
72	72	* @param int $index
73	73	*
74		- * @return callable
	74	+ * @return \Closure
75	75	*
76	76	* @throws OAuth2Message
77	77	*/
		@@ -92,7 +92,7 @@ discard block
		block discarded – undo
92	92	/**
93	93	* @param int $index
94	94	*
95		- * @return callable
	95	+ * @return \Closure
96	96	*
97	97	* @throws OAuth2Message
98	98	*/

		@@ -15,8 +15,8 @@
		block discarded – undo
15	15
16	16	use OAuth2Framework\Component\Core\AccessToken\AccessToken;
17	17	use OAuth2Framework\Component\Core\Client\Client;
18		-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
19	18	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	19	+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
20	20	use OAuth2Framework\Component\TokenEndpoint\GrantType;
21	21	use OAuth2Framework\Component\TokenEndpoint\GrantTypeData;
22	22	use Psr\Http\Message\ServerRequestInterface;

		@@ -38,6 +38,7 @@
		block discarded – undo
38	38	* @param ServerRequestInterface $request The request
39	39	*
40	40	* @throws OAuth2Message
	41	+ * @return void
41	42	*/
42	43	public function checkRequest(ServerRequestInterface $request);
43	44

		@@ -14,25 +14,25 @@
		block discarded – undo
14	14	namespace OAuth2Framework\Component\TokenEndpoint\Tests;
15	15
16	16	use Http\Message\MessageFactory\GuzzleMessageFactory;
	17	+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
17	18	use OAuth2Framework\Component\Core\AccessToken\AccessTokenId;
18	19	use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
19	20	use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
20		-use Psr\Http\Server\RequestHandlerInterface;
21		-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
22	21	use OAuth2Framework\Component\Core\Client\Client;
23	22	use OAuth2Framework\Component\Core\Client\ClientId;
24	23	use OAuth2Framework\Component\Core\Client\ClientRepository;
25	24	use OAuth2Framework\Component\Core\DataBag\DataBag;
26		-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
27	25	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	26	+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
	27	+use OAuth2Framework\Component\Core\TokenType\TokenType;
28	28	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
29	29	use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
30	30	use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
31	31	use OAuth2Framework\Component\TokenEndpoint\TokenEndpoint;
32		-use OAuth2Framework\Component\Core\TokenType\TokenType;
33	32	use PHPUnit\Framework\TestCase;
34	33	use Prophecy\Argument;
35	34	use Psr\Http\Message\ServerRequestInterface;
	35	+use Psr\Http\Server\RequestHandlerInterface;
36	36
37	37	/**
38	38	* @group TokenEndpoint

		@@ -14,23 +14,23 @@
		block discarded – undo
14	14	namespace OAuth2Framework\Component\TokenEndpoint;
15	15
16	16	use Http\Message\ResponseFactory;
	17	+use OAuth2Framework\Component\Core\AccessToken\AccessToken;
17	18	use OAuth2Framework\Component\Core\AccessToken\AccessTokenIdGenerator;
18	19	use OAuth2Framework\Component\Core\AccessToken\AccessTokenRepository;
19		-use Psr\Http\Server\RequestHandlerInterface;
20		-use Psr\Http\Server\MiddlewareInterface;
21		-use OAuth2Framework\Component\Core\AccessToken\AccessToken;
22	20	use OAuth2Framework\Component\Core\Client\Client;
23	21	use OAuth2Framework\Component\Core\Client\ClientId;
24	22	use OAuth2Framework\Component\Core\Client\ClientRepository;
25		-use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
	23	+use OAuth2Framework\Component\Core\Message\OAuth2Message;
26	24	use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwner;
	25	+use OAuth2Framework\Component\Core\ResourceOwner\ResourceOwnerId;
	26	+use OAuth2Framework\Component\Core\TokenType\TokenType;
27	27	use OAuth2Framework\Component\Core\UserAccount\UserAccountId;
28	28	use OAuth2Framework\Component\Core\UserAccount\UserAccountRepository;
29		-use OAuth2Framework\Component\Core\Message\OAuth2Message;
30	29	use OAuth2Framework\Component\TokenEndpoint\Extension\TokenEndpointExtensionManager;
31		-use OAuth2Framework\Component\Core\TokenType\TokenType;
32	30	use Psr\Http\Message\ResponseInterface;
33	31	use Psr\Http\Message\ServerRequestInterface;
	32	+use Psr\Http\Server\MiddlewareInterface;
	33	+use Psr\Http\Server\RequestHandlerInterface;
34	34
35	35	class TokenEndpoint implements MiddlewareInterface
36	36	{

		@@ -13,9 +13,9 @@
		block discarded – undo
13	13
14	14	namespace OAuth2Framework\ServerBundle\Form\Handler;
15	15
16		-use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
17	16	use OAuth2Framework\Component\AuthorizationEndpoint\Authorization;
18	17	use OAuth2Framework\Component\Core\Message\OAuth2Message;
	18	+use OAuth2Framework\ServerBundle\Form\Model\AuthorizationModel;
19	19	use Psr\Http\Message\ServerRequestInterface;
20	20	use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;
21	21	use Symfony\Component\Form\ClickableInterface;

OAuth2-Framework / oauth2-framework

Push — master ( 0aaa64...eb8694 )

Status

Category

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Unused Use Statements +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch