OAuth2Framework\Component\ClientAuthentication\Rule\ClientAuthenticationMethodRule

Complexity

Total Complexity

5

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	19	4
A	__construct()	0	3	1

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2019 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Component\ClientAuthentication\Rule;

use OAuth2Framework\Component\ClientAuthentication\AuthenticationMethodManager;
use OAuth2Framework\Component\ClientRule\Rule;
use OAuth2Framework\Component\ClientRule\RuleHandler;
use OAuth2Framework\Component\Core\Client\ClientId;
use OAuth2Framework\Component\Core\DataBag\DataBag;
use function Safe\sprintf;

final class ClientAuthenticationMethodRule implements Rule
{
    /**
     * @var AuthenticationMethodManager
     */
    private $clientAuthenticationMethodManager;

    public function __construct(AuthenticationMethodManager $clientAuthenticationMethodManager)
    {
        $this->clientAuthenticationMethodManager = $clientAuthenticationMethodManager;
    }

    public function handle(ClientId $clientId, DataBag $commandParameters, DataBag $validatedParameters, RuleHandler $next): DataBag
    {
        if (!$commandParameters->has('token_endpoint_auth_method')) {
            $commandParameters->set('token_endpoint_auth_method', 'client_secret_basic');
        }

        if (!\is_string($commandParameters->get('token_endpoint_auth_method'))) {
            throw new \InvalidArgumentException('The parameter "token_endpoint_auth_method" must be a string.');
        }
        if (!$this->clientAuthenticationMethodManager->has($commandParameters->get('token_endpoint_auth_method'))) {

It seems like $commandParameters->get('token_endpoint_auth_method') can also be of type null; however, parameter $name of OAuth2Framework\Component\ClientAuthentication\AuthenticationMethodManager::has() does only seem to accept string, maybe add an additional type check?

            throw new \InvalidArgumentException(sprintf('The token endpoint authentication method "%s" is not supported. Please use one of the following values: %s', $commandParameters->get('token_endpoint_auth_method'), implode(', ', $this->clientAuthenticationMethodManager->list())));
        }

        $clientAuthenticationMethod = $this->clientAuthenticationMethodManager->get($commandParameters->get('token_endpoint_auth_method'));

It seems like $commandParameters->get('token_endpoint_auth_method') can also be of type null; however, parameter $name of OAuth2Framework\Component\ClientAuthentication\AuthenticationMethodManager::get() does only seem to accept string, maybe add an additional type check?

        $validatedParameters = $next->handle($clientId, $commandParameters, $validatedParameters);
        $validatedParameters = $clientAuthenticationMethod->checkClientConfiguration($commandParameters, $validatedParameters);
        $validatedParameters->set('token_endpoint_auth_method', $commandParameters->get('token_endpoint_auth_method'));

        return $validatedParameters;
    }
}