UploadedFileTest::testRaisesExceptionOnInvalidSize() - Code Metrics - Inspection of "Update to new PSR17 (#46)" - Nyholm/psr7 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4e07a2...96fcad )

by Tobias

created 2018-07-23 00:15 UTC

testRaisesExceptionOnInvalidSize() A

↳ Parent: UploadedFileTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	7
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	1

<?php

namespace Tests\Nyholm\Psr7;

use Nyholm\Psr7\Stream;
use Nyholm\Psr7\UploadedFile;
use PHPUnit\Framework\TestCase;

/**
 * @covers \Nyholm\Psr7\UploadedFile
 */
class UploadedFileTest extends TestCase
{
    protected $cleanup;

    public function setUp()
    {
        $this->cleanup = [];
    }

    public function tearDown()
    {
        foreach ($this->cleanup as $file) {
            if (is_scalar($file) && file_exists($file)) {
                unlink($file);
            }
        }
    }

    public function invalidStreams()

    {
        return [
            'null' => [null],
            'true' => [true],
            'false' => [false],
            'int' => [1],
            'float' => [1.1],
            'array' => [['filename']],
            'object' => [(object) ['filename']],
        ];
    }

    /**
     * @dataProvider invalidStreams
     */
    public function testRaisesExceptionOnInvalidStreamOrFile($streamOrFile)
    {
        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('Invalid stream or file provided for UploadedFile');

        new UploadedFile($streamOrFile, 0, UPLOAD_ERR_OK);
    }

    public function invalidErrorStatuses()
    {
        return [
            'null' => [null],
            'true' => [true],
            'false' => [false],
            'float' => [1.1],
            'string' => ['1'],
            'array' => [[1]],
            'object' => [(object) [1]],
            'negative' => [-1],
            'too-big' => [9],
        ];
    }

    /**
     * @dataProvider invalidErrorStatuses
     */
    public function testRaisesExceptionOnInvalidErrorStatus($status)
    {
        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('status');

        new UploadedFile(fopen('php://temp', 'wb+'), 0, $status);
    }

    public function invalidFilenamesAndMediaTypes()

    {
        return [
            'true' => [true],
            'false' => [false],
            'int' => [1],
            'float' => [1.1],
            'array' => [['string']],
            'object' => [(object) ['string']],
        ];
    }

    /**
     * @dataProvider invalidFilenamesAndMediaTypes
     */
    public function testRaisesExceptionOnInvalidClientFilename($filename)

    {
        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('filename');

        new UploadedFile(fopen('php://temp', 'wb+'), 0, UPLOAD_ERR_OK, $filename);
    }

    /**
     * @dataProvider invalidFilenamesAndMediaTypes
     */
    public function testRaisesExceptionOnInvalidClientMediaType($mediaType)

    {
        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('media type');

        new UploadedFile(fopen('php://temp', 'wb+'), 0, UPLOAD_ERR_OK, 'foobar.baz', $mediaType);
    }

    public function testGetStreamReturnsOriginalStreamObject()
    {
        $stream = Stream::create('');
        $upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);

        $this->assertSame($stream, $upload->getStream());
    }

    public function testGetStreamReturnsWrappedPhpStream()
    {
        $stream = fopen('php://temp', 'wb+');
        $upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);
        $uploadStream = $upload->getStream()->detach();

        $this->assertSame($stream, $uploadStream);
    }

    public function testSuccessful()
    {
        $stream = Stream::create('Foo bar!');
        $upload = new UploadedFile($stream, $stream->getSize(), UPLOAD_ERR_OK, 'filename.txt', 'text/plain');

        $this->assertEquals($stream->getSize(), $upload->getSize());
        $this->assertEquals('filename.txt', $upload->getClientFilename());
        $this->assertEquals('text/plain', $upload->getClientMediaType());

        $this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'successful');
        $upload->moveTo($to);
        $this->assertFileExists($to);
        $this->assertEquals($stream->__toString(), file_get_contents($to));
    }

    public function invalidMovePaths()

    {
        return [
            'null' => [null],
            'true' => [true],
            'false' => [false],
            'int' => [1],
            'float' => [1.1],
            'empty' => [''],
            'array' => [['filename']],
            'object' => [(object) ['filename']],
        ];
    }

    /**
     * @dataProvider invalidMovePaths
     */
    public function testMoveRaisesExceptionForInvalidPath($path)
    {
        $stream = (new \Nyholm\Psr7\Factory\StreamFactory())->createStream('Foo bar!');
        $upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);

        $this->cleanup[] = $path;

        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('path');
        $upload->moveTo($path);
    }

    public function testMoveCannotBeCalledMoreThanOnce()

    {
        $stream = (new \Nyholm\Psr7\Factory\StreamFactory())->createStream('Foo bar!');
        $upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);

        $this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'diac');
        $upload->moveTo($to);
        $this->assertTrue(file_exists($to));

        $this->expectException(\RuntimeException::class);
        $this->expectExceptionMessage('moved');
        $upload->moveTo($to);
    }

    public function testCannotRetrieveStreamAfterMove()

    {
        $stream = (new \Nyholm\Psr7\Factory\StreamFactory())->createStream('Foo bar!');
        $upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);

        $this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'diac');
        $upload->moveTo($to);
        $this->assertFileExists($to);

        $this->expectException(\RuntimeException::class);
        $this->expectExceptionMessage('moved');
        $upload->getStream();
    }

    public function nonOkErrorStatus()
    {
        return [
            'UPLOAD_ERR_INI_SIZE' => [UPLOAD_ERR_INI_SIZE],
            'UPLOAD_ERR_FORM_SIZE' => [UPLOAD_ERR_FORM_SIZE],
            'UPLOAD_ERR_PARTIAL' => [UPLOAD_ERR_PARTIAL],
            'UPLOAD_ERR_NO_FILE' => [UPLOAD_ERR_NO_FILE],
            'UPLOAD_ERR_NO_TMP_DIR' => [UPLOAD_ERR_NO_TMP_DIR],
            'UPLOAD_ERR_CANT_WRITE' => [UPLOAD_ERR_CANT_WRITE],
            'UPLOAD_ERR_EXTENSION' => [UPLOAD_ERR_EXTENSION],
        ];
    }

    /**
     * @dataProvider nonOkErrorStatus
     */
    public function testConstructorDoesNotRaiseExceptionForInvalidStreamWhenErrorStatusPresent($status)
    {
        $uploadedFile = new UploadedFile('not ok', 0, $status);
        $this->assertSame($status, $uploadedFile->getError());
    }

    /**
     * @dataProvider nonOkErrorStatus
     */
    public function testMoveToRaisesExceptionWhenErrorStatusPresent($status)
    {
        $uploadedFile = new UploadedFile('not ok', 0, $status);
        $this->expectException(\RuntimeException::class);
        $this->expectExceptionMessage('upload error');
        $uploadedFile->moveTo(__DIR__.'/'.uniqid());
    }

    /**
     * @dataProvider nonOkErrorStatus
     */
    public function testGetStreamRaisesExceptionWhenErrorStatusPresent($status)
    {
        $uploadedFile = new UploadedFile('not ok', 0, $status);
        $this->expectException(\RuntimeException::class);
        $this->expectExceptionMessage('upload error');
        $stream = $uploadedFile->getStream();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testMoveToCreatesStreamIfOnlyAFilenameWasProvided()
    {
        $this->cleanup[] = $from = tempnam(sys_get_temp_dir(), 'copy_from');
        $this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'copy_to');

        copy(__FILE__, $from);

        $uploadedFile = new UploadedFile($from, 100, UPLOAD_ERR_OK, basename($from), 'text/plain');
        $uploadedFile->moveTo($to);

        $this->assertFileEquals(__FILE__, $to);
    }
}


1		<?php
2
3		namespace Tests\Nyholm\Psr7;
4
5		use Nyholm\Psr7\Stream;
6		use Nyholm\Psr7\UploadedFile;
7		use PHPUnit\Framework\TestCase;
8
9		/**
10		* @covers \Nyholm\Psr7\UploadedFile
11		*/
12		class UploadedFileTest extends TestCase
13		{
14		protected $cleanup;
15
16		public function setUp()
17		{
18		$this->cleanup = [];
19		}
20
21		public function tearDown()
22		{
23		foreach ($this->cleanup as $file) {
24		if (is_scalar($file) && file_exists($file)) {
25		unlink($file);
26		}
27		}
28		}
29
30	View Code Duplication	public function invalidStreams()
		1 ignored issue – show Duplication introduced 2017-12-03 21:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		return [
33		'null' => [null],
34		'true' => [true],
35		'false' => [false],
36		'int' => [1],
37		'float' => [1.1],
38		'array' => [['filename']],
39		'object' => [(object) ['filename']],
40		];
41		}
42
43		/**
44		* @dataProvider invalidStreams
45		*/
46		public function testRaisesExceptionOnInvalidStreamOrFile($streamOrFile)
47		{
48		$this->expectException(\InvalidArgumentException::class);
49		$this->expectExceptionMessage('Invalid stream or file provided for UploadedFile');
50
51		new UploadedFile($streamOrFile, 0, UPLOAD_ERR_OK);
52		}
53
54		public function invalidErrorStatuses()
55		{
56		return [
57		'null' => [null],
58		'true' => [true],
59		'false' => [false],
60		'float' => [1.1],
61		'string' => ['1'],
62		'array' => [[1]],
63		'object' => [(object) [1]],
64		'negative' => [-1],
65		'too-big' => [9],
66		];
67		}
68
69		/**
70		* @dataProvider invalidErrorStatuses
71		*/
72		public function testRaisesExceptionOnInvalidErrorStatus($status)
73		{
74		$this->expectException(\InvalidArgumentException::class);
75		$this->expectExceptionMessage('status');
76
77		new UploadedFile(fopen('php://temp', 'wb+'), 0, $status);
78		}
79
80	View Code Duplication	public function invalidFilenamesAndMediaTypes()
		1 ignored issue – show Duplication introduced 2017-12-03 21:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		{
82		return [
83		'true' => [true],
84		'false' => [false],
85		'int' => [1],
86		'float' => [1.1],
87		'array' => [['string']],
88		'object' => [(object) ['string']],
89		];
90		}
91
92		/**
93		* @dataProvider invalidFilenamesAndMediaTypes
94		*/
95	View Code Duplication	public function testRaisesExceptionOnInvalidClientFilename($filename)
		1 ignored issue – show Duplication introduced 2018-04-17 05:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		{
97		$this->expectException(\InvalidArgumentException::class);
98		$this->expectExceptionMessage('filename');
99
100		new UploadedFile(fopen('php://temp', 'wb+'), 0, UPLOAD_ERR_OK, $filename);
101		}
102
103		/**
104		* @dataProvider invalidFilenamesAndMediaTypes
105		*/
106	View Code Duplication	public function testRaisesExceptionOnInvalidClientMediaType($mediaType)
		1 ignored issue – show Duplication introduced 2018-04-17 05:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$this->expectException(\InvalidArgumentException::class);
109		$this->expectExceptionMessage('media type');
110
111		new UploadedFile(fopen('php://temp', 'wb+'), 0, UPLOAD_ERR_OK, 'foobar.baz', $mediaType);
112		}
113
114		public function testGetStreamReturnsOriginalStreamObject()
115		{
116		$stream = Stream::create('');
117		$upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);
118
119		$this->assertSame($stream, $upload->getStream());
120		}
121
122		public function testGetStreamReturnsWrappedPhpStream()
123		{
124		$stream = fopen('php://temp', 'wb+');
125		$upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);
126		$uploadStream = $upload->getStream()->detach();
127
128		$this->assertSame($stream, $uploadStream);
129		}
130
131		public function testSuccessful()
132		{
133		$stream = Stream::create('Foo bar!');
134		$upload = new UploadedFile($stream, $stream->getSize(), UPLOAD_ERR_OK, 'filename.txt', 'text/plain');
135
136		$this->assertEquals($stream->getSize(), $upload->getSize());
137		$this->assertEquals('filename.txt', $upload->getClientFilename());
138		$this->assertEquals('text/plain', $upload->getClientMediaType());
139
140		$this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'successful');
141		$upload->moveTo($to);
142		$this->assertFileExists($to);
143		$this->assertEquals($stream->__toString(), file_get_contents($to));
144		}
145
146	View Code Duplication	public function invalidMovePaths()
		1 ignored issue – show Duplication introduced 2017-12-03 21:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147		{
148		return [
149		'null' => [null],
150		'true' => [true],
151		'false' => [false],
152		'int' => [1],
153		'float' => [1.1],
154		'empty' => [''],
155		'array' => [['filename']],
156		'object' => [(object) ['filename']],
157		];
158		}
159
160		/**
161		* @dataProvider invalidMovePaths
162		*/
163		public function testMoveRaisesExceptionForInvalidPath($path)
164		{
165		$stream = (new \Nyholm\Psr7\Factory\StreamFactory())->createStream('Foo bar!');
166		$upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);
167
168		$this->cleanup[] = $path;
169
170		$this->expectException(\InvalidArgumentException::class);
171		$this->expectExceptionMessage('path');
172		$upload->moveTo($path);
173		}
174
175	View Code Duplication	public function testMoveCannotBeCalledMoreThanOnce()
		1 ignored issue – show Duplication introduced 2017-12-03 21:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
176		{
177		$stream = (new \Nyholm\Psr7\Factory\StreamFactory())->createStream('Foo bar!');
178		$upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);
179
180		$this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'diac');
181		$upload->moveTo($to);
182		$this->assertTrue(file_exists($to));
183
184		$this->expectException(\RuntimeException::class);
185		$this->expectExceptionMessage('moved');
186		$upload->moveTo($to);
187		}
188
189	View Code Duplication	public function testCannotRetrieveStreamAfterMove()
		1 ignored issue – show Duplication introduced 2017-12-03 21:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
190		{
191		$stream = (new \Nyholm\Psr7\Factory\StreamFactory())->createStream('Foo bar!');
192		$upload = new UploadedFile($stream, 0, UPLOAD_ERR_OK);
193
194		$this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'diac');
195		$upload->moveTo($to);
196		$this->assertFileExists($to);
197
198		$this->expectException(\RuntimeException::class);
199		$this->expectExceptionMessage('moved');
200		$upload->getStream();
201		}
202
203		public function nonOkErrorStatus()
204		{
205		return [
206		'UPLOAD_ERR_INI_SIZE' => [UPLOAD_ERR_INI_SIZE],
207		'UPLOAD_ERR_FORM_SIZE' => [UPLOAD_ERR_FORM_SIZE],
208		'UPLOAD_ERR_PARTIAL' => [UPLOAD_ERR_PARTIAL],
209		'UPLOAD_ERR_NO_FILE' => [UPLOAD_ERR_NO_FILE],
210		'UPLOAD_ERR_NO_TMP_DIR' => [UPLOAD_ERR_NO_TMP_DIR],
211		'UPLOAD_ERR_CANT_WRITE' => [UPLOAD_ERR_CANT_WRITE],
212		'UPLOAD_ERR_EXTENSION' => [UPLOAD_ERR_EXTENSION],
213		];
214		}
215
216		/**
217		* @dataProvider nonOkErrorStatus
218		*/
219		public function testConstructorDoesNotRaiseExceptionForInvalidStreamWhenErrorStatusPresent($status)
220		{
221		$uploadedFile = new UploadedFile('not ok', 0, $status);
222		$this->assertSame($status, $uploadedFile->getError());
223		}
224
225		/**
226		* @dataProvider nonOkErrorStatus
227		*/
228		public function testMoveToRaisesExceptionWhenErrorStatusPresent($status)
229		{
230		$uploadedFile = new UploadedFile('not ok', 0, $status);
231		$this->expectException(\RuntimeException::class);
232		$this->expectExceptionMessage('upload error');
233		$uploadedFile->moveTo(__DIR__.'/'.uniqid());
234		}
235
236		/**
237		* @dataProvider nonOkErrorStatus
238		*/
239		public function testGetStreamRaisesExceptionWhenErrorStatusPresent($status)
240		{
241		$uploadedFile = new UploadedFile('not ok', 0, $status);
242		$this->expectException(\RuntimeException::class);
243		$this->expectExceptionMessage('upload error');
244		$stream = $uploadedFile->getStream();
		0 ignored issues – show Unused Code introduced 2017-02-13 08:46 UTC by Report Bug Copy Issue Report `$stream` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
245		}
246
247		public function testMoveToCreatesStreamIfOnlyAFilenameWasProvided()
248		{
249		$this->cleanup[] = $from = tempnam(sys_get_temp_dir(), 'copy_from');
250		$this->cleanup[] = $to = tempnam(sys_get_temp_dir(), 'copy_to');
251
252		copy(__FILE__, $from);
253
254		$uploadedFile = new UploadedFile($from, 100, UPLOAD_ERR_OK, basename($from), 'text/plain');
255		$uploadedFile->moveTo($to);
256
257		$this->assertFileEquals(__FILE__, $to);
258		}
259		}
260

Nyholm / psr7

Push — master ( 4e07a2...96fcad )

testRaisesExceptionOnInvalidSize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like