Nyholm / psr7

src/Factory/HttplugFactory.php

<?php

declare(strict_types=1);

namespace Nyholm\Psr7\Factory;

use Nyholm\Psr7\{Request, Response, Stream, Uri};
use Psr\Http\Message\UriInterface;
use Http\Message\{MessageFactory, StreamFactory, UriFactory};

/**
 * @author Tobias Nyholm <tobias.nyholm@gmail.com>
 * @author Martijn van der Ven <martijn@vanderven.se>
 */
final class HttplugFactory implements MessageFactory, StreamFactory, UriFactory
{
    public function createRequest($method, $uri, array $headers = [], $body = null, $protocolVersion = '1.1')
    {
        return new Request($method, $uri, $headers, $body, $protocolVersion);

It seems like $uri defined by parameter $uri on line 17 can also be of type object<Psr\Http\Message\UriInterface>; however, Nyholm\Psr7\Request::__construct() does only seem to accept string|object<UriInterface>, maybe add an additional type check?

It seems like $body defined by parameter $body on line 17 can also be of type object<Psr\Http\Message\StreamInterface>; however, Nyholm\Psr7\Request::__construct() does only seem to accept string|null|resource|object<StreamInterface>, maybe add an additional type check?

    }

    public function createResponse($statusCode = 200, $reasonPhrase = null, array $headers = [], $body = null, $version = '1.1')
    {
        return new Response((int) $statusCode, $headers, $body, $version, $reasonPhrase);

It seems like $body defined by parameter $body on line 22 can also be of type object<Psr\Http\Message\StreamInterface>; however, Nyholm\Psr7\Response::__construct() does only seem to accept string|null|resource|object<StreamInterface>, maybe add an additional type check?

    }

    public function createStream($body = null)
    {
        return Stream::create(null === $body ? '' : $body);
    }

    public function createUri($uri = ''): UriInterface
    {
        if ($uri instanceof UriInterface) {
            return $uri;
        }

        return new Uri($uri);
    }
}