NuBOXDevCom / Database-Backup

src/FileManager.php

<?php

declare(strict_types=1);

namespace NDC;

/**
 * Class FileManager
 * @package NDC
 */
class FileManager
{
    /**
     * @var array
     */
    private array $params;
    /**
     * @var array
     */
    private array $files = [];

    /**
     * FileManager constructor.
     */
    public function __construct()
    {
        (new System())->loadConfigurationEnvironment();
        $this->params = [
            'files_path' => $_ENV['FILES_PATH_TO_SAVE_BACKUP'],
            'days_interval' => (int)$_ENV['FILES_DAYS_HISTORY']
        ];
        $this->_getFiles();
    }

    /**
     * @return void
     */
    private function _getFiles(): void
    {
        $files = scandir($this->params['files_path'], SCANDIR_SORT_ASCENDING);
        $this->files = array_filter(
            $files,

It seems like $files can also be of type false; however, parameter $input of array_filter() does only seem to accept array, maybe add an additional type check?

            function ($k) {
                $return = [];
                if ($k !== '..' && $k !== '.') {
                    $return[] = $k;
                }
                return $return;
            }
        );
    }

    /**
     * @return void
     */
    public function removeOldFilesByIntervalDays(): void
    {
        $time_before = time() - $this->params['days_interval'] * 86400;
        foreach ($this->files as $file) {
            $f = explode('-', $file);
            $f = str_replace('.sql', '', $f);
            if ($f[1] < $time_before) {
                @unlink($this->params['files_path'] . '/' . $file);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

            }
        }
    }
}