Issues in YumlCommandTest.php - New Issues - Inspection of "Integration of metadataGrapher new features" - Nono1971/doctrine-yuml-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0165b3...f3e283 )

by Bruno

created 2017-04-09 09:30 UTC

Bundle/YumlBundle/Command/YumlCommandTest.php (3 issues)

Labels

Severity

HERON 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace OnurbTest\Bundle\YumlBundle\Command;

use Onurb\Bundle\YumlBundle\Command\YumlCommand;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Tester\CommandTester;
use Symfony\Component\DependencyInjection\ContainerInterface;

class YumlCommandTest extends \PHPUnit_Framework_TestCase
{
    const YUML_LINK = 'https://yuml.me/15a98c92.png';

    /**
     * @var Application
     */
    private $application;

    /**
     * @var YumlCommand
     */
    private $command;

    /**
     * @var ContainerInterface
     */
    private $container;

    /**
     * @var CommandTester
     */
    private $commandTester;

    public function setUp()
    {
        parent::setUp();
        $this->application = new Application();
        $this->application->add(new YumlCommand());
        $this->command = $this->application->find('yuml:mappings');

        $this->commandTester = new CommandTester($this->command);

        $yumlClient = $this->getMock('Onurb\\Bundle\\YumlBundle\\Yuml\\YumlClientInterface');

        $yumlClient->expects($this->once())
            ->method('makeDslText')
            ->will($this->returnValue('[Simple.Entity|+a;b;c]'));

        $yumlClient->expects($this->once())
            ->method('getGraphUrl')
            ->will($this->returnValue(self::YUML_LINK));

        $this->container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerInterface');

        $this->container->expects($this->once())->method('get')
            ->with($this->matches('onurb_yuml.client'))
            ->will($this->returnValue($yumlClient));

        $this->container->expects($this->any())->method('getParameter')
            ->will(
                $this->returnCallback(
                    function($arg) {

                        switch ($arg) {
                            case 'onurb_yuml.show_fields_description':
                                return false;
                                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                            case 'onurb_yuml.colors':
                            case 'onurb_yuml.notes':
                                return array();
                                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                            default:
                                return false;
                        }
                    }
                )
            );

        $this->command->setContainer($this->container);
    }

    /**
     * @covers \Onurb\Bundle\YumlBundle\Command\YumlCommand
     */
    public function testExecute()
    {
        $this->commandTester->execute(array('command' => $this->command->getName()));
        $this->assertRegExp('/.../', $this->commandTester->getDisplay());
        $this->assertSame('Downloaded', explode(' ', $this->commandTester->getDisplay())[0]);
    }
}


GitHub Access Token became invalid

Push — master ( 0165b3...f3e283 )

Bundle/YumlBundle/Command/YumlCommandTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2			namespace OnurbTest\Bundle\YumlBundle\Command;
3
4			use Onurb\Bundle\YumlBundle\Command\YumlCommand;
5			use Symfony\Component\Console\Application;
6			use Symfony\Component\Console\Tester\CommandTester;
7			use Symfony\Component\DependencyInjection\ContainerInterface;
8
9			class YumlCommandTest extends \PHPUnit_Framework_TestCase
10			{
11			const YUML_LINK = 'https://yuml.me/15a98c92.png';
12
13			/**
14			* @var Application
15			*/
16			private $application;
17
18			/**
19			* @var YumlCommand
20			*/
21			private $command;
22
23			/**
24			* @var ContainerInterface
25			*/
26			private $container;
27
28			/**
29			* @var CommandTester
30			*/
31			private $commandTester;
32
33			public function setUp()
34			{
35			parent::setUp();
36			$this->application = new Application();
37			$this->application->add(new YumlCommand());
38			$this->command = $this->application->find('yuml:mappings');
39
40			$this->commandTester = new CommandTester($this->command);
41
42			$yumlClient = $this->getMock('Onurb\\Bundle\\YumlBundle\\Yuml\\YumlClientInterface');
43
44			$yumlClient->expects($this->once())
45			->method('makeDslText')
46			->will($this->returnValue('[Simple.Entity\|+a;b;c]'));
47
48			$yumlClient->expects($this->once())
49			->method('getGraphUrl')
50			->will($this->returnValue(self::YUML_LINK));
51
52			$this->container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerInterface');
53
54			$this->container->expects($this->once())->method('get')
55			->with($this->matches('onurb_yuml.client'))
56			->will($this->returnValue($yumlClient));
57
58			$this->container->expects($this->any())->method('getParameter')
59			->will(
60			$this->returnCallback(
61			function($arg) {
			0 ignored issues – show Coding Style introduced 2017-04-09 09:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 space after FUNCTION keyword; 0 found Loading history...
62			switch ($arg) {
63			case 'onurb_yuml.show_fields_description':
64			return false;
65			break;
			0 ignored issues – show Unused Code introduced 2017-04-09 09:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
66			case 'onurb_yuml.colors':
67			case 'onurb_yuml.notes':
68			return array();
69			break;
			0 ignored issues – show Unused Code introduced 2017-04-09 09:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
70			default:
71			return false;
72			}
73			}
74			)
75			);
76
77			$this->command->setContainer($this->container);
78			}
79
80			/**
81			* @covers \Onurb\Bundle\YumlBundle\Command\YumlCommand
82			*/
83			public function testExecute()
84			{
85			$this->commandTester->execute(array('command' => $this->command->getName()));
86			$this->assertRegExp('/.../', $this->commandTester->getDisplay());
87			$this->assertSame('Downloaded', explode(' ', $this->commandTester->getDisplay())[0]);
88			}
89			}
90

Nono1971 / doctrine-yuml-bundle

GitHub Access Token became invalid

Push — master ( 0165b3...f3e283 )

Bundle/YumlBundle/Command/YumlCommandTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like