YumlCommandTest - Code Metrics - Inspection of "fix yuml url" - Nono1971/doctrine-yuml-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( de6a2c...9b028d )

by Bruno

created 2016-12-21 23:49 UTC

YumlCommandTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	4
dl	0
loc	81
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
B	setUp()	28	1
A	testExecute()	6	1
A	testExecuteWithFilenameOption()	14	1

<?php
namespace OnurbTest\Bundle\YumlBundle\Command;

use Onurb\Bundle\YumlBundle\Command\YumlCommand;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Tester\CommandTester;
use Symfony\Component\DependencyInjection\ContainerInterface;

class YumlCommandTest extends \PHPUnit_Framework_TestCase
{
    const YUML_LINK  = 'https://yuml.me/15a98c92.png';

    /**
     * @var Application
     */
    private $application;

    /**
     * @var YumlCommand
     */
    private $command;

    /**
     * @var ContainerInterface
     */
    private $container;

    /**
     * @var CommandTester
     */
    private $commandTester;

    public function setUp()
    {
        parent::setUp();
        $this->application = new Application();
        $this->application->add(new YumlCommand());
        $this->command = $this->application->find('yuml:mappings');

        $this->commandTester = new CommandTester($this->command);

        $yumlClient = $this->getMock('Onurb\\Bundle\\YumlBundle\\Yuml\\YumlClientInterface');

        $yumlClient->expects($this->once())
            ->method('makeDslText')
            ->will($this->returnValue('[Simple.Entity|+a;b;c]'));

        $yumlClient->expects($this->once())
            ->method('getGraphUrl')
            ->will($this->returnValue(self::YUML_LINK));

        $this->container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerInterface');

        $this->container->expects($this->once())->method('get')
            ->with($this->matches('onurb.doctrine_yuml.client'))
            ->will($this->returnValue($yumlClient));

        $this->command->setContainer($this->container);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

    }

    /**
     * @covers \Onurb\Bundle\YumlBundle\Command\YumlCommand
     */
    public function testExecute()
    {
        $this->commandTester->execute(array('command' => $this->command->getName()));
        $this->assertRegExp('/.../', $this->commandTester->getDisplay());
        $this->assertSame('Downloaded', explode(' ', $this->commandTester->getDisplay())[0]);
    }

    /**
     * @covers \Onurb\Bundle\YumlBundle\Command\YumlCommand
     */
    public function testExecuteWithFilenameOption()
    {
        $filename = 'testFilename.png';
        $this->commandTester->execute(
            array(
                'command' => $this->command->getName(),
                '--filename' => $filename
            )
        );
        $this->assertSame(
            'Downloaded ' . self::YUML_LINK . ' to '. $filename,
            explode("\r\n",$this->commandTester->getDisplay())[0]
        );
    }
}


GitHub Access Token became invalid

Push — master ( de6a2c...9b028d )

YumlCommandTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

1			<?php
2			namespace OnurbTest\Bundle\YumlBundle\Command;
3
4			use Onurb\Bundle\YumlBundle\Command\YumlCommand;
5			use Symfony\Component\Console\Application;
6			use Symfony\Component\Console\Tester\CommandTester;
7			use Symfony\Component\DependencyInjection\ContainerInterface;
8
9			class YumlCommandTest extends \PHPUnit_Framework_TestCase
10			{
11			const YUML_LINK = 'https://yuml.me/15a98c92.png';
12
13			/**
14			* @var Application
15			*/
16			private $application;
17
18			/**
19			* @var YumlCommand
20			*/
21			private $command;
22
23			/**
24			* @var ContainerInterface
25			*/
26			private $container;
27
28			/**
29			* @var CommandTester
30			*/
31			private $commandTester;
32
33			public function setUp()
34			{
35			parent::setUp();
36			$this->application = new Application();
37			$this->application->add(new YumlCommand());
38			$this->command = $this->application->find('yuml:mappings');
39
40			$this->commandTester = new CommandTester($this->command);
41
42			$yumlClient = $this->getMock('Onurb\\Bundle\\YumlBundle\\Yuml\\YumlClientInterface');
43
44			$yumlClient->expects($this->once())
45			->method('makeDslText')
46			->will($this->returnValue('[Simple.Entity\|+a;b;c]'));
47
48			$yumlClient->expects($this->once())
49			->method('getGraphUrl')
50			->will($this->returnValue(self::YUML_LINK));
51
52			$this->container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerInterface');
53
54			$this->container->expects($this->once())->method('get')
55			->with($this->matches('onurb.doctrine_yuml.client'))
56			->will($this->returnValue($yumlClient));
57
58			$this->command->setContainer($this->container);
			0 ignored issues – show Bug introduced 2016-12-22 00:04 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Console\Command\Command` as the method `setContainer()` does only exist in the following sub-classes of `Symfony\Component\Console\Command\Command`: `Doctrine\Bundle\Doctrine...DatabaseDoctrineCommand`, `Doctrine\Bundle\Doctrine...Command\DoctrineCommand`, `Doctrine\Bundle\Doctrine...DatabaseDoctrineCommand`, `Doctrine\Bundle\Doctrine...EntitiesDoctrineCommand`, `Doctrine\Bundle\Doctrine...tMappingDoctrineCommand`, `Onurb\Bundle\YumlBundle\Command\YumlCommand`, `Sensio\Bundle\GeneratorB...d\GenerateBundleCommand`, `Sensio\Bundle\GeneratorB...\GenerateCommandCommand`, `Sensio\Bundle\GeneratorB...nerateControllerCommand`, `Sensio\Bundle\GeneratorB...GenerateDoctrineCommand`, `Sensio\Bundle\GeneratorB...rateDoctrineCrudCommand`, `Sensio\Bundle\GeneratorB...teDoctrineEntityCommand`, `Sensio\Bundle\GeneratorB...rateDoctrineFormCommand`, `Sensio\Bundle\GeneratorB...ommand\GeneratorCommand`, `Symfony\Bundle\Framework...d\AbstractConfigCommand`, `Symfony\Bundle\Framework...nd\AssetsInstallCommand`, `Symfony\Bundle\Framework...mmand\CacheClearCommand`, `Symfony\Bundle\Framework...d\CachePoolClearCommand`, `Symfony\Bundle\Framework...mand\CacheWarmupCommand`, `Symfony\Bundle\Framework...mand\ConfigDebugCommand`, `Symfony\Bundle\Framework...figDumpReferenceCommand`, `Symfony\Bundle\Framework...d\ContainerAwareCommand`, `Symfony\Bundle\Framework...d\ContainerDebugCommand`, `Symfony\Bundle\Framework...tDispatcherDebugCommand`, `Symfony\Bundle\Framework...mand\RouterDebugCommand`, `Symfony\Bundle\Framework...mand\RouterMatchCommand`, `Symfony\Bundle\Framework...e\Command\ServerCommand`, `Symfony\Bundle\Framework...ommand\ServerRunCommand`, `Symfony\Bundle\Framework...mand\ServerStartCommand`, `Symfony\Bundle\Framework...and\ServerStatusCommand`, `Symfony\Bundle\Framework...mmand\ServerStopCommand`, `Symfony\Bundle\Framework...TranslationDebugCommand`, `Symfony\Bundle\Framework...ranslationUpdateCommand`, `Symfony\Bundle\Framework...and\WorkflowDumpCommand`, `Symfony\Bundle\SecurityB...\Command\InitAclCommand`, `Symfony\Bundle\SecurityB...e\Command\SetAclCommand`, `Symfony\Bundle\SecurityB...rPasswordEncoderCommand`, `Symfony\Bundle\TwigBundle\Command\DebugCommand`, `Symfony\Bundle\TwigBundle\Command\LintCommand`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
59
60			}
61
62			/**
63			* @covers \Onurb\Bundle\YumlBundle\Command\YumlCommand
64			*/
65			public function testExecute()
66			{
67			$this->commandTester->execute(array('command' => $this->command->getName()));
68			$this->assertRegExp('/.../', $this->commandTester->getDisplay());
69			$this->assertSame('Downloaded', explode(' ', $this->commandTester->getDisplay())[0]);
70			}
71
72			/**
73			* @covers \Onurb\Bundle\YumlBundle\Command\YumlCommand
74			*/
75			public function testExecuteWithFilenameOption()
76			{
77			$filename = 'testFilename.png';
78			$this->commandTester->execute(
79			array(
80			'command' => $this->command->getName(),
81			'--filename' => $filename
82			)
83			);
84			$this->assertSame(
85			'Downloaded ' . self::YUML_LINK . ' to '. $filename,
86			explode("\r\n",$this->commandTester->getDisplay())[0]
87			);
88			}
89			}
90

Nono1971 / doctrine-yuml-bundle

GitHub Access Token became invalid

Push — master ( de6a2c...9b028d )

YumlCommandTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like