NoOne4rever / Axessors

src/HandlersProcessor.php

<?php
/**
 * This file is a part of "Axessors" library.
 *
 * @author <NoOne4rever@gmail.com>
 * @license GPL
 */

namespace NoOne4rever\Axessors;

/**
 * Class HandlersProcessor.
 * 
 * Processes Axessors handlers.
 * 
 * @package NoOne4rever\Axessors
 */
class HandlersProcessor extends TokenProcessor
{
    /**
     * Creates list of handlers from a string of handlers definition.
     *
     * @param string $handlers handlers
     * @return string[] handlers
     */
    private function makeHandlersList(string $handlers): array
    {
        if ($handlers === '') {
            return [];
        }
        $injProcessor = new InjectedStringSuit($handlers);
        $result = $injProcessor->addSlashes(',')->get();
        $result = preg_split('{(?<!\\\\),\s*}', $result);
        foreach ($result as &$handler) {
            $injProcessor = new InjectedStringSuit(stripcslashes($handler));
            $handler = $injProcessor->resolveClassNames($this->namespace)->processThis()->wrapWithClosure()->get();
        }
        return $result;

The expression return $result could return the type false which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    /**
     * Creates list of handlers for input data.
     *
     * @return string[] handlers
     */
    public function processInputData(): array
    {
        return $this->makeHandlersList($this->input);

The expression return $this->makeHandlersList($this->input) returns an array which contains values of type array which are incompatible with the documented value type string.

    }

    /**
     * Creates list of handlers for output data.
     *
     * @return string[] handlers
     */
    public function processOutputData(): array
    {
        return $this->makeHandlersList($this->output);

The expression return $this->makeHandlersList($this->output) returns an array which contains values of type array which are incompatible with the documented value type string.

    }
}