NoBrainerQuiz / web

app/Http/Controllers/QuizController.php

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Models\Quiz;
use App\Models\User;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Auth;
use Validator;
use App\Repositories\Repository;

/**
 * @TODO separate controllers for host and user. 
 * implement repositories.
 */

class QuizController extends Controller
{

    protected $model;

    public function __construct(Quiz $quiz)
    {
        $this->model = new Repository($quiz);
    }

    public function showIndexWelcome()
    {
        return view('index.welcome');
    }

    public function showHostDashboard()
    {
        // Move to trait/facade/logic class @TODO
        $quizCount = DB::table('user_quizzes')->where('user_id', Auth::user()->id)->count();

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return view('quiz_host.dashboard.index')->with('quizCount', $quizCount);
    }

    public function showHostManageQuizzes()
    {
        $quizzes = Quiz::leftJoin('user_quizzes', 'user_quizzes.quiz_id', 'quizzes.id')
                        ->join('users', 'user_quizzes.user_id', '=', 'users.id')
                        ->where('users.id', Auth::user()->id)

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                        ->get();

        return view('quiz_host.dashboard.manage-quizzes')->with('quizzes', $quizzes);
    }

    public function create()
    {
        return view('quiz_host.dashboard.quiz.create');
    }

    public function store(Request $request)
    {
        // @TODO use validator facade over $request->validate();
        $validator = $request->validate([

The assignment to $validator is dead and can be removed.

            'quiz_name'        => 'required|max:30',
            'quiz_description' => 'required|max:500'
        ]);

        $quiz = new Quiz;
        $quiz->quiz_name = $request->get('quiz_name');
        $quiz->quiz_description = $request->get('quiz_description');
        $quiz->active = '0';
        $quiz->quiz_pin = '5555';
        $quiz->save();

        $user = Auth::user();
        $quiz->user()->attach($user);

        return redirect()->route('quiz_host.dashboard.manage-quizzes')->with('quizCreated', 'Whoa ' . Auth::user()->username . ', you have created a quiz! Now it\'s time to add some questions');

Accessing username on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function edit($id) 
    {
        try {
            $quiz = Quiz::findOrFail($id);
        } catch (ModelNotFoundException $e) {
            return redirect()->route('quiz_host.dashboard.manage-quizzes');
        }

        return view('quiz_host.dashboard.quiz.edit')->with('quiz', $quiz);
    }

    public function activate($id) 
    {
        try {
            $quiz = Quiz::findOrFail($id);

The assignment to $quiz is dead and can be removed.

        } catch (ModelNotFoundException $e) {
            return redirect()->route('quiz_host.dashboard.manage-quizzes');
        }
    }

    public function destroy($id) 
    {
        try {
            $quiz = Quiz::findOrFail($id);
        } catch (ModelNotFoundException $e) {
            return redirect()->route('quiz_host.dashboard.manage-quizzes');
        }

        $quiz->delete();
        $quiz->user()->detach(Auth::user());
        return redirect()->route('quiz_host.dashboard.manage-quizzes')->with('quizDeleted', 'Quiz succesfully deleted.');

    }

    public function showQuestion()
    {
        return view('quiz_user.question');
    }

    public function showPin()
    {
        return view('quiz_user.pin');
    }

    public function leaderboards()
    {
        return view('quiz_user.leaderboard');
    }


    public function showSplash()
    {
        return view('quiz_user.splash');
    }

    public function enterQuizPin(Request $request)
    {
        // @TODO - PIN max length needs to be dynamic with trait
        // will sort out soon - Matt.
        $validatedData = $request->validate([

The assignment to $validatedData is dead and can be removed.

            'pin'      => 'required|string'
        ]);

        try {
            $quiz = Quiz::where('quiz_pin', $request->get('pin'))
                    ->where('active', '1')
                    ->firstOrFail();
        } catch (ModelNotFoundException $e) {
            return back()->with('pin_error', 'Either the quiz doesn\'t exist, or it hasn\'t been activated');
        }

        //Add user to the socket.io stuff!
        event(new \App\Events\addUser($request->get('username'))); //Adds the user to the socket stuff
        return redirect()->route('quiz_user.showSplash')->with('quizData', $quiz);
    }
}