QuizController::enterQuizPin() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/NoBrai..." - NoBrainerQuiz/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 45d072...34f708 )

by Matt

created 2018-02-25 22:44 UTC

QuizController::enterQuizPin() A

↳ Parent: QuizController

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	10
nc	2
nop	1
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Models\Quiz;

class QuizController extends Controller
{
    public function showIndexWelcome()
    {
        return view('index.welcome');
    }

    public function showHostDashboard()
    {
        return view('quiz_host.dashboard.index');
    }

    public function showQuestion()
    {
        return view('quiz_user.question');
    }

    public function showPin()
    {
        return view('quiz_user.pin');
    }

    public function showSplash()
    {
        return view('quiz_user.splash');
    }

    public function enterQuizPin(Request $request)
    {
        // @TODO - PIN max length needs to be dynamic with trait
        // will sort out soon - Matt.
        $validatedData = $request->validate([

            'pin'      => 'required|string'
        ]);

        // FIX XSS HERE ALSO
        $quiz = Quiz::where('quiz_pin', $request->get('pin'))
                    ->where('active', 1)
                    ->first();

        if (!$quiz->exists()) {
            return back()->with('pin_error', 'Either the quiz doesn\'t exist, or it hasn\'t been activated');
        } else {
            //Add user to the socket.io stuff!
            event(new \App\Events\addUser($request->get('username'))); //Adds the user to the socket stuff
            return redirect()->route('quiz_user.showSplash')->with('quizData', $quiz);
        }
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use App\Models\Quiz;
7
8			class QuizController extends Controller
9			{
10			public function showIndexWelcome()
11			{
12			return view('index.welcome');
13			}
14
15			public function showHostDashboard()
16			{
17			return view('quiz_host.dashboard.index');
18			}
19
20			public function showQuestion()
21			{
22			return view('quiz_user.question');
23			}
24
25			public function showPin()
26			{
27			return view('quiz_user.pin');
28			}
29
30			public function showSplash()
31			{
32			return view('quiz_user.splash');
33			}
34
35			public function enterQuizPin(Request $request)
36			{
37			// @TODO - PIN max length needs to be dynamic with trait
38			// will sort out soon - Matt.
39			$validatedData = $request->validate([
			0 ignored issues – show Unused Code introduced 2018-02-24 03:02 UTC by Report Bug Copy Issue Report The assignment to `$validatedData` is dead and can be removed. Loading history...
40			'pin' => 'required\|string'
41			]);
42
43			// FIX XSS HERE ALSO
44			$quiz = Quiz::where('quiz_pin', $request->get('pin'))
45			->where('active', 1)
46			->first();
47
48			if (!$quiz->exists()) {
49			return back()->with('pin_error', 'Either the quiz doesn\'t exist, or it hasn\'t been activated');
50			} else {
51			//Add user to the socket.io stuff!
52			event(new \App\Events\addUser($request->get('username'))); //Adds the user to the socket stuff
53			return redirect()->route('quiz_user.showSplash')->with('quizData', $quiz);
54			}
55			}
56			}
57

NoBrainerQuiz / web

Push — master ( 45d072...34f708 )

QuizController::enterQuizPin() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like