QuizController::edit() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/NoBrai..." - NoBrainerQuiz/web - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 637398...2f17a8 )

by Matt

created 2018-03-10 18:17 UTC

QuizController::edit() A

↳ Parent: QuizController

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Models\Quiz;
use App\Models\User;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Auth;
use Validator;
use App\Repositories\Repository;

/**
 * @TODO separate controllers for host and user. 
 * implement repositories.
 */

class QuizController extends Controller
{

    protected $model;

    public function __construct(Quiz $quiz)
    {
        $this->model = new Repository($quiz);
    }

    public function showIndexWelcome()
    {
        return view('index.welcome');
    }

    public function showHostDashboard()
    {
        // Move to trait/facade/logic class @TODO
        $quizCount = DB::table('user_quizzes')->where('user_id', Auth::user()->id)->count();

        return view('quiz_host.dashboard.index')->with('quizCount', $quizCount);
    }

    public function showHostManageQuizzes()
    {
        $quizzes = Quiz::leftJoin('user_quizzes', 'user_quizzes.quiz_id', 'quizzes.id')
                        ->join('users', 'user_quizzes.user_id', '=', 'users.id')
                        ->where('users.id', Auth::user()->id)

                        ->get();

        return view('quiz_host.dashboard.manage-quizzes')->with('quizzes', $quizzes);
    }

    public function create()
    {
        return view('quiz_host.dashboard.quiz.create');
    }

    public function store(Request $request)
    {
        // @TODO use validator facade over $request->validate();

        $validator = $request->validate([

            'quiz_name'        => 'required|max:30',
            'quiz_description' => 'required|max:500'
        ]);

        $quiz = new Quiz;
        $quiz->quiz_name = $request->get('quiz_name');
        $quiz->quiz_description = $request->get('quiz_description');
        $quiz->active = '0';
        $quiz->quiz_pin = '5555';
        $quiz->save();

        $user = Auth::user();
        $quiz->user()->attach($user);

        return redirect()->route('quiz_host.dashboard.manage-quizzes')->with('quizCreated', 'Whoa ' . Auth::user()->username . ', you have created a quiz! Now it\'s time to add some questions');


    }

    public function edit($id) 
    {
        try {
            $quiz = Quiz::findOrFail($id);
        } catch (ModelNotFoundException $e) {
            return redirect()->route('quiz_host.dashboard.manage-quizzes');
        }

        return view('quiz_host.dashboard.quiz.edit')->with('quiz', $quiz);
    }

    public function destroy($id) 
    {
        try {
            $quiz = Quiz::findOrFail($id);
        } catch (ModelNotFoundException $e) {
            return redirect()->route('quiz_host.dashboard.manage-quizzes');
        }

        $quiz->delete();
        $quiz->user()->detach(Auth::user());
        return redirect()->route('quiz_host.dashboard.manage-quizzes')->with('quizDeleted', 'Quiz succesfully deleted.');

    }

    public function showQuestion()
    {
        return view('quiz_user.question');
    }

    public function showPin()
    {
        return view('quiz_user.pin');
    }

    public function leaderboards()
    {
        return view('quiz_user.leaderboard');
    }


    public function showSplash()
    {
        return view('quiz_user.splash');
    }

    public function enterQuizPin(Request $request)
    {
        // @TODO - PIN max length needs to be dynamic with trait
        // will sort out soon - Matt.
        $validatedData = $request->validate([

            'pin'      => 'required|string'
        ]);

        try {
            $quiz = Quiz::where('quiz_pin', $request->get('pin'))
                    ->where('active', '1')
                    ->firstOrFail();
        } catch (ModelNotFoundException $e) {
            return back()->with('pin_error', 'Either the quiz doesn\'t exist, or it hasn\'t been activated');
        }

        //Add user to the socket.io stuff!
        event(new \App\Events\addUser($request->get('username'))); //Adds the user to the socket stuff
        return redirect()->route('quiz_user.showSplash')->with('quizData', $quiz);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use App\Models\Quiz;
7			use App\Models\User;
8			use Illuminate\Database\Eloquent\ModelNotFoundException;
9			use Illuminate\Support\Facades\DB;
10			use Illuminate\Support\Facades\Auth;
11			use Validator;
12			use App\Repositories\Repository;
13
14			/**
15			* @TODO separate controllers for host and user.
16			* implement repositories.
17			*/
18
19			class QuizController extends Controller
20			{
21
22			protected $model;
23
24			public function __construct(Quiz $quiz)
25			{
26			$this->model = new Repository($quiz);
27			}
28
29			public function showIndexWelcome()
30			{
31			return view('index.welcome');
32			}
33
34			public function showHostDashboard()
35			{
36			// Move to trait/facade/logic class @TODO
37			$quizCount = DB::table('user_quizzes')->where('user_id', Auth::user()->id)->count();
			0 ignored issues – show Bug introduced 2018-02-28 02:14 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
38			return view('quiz_host.dashboard.index')->with('quizCount', $quizCount);
39			}
40
41			public function showHostManageQuizzes()
42			{
43			$quizzes = Quiz::leftJoin('user_quizzes', 'user_quizzes.quiz_id', 'quizzes.id')
44			->join('users', 'user_quizzes.user_id', '=', 'users.id')
45			->where('users.id', Auth::user()->id)
			0 ignored issues – show Bug introduced 2018-02-28 02:14 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
46			->get();
47
48			return view('quiz_host.dashboard.manage-quizzes')->with('quizzes', $quizzes);
49			}
50
51			public function create()
52			{
53			return view('quiz_host.dashboard.quiz.create');
54			}
55
56			public function store(Request $request)
57			{
58			// @TODO use validator facade over $request->validate();
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-03-10 18:31 UTC by Report Bug Copy Issue Report `39%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
59			$validator = $request->validate([
			0 ignored issues – show Unused Code introduced 2018-03-10 18:31 UTC by Report Bug Copy Issue Report The assignment to `$validator` is dead and can be removed. Loading history...
60			'quiz_name' => 'required\|max:30',
61			'quiz_description' => 'required\|max:500'
62			]);
63
64			$quiz = new Quiz;
65			$quiz->quiz_name = $request->get('quiz_name');
66			$quiz->quiz_description = $request->get('quiz_description');
67			$quiz->active = '0';
68			$quiz->quiz_pin = '5555';
69			$quiz->save();
70
71			$user = Auth::user();
72			$quiz->user()->attach($user);
73
74			return redirect()->route('quiz_host.dashboard.manage-quizzes')->with('quizCreated', 'Whoa ' . Auth::user()->username . ', you have created a quiz! Now it\'s time to add some questions');
			0 ignored issues – show Bug introduced 2018-03-10 18:31 UTC by Report Bug Copy Issue Report Accessing `username` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
75
76			}
77
78			public function edit($id)
79			{
80			try {
81			$quiz = Quiz::findOrFail($id);
82			} catch (ModelNotFoundException $e) {
83			return redirect()->route('quiz_host.dashboard.manage-quizzes');
84			}
85
86			return view('quiz_host.dashboard.quiz.edit')->with('quiz', $quiz);
87			}
88
89			public function destroy($id)
90			{
91			try {
92			$quiz = Quiz::findOrFail($id);
93			} catch (ModelNotFoundException $e) {
94			return redirect()->route('quiz_host.dashboard.manage-quizzes');
95			}
96
97			$quiz->delete();
98			$quiz->user()->detach(Auth::user());
99			return redirect()->route('quiz_host.dashboard.manage-quizzes')->with('quizDeleted', 'Quiz succesfully deleted.');
100
101			}
102
103			public function showQuestion()
104			{
105			return view('quiz_user.question');
106			}
107
108			public function showPin()
109			{
110			return view('quiz_user.pin');
111			}
112
113			public function leaderboards()
114			{
115			return view('quiz_user.leaderboard');
116			}
117
118
119			public function showSplash()
120			{
121			return view('quiz_user.splash');
122			}
123
124			public function enterQuizPin(Request $request)
125			{
126			// @TODO - PIN max length needs to be dynamic with trait
127			// will sort out soon - Matt.
128			$validatedData = $request->validate([
			0 ignored issues – show Unused Code introduced 2018-02-24 03:02 UTC by Report Bug Copy Issue Report The assignment to `$validatedData` is dead and can be removed. Loading history...
129			'pin' => 'required\|string'
130			]);
131
132			try {
133			$quiz = Quiz::where('quiz_pin', $request->get('pin'))
134			->where('active', '1')
135			->firstOrFail();
136			} catch (ModelNotFoundException $e) {
137			return back()->with('pin_error', 'Either the quiz doesn\'t exist, or it hasn\'t been activated');
138			}
139
140			//Add user to the socket.io stuff!
141			event(new \App\Events\addUser($request->get('username'))); //Adds the user to the socket stuff
142			return redirect()->route('quiz_user.showSplash')->with('quizData', $quiz);
143			}
144			}
145

NoBrainerQuiz / web

Push — master ( 637398...2f17a8 )

QuizController::edit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like