StrongCoupling::getMessage() - Code Metrics - Niktux/solidifier - Measure and Improve Code Quality continuously with Scrutinizer

StrongCoupling::getMessage() A
last analyzed 2017-03-09 18:25 UTC

↳ Parent: StrongCoupling

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	0

<?php

namespace Solidifier\Defects;

use Solidifier\Defect;
use Solidifier\Visitors\ObjectType;
use PhpParser\Node\Expr\New_;

class StrongCoupling extends Defect

{
    private
        $objectType;
class A {
    var $property;
}
        
    public function __construct(ObjectType $objectType, New_ $node)
    {
        parent::__construct($node);
        
        $this->objectType = $objectType;
    }    
    
    public function getMessage()
    {
        return sprintf(
            'Allocation in %s <type>%s</type> (instanciate %s)',
            $this->objectType->type,
            $this->objectType->fullname,
            $this->node->class
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        );
    }
}


1		<?php
2
3		namespace Solidifier\Defects;
4
5		use Solidifier\Defect;
6		use Solidifier\Visitors\ObjectType;
7		use PhpParser\Node\Expr\New_;
8
9	View Code Duplication	class StrongCoupling extends Defect
		0 ignored issues – show Duplication introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		private
12		$objectType;
		0 ignored issues – show Coding Style introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$objectType`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
13
14		public function __construct(ObjectType $objectType, New_ $node)
15		{
16		parent::__construct($node);
17
18		$this->objectType = $objectType;
19		}
20
21		public function getMessage()
22		{
23		return sprintf(
24		'Allocation in %s <type>%s</type> (instanciate %s)',
25		$this->objectType->type,
26		$this->objectType->fullname,
27		$this->node->class
		0 ignored issues – show Bug introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report Accessing `class` on the interface `PhpParser\Node` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
28		);
29		}
30		}
31

Niktux / solidifier

StrongCoupling::getMessage() A last analyzed 2017-03-09 18:25 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

StrongCoupling::getMessage() A
last analyzed 2017-03-09 18:25 UTC