Application::initializeServices() - Code Metrics - Niktux/solidifier - Measure and Improve Code Quality continuously with Scrutinizer

Application::initializeServices() A
last analyzed 2017-03-09 18:25 UTC

↳ Parent: Application

Complexity

Conditions	3
Paths	1

Size

Total Lines	57
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	57
rs	9.6818
c	0
b	0
f	0
cc	3
eloc	30
nc	1
nop	0

How to fix Long Method

<?php

namespace Solidifier;

use Symfony\Component\EventDispatcher\EventDispatcher;
use Gaufrette\Filesystem;
use Solidifier\Reporters\HTMLReporter;
use Symfony\Component\Yaml\Yaml;
use Gaufrette\Adapter\Local;
use Solidifier\Visitors\PreAnalyze\ObjectTypes;

class Application extends \Pimple
{
    public function __construct()
    {
        parent::__construct();
        
        $this->initializeFilesystem();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->initializeServices();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->initializeSubscribers();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }
    
    private function initializeFilesystem()
    {
        $this['filesystem.path'] = 'src/';
$a = "a";
$ab = "ab";
$abc = "abc";
        $this['filesystem.adapter'] = function($c) {
            return new Local($c['filesystem.path']);    
        };
        
        $this['filesystem'] = function($c) {
            return new Filesystem($c['filesystem.adapter']);    
        };
    }
    
    private function initializeServices()
    {
        $this['configuration'] = function($c) {
            
            $configuration = array();
            
            $filename = '.solidifier.yml';
            $fs = $c['filesystem'];
$a = "a";
$ab = "ab";
$abc = "abc";
            
            if($fs->has($filename))
            {
                $configuration = Yaml::parse($fs->read($filename));
            }
            
            return $configuration;
        };
        
        $this['event.dispatcher'] = function($c) {

            return new EventDispatcher();
        };
        
        $this['dispatcher'] = function($c) {
            return new Dispatchers\EventDispatcher($c['event.dispatcher']);
        };
        
        $this['analyzer'] = function($c) {
            $analyzer = new Analyzers\Analyzer($c['dispatcher'], $c['filesystem']);

            $handler = new ConfigurationHandler($c['configuration'], $c['objectTypes.list']);
            $handler->configure($analyzer);
            
            return $analyzer;
        };
        
        $this['twig.path'] = 'views';
$a = "a";
$ab = "ab";
$abc = "abc";
        $this['twig.cache'] = false;
        $this['twig.debug'] = true;
        
        $this['twig'] = function($c) {
            $loader = new \Twig_Loader_Filesystem($c['twig.path']);
            $twig = new \Twig_Environment($loader, array(
$a = "a";
$ab = "ab";
$abc = "abc";
                'cache' => $c['twig.cache'],
                'debug' => $c['twig.debug'],
            ));
            
            if($c['twig.debug'] === true)
            {
                $twig->addExtension(new \Twig_Extension_Debug());
            }
            
            return $twig;
        };
        
        $this['objectTypes.list'] = function($c) {

            return new ObjectTypes();    
        };
    }
    
    private function initializeSubscribers()
    {
        $this['subscriber.console'] = function($c) {

            return new EventSubscribers\Console();
        };
        
        $this['reporter.html'] = function($c) {
            return new Reporters\HTMLReporter($c['twig']);
        };
        
        $this['subscriber.html'] = function($c) {
            return new EventSubscribers\HTML($c['reporter.html']);
        };
    }
}

1			<?php
2
3			namespace Solidifier;
4
5			use Symfony\Component\EventDispatcher\EventDispatcher;
6			use Gaufrette\Filesystem;
7			use Solidifier\Reporters\HTMLReporter;
8			use Symfony\Component\Yaml\Yaml;
9			use Gaufrette\Adapter\Local;
10			use Solidifier\Visitors\PreAnalyze\ObjectTypes;
11
12			class Application extends \Pimple
13			{
14			public function __construct()
15			{
16			parent::__construct();
17
18			$this->initializeFilesystem();
			0 ignored issues – show Unused Code introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report The call to the method `Solidifier\Application::initializeFilesystem()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
19			$this->initializeServices();
			0 ignored issues – show Unused Code introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report The call to the method `Solidifier\Application::initializeServices()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
20			$this->initializeSubscribers();
			0 ignored issues – show Unused Code introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report The call to the method `Solidifier\Application::initializeSubscribers()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
21			}
22
23			private function initializeFilesystem()
24			{
25			$this['filesystem.path'] = 'src/';
			0 ignored issues – show Coding Style introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26			$this['filesystem.adapter'] = function($c) {
27			return new Local($c['filesystem.path']);
28			};
29
30			$this['filesystem'] = function($c) {
31			return new Filesystem($c['filesystem.adapter']);
32			};
33			}
34
35			private function initializeServices()
36			{
37			$this['configuration'] = function($c) {
38
39			$configuration = array();
40
41			$filename = '.solidifier.yml';
42			$fs = $c['filesystem'];
			0 ignored issues – show Coding Style introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
43
44			if($fs->has($filename))
45			{
46			$configuration = Yaml::parse($fs->read($filename));
47			}
48
49			return $configuration;
50			};
51
52			$this['event.dispatcher'] = function($c) {
			0 ignored issues – show Unused Code introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
53			return new EventDispatcher();
54			};
55
56			$this['dispatcher'] = function($c) {
57			return new Dispatchers\EventDispatcher($c['event.dispatcher']);
58			};
59
60			$this['analyzer'] = function($c) {
61			$analyzer = new Analyzers\Analyzer($c['dispatcher'], $c['filesystem']);
62
63			$handler = new ConfigurationHandler($c['configuration'], $c['objectTypes.list']);
64			$handler->configure($analyzer);
65
66			return $analyzer;
67			};
68
69			$this['twig.path'] = 'views';
			0 ignored issues – show Coding Style introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
70			$this['twig.cache'] = false;
71			$this['twig.debug'] = true;
72
73			$this['twig'] = function($c) {
74			$loader = new \Twig_Loader_Filesystem($c['twig.path']);
75			$twig = new \Twig_Environment($loader, array(
			0 ignored issues – show Coding Style introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
76			'cache' => $c['twig.cache'],
77			'debug' => $c['twig.debug'],
78			));
79
80			if($c['twig.debug'] === true)
81			{
82			$twig->addExtension(new \Twig_Extension_Debug());
83			}
84
85			return $twig;
86			};
87
88			$this['objectTypes.list'] = function($c) {
			0 ignored issues – show Unused Code introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
89			return new ObjectTypes();
90			};
91			}
92
93			private function initializeSubscribers()
94			{
95			$this['subscriber.console'] = function($c) {
			0 ignored issues – show Unused Code introduced 2017-03-09 18:25 UTC by Report Bug Copy Issue Report The parameter `$c` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
96			return new EventSubscribers\Console();
97			};
98
99			$this['reporter.html'] = function($c) {
100			return new Reporters\HTMLReporter($c['twig']);
101			};
102
103			$this['subscriber.html'] = function($c) {
104			return new EventSubscribers\HTML($c['reporter.html']);
105			};
106			}
107			}

Niktux / solidifier

Application::initializeServices() A last analyzed 2017-03-09 18:25 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Application::initializeServices() A
last analyzed 2017-03-09 18:25 UTC