Solidifier\Visitors\Encapsulation\EncapsulationViolation

Complexity

Total Complexity

19

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	enter()	0	16	4
A	enterProperty()	0	10	3
A	enterClassMethod()	0	19	4
A	isGetterOrSetter()	0	6	2
B	leave()	0	19	5
A	after()	0	4	1

<?php

namespace Solidifier\Visitors\Encapsulation;

use Solidifier\Parser\Visitors\ContextualVisitor;
use PhpParser\Node;
use PhpParser\Node\Stmt\Property;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Class_;

class EncapsulationViolation extends ContextualVisitor
{
    private
        $privateAttributes,

It is generally advisable to only define one property per statement.

The visibility should be declared for property $privateAttributes.

        $publicMethods;
    
    protected function enter(Node $node)
    {
        if($node instanceof Class_)
        {
            $this->privateAttributes = array();
            $this->publicMethods = array();

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        } 
        elseif($node instanceof Property)
        {
            $this->enterProperty($node);
        } 
        elseif($node instanceof ClassMethod)
        {
            $this->enterClassMethod($node);
        }
    }
    
    private function enterProperty(Property $node)
    {
        if($node->isPrivate())
        {
            foreach($node->props as $property)
            {
                $this->privateAttributes[$property->name] = $node;
            }
        }
    }
    
    private function enterClassMethod(ClassMethod $node)
    {
        if($node->isPublic())
        {
            $methodName = $node->name;

            if($this->isGetterOrSetter($methodName))
            {
                $correspondingAttribute = strtolower(substr($methodName, 3));
                
                if(! isset($this->publicMethods[$correspondingAttribute]))
                {
                    $this->publicMethods[$correspondingAttribute] = array();
                }
                
                $this->publicMethods[$correspondingAttribute][] = $methodName;    
            }
        }
    }
    
    private function isGetterOrSetter($methodName)
    {
        $prefix = strtolower(substr($methodName, 0, 3));
        
        return $prefix === 'get' || $prefix === 'set';
    }
    
    protected function leave(Node $node)
    {
        if($node instanceof Class_)
        {
            foreach($this->privateAttributes as $attribute => $attributeNode)
            {
                $key = strtolower($attribute);
                if(isset($this->publicMethods[$key]))
                {
                    if(count($this->publicMethods[$key]) >= 2)
                    {
                        $this->dispatch(
                            new \Solidifier\Defects\EncapsulationViolation($attribute, $attributeNode)
                        );
                    }
                }
            }
        }   
    }
    
    protected function after(array $nodes)
    {
        
    }   
}